• file
• latest
• revisions
• annotate
• diff
• comparison
• raw

src/gaim-send-async@17bf39d2678f (annotated)

src/gaim-send-async

Wed, 16 Nov 2005 18:17:01 +0000

author

Casey Harkins <charkins@pidgin.im>

date

Wed, 16 Nov 2005 18:17:01 +0000

changeset 12116

17bf39d2678f

parent 11332

35bbaaee70a7

child 13221

98e6b83ab770

permissions

-rwxr-xr-x

[gaim-migrate @ 14416]
" This patch implements a replacement for the queuing
system from 1.x. It also obsoletes a previous patch
[#1338873] I submitted to prioritize the unseen states
in gtk conversations.

The attached envelope.png is ripped from the
msgunread.png already included in gaim. It should be
dropped in the pixmaps directory (Makefile.am is
updated accordingly in this patch).

The two separate queuing preferences from 1.x, queuing
messages while away and queuing all new messages (from
docklet), are replaced with a single 3-way preference
for conversations. The new preference is "Hide new IM
conversations". This preference can be set to never,
away and always.

When a gtk conversation is created, it may be placed in
a hidden conversation window instead of being placed
normally. This decision is based upon the preference
and possibly the away state of the account the
conversation is being created for. This *will* effect
conversations the user explicitly requests to be
created, so in these cases the caller must be sure to
present the conversation to the user, using
gaim_gtkconv_present_conversation(). This is done
already in gtkdialogs.c which handles creating
conversations requested by the user from gaim proper
(menus, double-clicking on budy in blist, etc.).

The main advantage to not queuing messages is that the
conversations exist, the message is written to the
conversation (and logged if appropriate) and the unseen
state is set on the conversation. This means no
additional features are needed to track whether there
are queued messages or not, just use the unseen state
on conversations.

Since conversations may not be visible (messages
"queued"), gaim proper needs some notification that
there are messages waiting. I opted for a menutray icon
that shows up when an im conversation has an unseen
message. Clicking this icon will focus (and show if
hidden) the first conversation with an unseen message.
This is essentially the same behavior of the docklet in
cvs right now, except that the icon is only visible
when there is a conversation with an unread message.

The api that is added is flexible enough to allow
either the docklet or the new blist menutray icon to be
visible for conversations of any/all types and for
unseen messages >= any state. Currently they are set to
only IM conversations and only unseen states >= TEXT
(system messages and no log messages will not trigger
blinking the docklet or showing the blist tray icon),
but these could be made preferences relatively easily
in the future. Other plugins could probably benefit as
well: gaim_gtk_conversations_get_first_unseen().

There is probably some limit to comment size, so I'll
stop rambling now. If anyone has more
questions/comments, catch me in #gaim, here or on
gaim-devel."

committer: Luke Schierer <lschiere@pidgin.im>

11332 35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	1	#!/bin/bash
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	2
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	3	METHOD_NAME=$1
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	4
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	5	if test -z "$METHOD_NAME"
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	6	then
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	7	cat <<EOF
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	8	This program calls gaim API functions using DBus. As opposed to gaim-send,
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	9	it does not print the return value.
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	10
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	11	Usage:
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	12
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	13	$0 method-name type1:parameter1 type2:parameter2 ...
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	14
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	15	This shell script just invokes dbus-send, see man dbus-send for how
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	16	to specify the parameters.
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	17
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	18	Examples:
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	19
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	20	$0 GaimCoreQuit
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	21
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	22	Use dbus-viewer to get the list of supported functions and their parameters.
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	23	EOF
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	24	exit 1
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	25	fi
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	26
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	27	shift
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	28	dbus-send --dest=org.gaim.GaimService --type=method_call /org/gaim/GaimObject org.gaim.GaimInterface.$METHOD_NAME "$@"
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	29
35bbaaee70a7 [gaim-migrate @ 13545] Piotr Zielinski <zielaj@users.sourceforge.net> parents: diff changeset	30	echo