HACKING@1dff6e343f9f (annotated)
HACKING
Mon, 12 Sep 2016 08:55:35 -0500
- author
- Mike Ruprecht <cmaiku@gmail.com>
- date
- Mon, 12 Sep 2016 08:55:35 -0500
- changeset 38142
- 1dff6e343f9f
- parent 33955
- 55aa58076485
- permissions
- -rw-r--r--
gg: Protect against issues when closing while connecting
Since the GIOStream is cancelled when data is freed, any cancelled
callbacks are called after such data is freed. This patch guards against
cancelled calls by safely returning without accessing any freed data if
the connection has been cancelled (aka closed).
Futhermore, if GG tries to connect and is quickly disconnected,
ggp_tcpsocket_close() is never called. As far as I can tell, it's an
existing bug, but PurpleSockets both work differently when closing and
are closed by the connection if any leak. So the issue wasn't a major
problem. This patch lessens the issue by guarding against it, but it
should be fixed at some point.
|
16235
ba05596c81b3
Let's just have HACKING point to Trac, okay?
Richard Laager <rlaager@pidgin.im>
parents:
diff
changeset
|
1 | For information on hacking on Pidgin, Finch, or libpurple, see: |
|
33955
55aa58076485
Use https URLs for pidgin.im and developer.pidgin.im.
Mark Doliner <mark@kingant.net>
parents:
16239
diff
changeset
|
2 | https://developer.pidgin.im |
