pidgin/gtksourceiter.h@210f318db492 (annotated)
pidgin/gtksourceiter.h
Tue, 09 Jul 2024 02:03:20 -0500
- author
- Yoann Congal <yoann.congal@smile.fr>
- date
- Tue, 09 Jul 2024 02:03:20 -0500
- branch
- release-2.x.y
- changeset 42808
- 210f318db492
- parent 26727
- b8885bab55ab
- child 35451
- 206524351826
- permissions
- -rw-r--r--
Fix incompatible pointer types for GtkItemFactoryCallbacks on gcc-14
The GtkItemFactoryEntry struct callback is of type GtkItemFactoryCallbacks
(aka void (*)(void)) but is initialised with GtkItemFactoryCallback1 types
(aka void (*)(void *, guint, GtkWidget *)).
This is coherent with the gtk-2 documentation:
> gtk_item_factory_create_items(..., GtkItemFactoryEntry *entries,...)
> entries : an array of GtkItemFactoryEntrys whose callback members must by of
> type GtkItemFactoryCallback1
But, under gcc-14, the implicit cast from GtkItemFactoryCallback1 to
GtkItemFactoryCallback triggers an incompatible-pointer-types error (See [gcc-doc]).
An exemple of this error:
pidgin/gtkconv.c:3096:66: error: initialization of 'void (*)(void)' from incompatible pointer type 'void (*)(void *, guint, GtkWidget *)' {aka 'void (*)(void *, unsigned int, struct _GtkWidget *)'} [-Wincompatible-pointer-types]
3096 | { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb,
| ^~~~~~~~~~~~~~~~
pidgin/gtkconv.c:3096:66: note: (near initialization for 'menu_items[1].callback')
To fix this, explicitely cast to GtkItemFactoryCallback where needed.
[0]: https://gcc.gnu.org/gcc-14/porting_to.html#incompatible-pointer-types
Testing Done:
Built with gcc-14, started and clicked on some affected menus
Reviewed at https://reviews.imfreedom.org/r/3282/
|
25888
d0fdd378a635
Remove trailing whitespace
Mark Doliner <markdoliner@pidgin.im>
parents:
19859
diff
changeset
|
1 | /* -*- Mode: C; tab-width: 8; indent-tabs-mode: t; c-basic-offset: 8 -*- |
| 7358 | 2 | * gtksourceiter.h |
| 3 | * | |
| 15572 | 4 | * Pidgin is the legal property of its developers, whose names are too numerous |
| 8046 | 5 | * to list here. Please refer to the COPYRIGHT file distributed with this |
| 6 | * source distribution. | |
| 7358 | 7 | * |
|
12465
59859abbe998
[gaim-migrate @ 14775]
Peter Lawler <pidgin@bleeter.id.au>
parents:
10566
diff
changeset
|
8 | * The following copyright notice applies to this file: |
|
59859abbe998
[gaim-migrate @ 14775]
Peter Lawler <pidgin@bleeter.id.au>
parents:
10566
diff
changeset
|
9 | * |
|
25888
d0fdd378a635
Remove trailing whitespace
Mark Doliner <markdoliner@pidgin.im>
parents:
19859
diff
changeset
|
10 | * Copyright (C) 2000 - 2005 Paolo Maggi |
|
12465
59859abbe998
[gaim-migrate @ 14775]
Peter Lawler <pidgin@bleeter.id.au>
parents:
10566
diff
changeset
|
11 | * Copyright (C) 2002, 2003 Jeroen Zwartepoorte |
|
59859abbe998
[gaim-migrate @ 14775]
Peter Lawler <pidgin@bleeter.id.au>
parents:
10566
diff
changeset
|
12 | * |
| 7358 | 13 | * This program is free software; you can redistribute it and/or modify |
| 14 | * it under the terms of the GNU Library General Public License as published by | |
| 15 | * the Free Software Foundation; either version 2 of the License, or | |
| 16 | * (at your option) any later version. | |
| 17 | * | |
| 18 | * This program is distributed in the hope that it will be useful, | |
| 19 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 20 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
| 21 | * GNU Library General Public License for more details. | |
| 22 | * | |
| 23 | * You should have received a copy of the GNU Library General Public License | |
| 24 | * along with this program; if not, write to the Free Software | |
|
19859
71d37b57eff2
The FSF changed its address a while ago; our files were out of date.
John Bailey <rekkanoryo@rekkanoryo.org>
parents:
15572
diff
changeset
|
25 | * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301, USA. |
| 7358 | 26 | */ |
|
12465
59859abbe998
[gaim-migrate @ 14775]
Peter Lawler <pidgin@bleeter.id.au>
parents:
10566
diff
changeset
|
27 | |
|
15562
8c8249fe5e3c
gaim_gtk to pidgin. I hope
Sean Egan <seanegan@pidgin.im>
parents:
15435
diff
changeset
|
28 | #ifndef _PIDGINSOURCEITER_H_ |
|
8c8249fe5e3c
gaim_gtk to pidgin. I hope
Sean Egan <seanegan@pidgin.im>
parents:
15435
diff
changeset
|
29 | #define _PIDGINSOURCEITER_H_ |
| 7358 | 30 | |
|
26727
b8885bab55ab
More updates for GTK+ 3.0. This only fixes the single-includes. Fixing all
Elliott Sales de Andrade <qulogic@pidgin.im>
parents:
25888
diff
changeset
|
31 | #include <gtk/gtk.h> |
| 7358 | 32 | |
| 33 | G_BEGIN_DECLS | |
| 34 | ||
| 35 | typedef enum | |
| 36 | { | |
|
12465
59859abbe998
[gaim-migrate @ 14775]
Peter Lawler <pidgin@bleeter.id.au>
parents:
10566
diff
changeset
|
37 | GTK_SOURCE_SEARCH_VISIBLE_ONLY = 1 << 0, |
|
59859abbe998
[gaim-migrate @ 14775]
Peter Lawler <pidgin@bleeter.id.au>
parents:
10566
diff
changeset
|
38 | GTK_SOURCE_SEARCH_TEXT_ONLY = 1 << 1, |
|
59859abbe998
[gaim-migrate @ 14775]
Peter Lawler <pidgin@bleeter.id.au>
parents:
10566
diff
changeset
|
39 | GTK_SOURCE_SEARCH_CASE_INSENSITIVE = 1 << 2 |
| 7358 | 40 | /* Possible future plans: SEARCH_REGEXP */ |
| 41 | } GtkSourceSearchFlags; | |
| 42 | ||
| 10566 | 43 | gboolean gtk_source_iter_forward_search (const GtkTextIter *iter, |
| 7358 | 44 | const gchar *str, |
| 45 | GtkSourceSearchFlags flags, | |
| 46 | GtkTextIter *match_start, | |
| 47 | GtkTextIter *match_end, | |
| 48 | const GtkTextIter *limit); | |
| 49 | ||
| 10566 | 50 | gboolean gtk_source_iter_backward_search (const GtkTextIter *iter, |
| 7358 | 51 | const gchar *str, |
| 52 | GtkSourceSearchFlags flags, | |
| 53 | GtkTextIter *match_start, | |
| 54 | GtkTextIter *match_end, | |
| 55 | const GtkTextIter *limit); | |
| 56 | ||
| 10566 | 57 | gboolean gtk_source_iter_find_matching_bracket (GtkTextIter *iter); |
| 7358 | 58 | |
| 59 | G_END_DECLS | |
| 60 | ||
|
15562
8c8249fe5e3c
gaim_gtk to pidgin. I hope
Sean Egan <seanegan@pidgin.im>
parents:
15435
diff
changeset
|
61 | #endif /* _PIDGINSOURCEITER_H_ */ |
