Mon, 22 Aug 2011 02:07:41 +0000
Don't use strlen() when all you're trying to do is check if the string
is empty
| 2086 | 1 | /* This file is part of the Project Athena Zephyr Notification System. |
| 2 | * It contains source for the ZFormatRawNoticeList function. | |
| 3 | * | |
| 4 | * Created by: Robert French | |
| 5 | * | |
| 6 | * Copyright (c) 1987 by the Massachusetts Institute of Technology. | |
| 7 | * For copying and distribution information, see the file | |
|
31294
73607ab89c6f
Remove trailing whitespace
Richard Laager <rlaager@pidgin.im>
parents:
15435
diff
changeset
|
8 | * "mit-copyright.h". |
| 2086 | 9 | */ |
| 10 | ||
|
8792
b0645c9dc276
[gaim-migrate @ 9554]
Christian Hammond <chipx86@chipx86.com>
parents:
2086
diff
changeset
|
11 | #include "internal.h" |
| 2086 | 12 | |
| 13 | Code_t ZFormatRawNoticeList(notice, list, nitems, buffer, ret_len) | |
| 14 | ZNotice_t *notice; | |
| 15 | char *list[]; | |
| 16 | int nitems; | |
| 17 | char **buffer; | |
| 18 | int *ret_len; | |
| 19 | { | |
| 20 | char header[Z_MAXHEADERLEN]; | |
| 21 | int hdrlen, i, size; | |
| 22 | char *ptr; | |
| 23 | Code_t retval; | |
| 24 | ||
| 25 | if ((retval = Z_FormatRawHeader(notice, header, sizeof(header), | |
| 26 | &hdrlen, NULL, NULL)) != ZERR_NONE) | |
| 27 | return (retval); | |
| 28 | ||
| 29 | size = 0; | |
| 30 | for (i=0;i<nitems;i++) | |
| 31 | size += strlen(list[i])+1; | |
| 32 | ||
| 33 | *ret_len = hdrlen+size; | |
|
31294
73607ab89c6f
Remove trailing whitespace
Richard Laager <rlaager@pidgin.im>
parents:
15435
diff
changeset
|
34 | |
| 2086 | 35 | if (!(*buffer = (char *) malloc((unsigned) *ret_len))) |
| 36 | return (ENOMEM); | |
| 37 | ||
| 38 | (void) memcpy(*buffer, header, hdrlen); | |
|
31294
73607ab89c6f
Remove trailing whitespace
Richard Laager <rlaager@pidgin.im>
parents:
15435
diff
changeset
|
39 | |
| 2086 | 40 | ptr = *buffer+hdrlen; |
| 41 | ||
| 42 | for (;nitems;nitems--, list++) { | |
| 43 | i = strlen(*list)+1; | |
| 44 | (void) memcpy(ptr, *list, i); | |
| 45 | ptr += i; | |
| 46 | } | |
| 47 | ||
| 48 | return (ZERR_NONE); | |
| 49 | } |