Mercurial > pidgin3 / annotate

• file
• latest
• revisions
• annotate
• diff
• comparison
• raw

pidgin/plugins/perl/common/GtkPrivacy.xs@616dc666cfb8 (annotated)

pidgin/plugins/perl/common/GtkPrivacy.xs

Sat, 28 Apr 2007 02:33:40 +0000

author

Luke Schierer <lschiere@pidgin.im>

date

Sat, 28 Apr 2007 02:33:40 +0000

changeset 16621

616dc666cfb8

parent 15899

75f0041f72b8

child 18068

b6554e3c8224

permissions

-rw-r--r--

Quoth Charkins:
This patch has two changes:

"This patch has two changes:

First is to slightly change the re-creation behavior of the docklet. Sadrul pointed out on gaim-devel that the x11 docklet re-creates itself when it is destroyed and thought this might be causing problems with fluxbox. This patch now distinguishes between initial creation and re-creation. When re-creating, the docklet no longer registers itself as a visibility manager until it successfully embeds.

Second is to change the timeout behavior for embedding. Because the notification area API is asynchronous, gaim assumes the docklet gets embeded for a certain timeout period, allowing the buddy list to start hidden before the docklet has been embeded in the notification area. If the timeout occurs, it is removed as a visibility manager and the buddy list will become visible. This timeout has been set at 5 seconds. There have been a few reports that indicate this timeout period is not long enough when starting gaim from a saved session upon login. I have been hesitant to increase the timeout, as it has the potential of delaying the startup of gaim for the timeout period if the buddy list was hidden when gaim last closed and there is not currently a notification area available. This patch makes the x11 docklet track whether it was successfully embedded and uses a longer timeout (15 seconds in this patch) only if it successfully embedded on the previous execution. Otherwise, it uses the shorter 5 second timeout. "