libpurple/protocols/jabber/roster.c

Tue, 21 Mar 2023 02:07:16 -0500

author
Elliott Sales de Andrade <quantum.analyst@gmail.com>
date
Tue, 21 Mar 2023 02:07:16 -0500
changeset 42176
8f7b46f497c6
parent 41967
025eee9e6f1d
permissions
-rw-r--r--

Remove libsoup2 code

Soup 3 has been required since /r/2068.

Testing Done:
Compiled only.

Reviewed at https://reviews.imfreedom.org/r/2375/

7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
1 /*
15884
4de1981757fc sed -ie 's/gaim/purple/g'
Sean Egan <seanegan@pidgin.im>
parents: 15847
diff changeset
2 * purple - Jabber Protocol Plugin
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
3 *
28322
ac8fec1d2234 Remove specific copyright lines from the XMPP prpl.
Paul Aurich <darkrain42@pidgin.im>
parents: 28071
diff changeset
4 * Purple is the legal property of its developers, whose names are too numerous
ac8fec1d2234 Remove specific copyright lines from the XMPP prpl.
Paul Aurich <darkrain42@pidgin.im>
parents: 28071
diff changeset
5 * to list here. Please refer to the COPYRIGHT file distributed with this
ac8fec1d2234 Remove specific copyright lines from the XMPP prpl.
Paul Aurich <darkrain42@pidgin.im>
parents: 28071
diff changeset
6 * source distribution.
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
7 *
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
8 * This program is free software; you can redistribute it and/or modify
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
9 * it under the terms of the GNU General Public License as published by
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
10 * the Free Software Foundation; either version 2 of the License, or
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
11 * (at your option) any later version.
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
12 *
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
13 * This program is distributed in the hope that it will be useful,
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
16 * GNU General Public License for more details.
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
17 *
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
18 * You should have received a copy of the GNU General Public License
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
19 * along with this program; if not, write to the Free Software
19859
71d37b57eff2 The FSF changed its address a while ago; our files were out of date.
John Bailey <rekkanoryo@rekkanoryo.org>
parents: 19630
diff changeset
20 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
21 *
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
22 */
40358
e6fe6fc1f516 move all protocols, purple plugins, and purple tests to use purple.h instead of including files individually
Gary Kramlich <grim@reaperworld.com>
parents: 40096
diff changeset
23 #include <purple.h>
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
24
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
25 #include "buddy.h"
28431
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
26 #include "chat.h"
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
27 #include "presence.h"
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
28 #include "roster.h"
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
29 #include "iq.h"
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
30
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
31 #include <string.h>
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
32
41791
3bf884522663 xmpp: Remove unused prototypes and code
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 40726
diff changeset
33 static const gchar *jabber_roster_group_get_global_name(PurpleGroup *group);
3bf884522663 xmpp: Remove unused prototypes and code
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 40726
diff changeset
34
27282
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
35 /* Take a list of strings and join them with a ", " separator */
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
36 static gchar *roster_groups_join(GSList *list)
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
37 {
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
38 GString *out = g_string_new(NULL);
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
39 for ( ; list; list = list->next) {
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
40 out = g_string_append(out, (const char *)list->data);
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
41 if (list->next)
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
42 out = g_string_append(out, ", ");
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
43 }
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
44
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
45 return g_string_free(out, FALSE);
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
46 }
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
47
41967
025eee9e6f1d Bump C standard to C99 for XMPP and fix warnings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41791
diff changeset
48 static void
025eee9e6f1d Bump C standard to C99 for XMPP and fix warnings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41791
diff changeset
49 roster_request_cb(JabberStream *js, const char *from, JabberIqType type,
025eee9e6f1d Bump C standard to C99 for XMPP and fix warnings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41791
diff changeset
50 const char *id, PurpleXmlNode *packet,
025eee9e6f1d Bump C standard to C99 for XMPP and fix warnings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41791
diff changeset
51 G_GNUC_UNUSED gpointer data)
29096
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
52 {
34935
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
53 PurpleXmlNode *query;
29096
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
54
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
55 if (type == JABBER_IQ_ERROR) {
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
56 /*
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
57 * This shouldn't happen in any real circumstances and
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
58 * likely constitutes a server-side misconfiguration (i.e.
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
59 * explicitly not loading mod_roster...)
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
60 */
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
61 purple_debug_error("jabber", "Error retrieving roster!?\n");
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
62 jabber_stream_set_state(js, JABBER_STREAM_CONNECTED);
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
63 return;
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
64 }
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
65
34935
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
66 query = purple_xmlnode_get_child(packet, "query");
29096
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
67 if (query == NULL) {
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
68 jabber_stream_set_state(js, JABBER_STREAM_CONNECTED);
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
69 return;
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
70 }
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
71
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
72 jabber_roster_parse(js, from, type, id, query);
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
73 jabber_stream_set_state(js, JABBER_STREAM_CONNECTED);
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
74 }
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
75
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
76 void jabber_roster_request(JabberStream *js)
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
77 {
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
78 JabberIq *iq;
29096
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
79
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
80 iq = jabber_iq_new_query(js, JABBER_IQ_GET, "jabber:iq:roster");
29103
aefa3f414775 jabber: The google roster request code was so lonely, so let's just drop-kick it and add the little custom logic to roster.c
Paul Aurich <darkrain42@pidgin.im>
parents: 29096
diff changeset
81
29096
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
82 jabber_iq_set_callback(iq, roster_request_cb, NULL);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
83 jabber_iq_send(iq);
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
84 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
85
15884
4de1981757fc sed -ie 's/gaim/purple/g'
Sean Egan <seanegan@pidgin.im>
parents: 15847
diff changeset
86 static void remove_purple_buddies(JabberStream *js, const char *jid)
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
87 {
40052
cc03b5af25ea Use GSList functions instead of manual iterations
qarkai <qarkai@gmail.com>
parents: 39915
diff changeset
88 GSList *buddies;
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
89
34728
8efd73063ecf Renamed buddy list functions to more appropriate/simler names.
Ankit Vani <a@nevitus.org>
parents: 34717
diff changeset
90 buddies = purple_blist_find_buddies(purple_connection_get_account(js->gc), jid);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
91
40052
cc03b5af25ea Use GSList functions instead of manual iterations
qarkai <qarkai@gmail.com>
parents: 39915
diff changeset
92 g_slist_free_full(buddies, (GDestroyNotify)purple_blist_remove_buddy);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
93 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
94
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
95 static void add_purple_buddy_to_groups(JabberStream *js, const char *jid,
28071
a0706162fefd jabber: Store the "own JabberBuddy" in the JabberStream* struct.
Paul Aurich <darkrain42@pidgin.im>
parents: 27743
diff changeset
96 const char *alias, GSList *groups)
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
97 {
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
98 GSList *buddies, *l;
28758
6fb73f2ab8e2 jabber: Remove the roster pool stuff.
Paul Aurich <darkrain42@pidgin.im>
parents: 28622
diff changeset
99 PurpleAccount *account = purple_connection_get_account(js->gc);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
100
34728
8efd73063ecf Renamed buddy list functions to more appropriate/simler names.
Ankit Vani <a@nevitus.org>
parents: 34717
diff changeset
101 buddies = purple_blist_find_buddies(purple_connection_get_account(js->gc), jid);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
102
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
103 if(!groups) {
35958
1d8446f396b6 blist: define default group better
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 35499
diff changeset
104 if(!buddies) {
36009
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
105 groups = g_slist_append(groups, g_strdup(JABBER_ROSTER_DEFAULT_GROUP));
35958
1d8446f396b6 blist: define default group better
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 35499
diff changeset
106 } else {
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
107 /* TODO: What should we do here? Removing the local buddies
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
108 * is wrong, but so is letting the group state get out of sync with
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
109 * the server.
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
110 */
20221
28e31ee832cd applied changes from e56db1b8a7bb8729e30fb3bf99a94ff7887fe4ec
Luke Schierer <lschiere@pidgin.im>
parents: 19859
diff changeset
111 g_slist_free(buddies);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
112 return;
20221
28e31ee832cd applied changes from e56db1b8a7bb8729e30fb3bf99a94ff7887fe4ec
Luke Schierer <lschiere@pidgin.im>
parents: 19859
diff changeset
113 }
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
114 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
115
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
116 while(buddies) {
15884
4de1981757fc sed -ie 's/gaim/purple/g'
Sean Egan <seanegan@pidgin.im>
parents: 15847
diff changeset
117 PurpleBuddy *b = buddies->data;
4de1981757fc sed -ie 's/gaim/purple/g'
Sean Egan <seanegan@pidgin.im>
parents: 15847
diff changeset
118 PurpleGroup *g = purple_buddy_get_group(b);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
119
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
120 buddies = g_slist_delete_link(buddies, buddies);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
121
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
122 /* XMPP groups are case-sensitive, but libpurple groups are
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
123 * case-insensitive. We treat a buddy in both "Friends" and "friends"
27743
ce49b08a7990 Clarify a comment a little.
Paul Aurich <darkrain42@pidgin.im>
parents: 27742
diff changeset
124 * as only being in one group, but if we push changes about the buddy
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
125 * to the server, the buddy will be dropped from one of the groups.
27743
ce49b08a7990 Clarify a comment a little.
Paul Aurich <darkrain42@pidgin.im>
parents: 27742
diff changeset
126 * Not optimal, but better than the alternative, I think.
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
127 */
36009
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
128 l = g_slist_find_custom(groups, purple_group_get_name(g),
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
129 (GCompareFunc)purple_utf8_strcasecmp);
35960
407e0fa6f7d1 blist: don't localize roster group name to avoid contact splitting
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 35958
diff changeset
130 if (!l && g == purple_blist_get_default_group()) {
36009
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
131 l = g_slist_find_custom(groups, JABBER_ROSTER_DEFAULT_GROUP,
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
132 (GCompareFunc)purple_utf8_strcasecmp);
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
133 }
35961
87fd9126902a blist: store localized name of default group to avoid contact splitting
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 35960
diff changeset
134 if (!l && g == purple_blist_get_default_group()) {
87fd9126902a blist: store localized name of default group to avoid contact splitting
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 35960
diff changeset
135 l = g_slist_find_custom(groups,
87fd9126902a blist: store localized name of default group to avoid contact splitting
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 35960
diff changeset
136 _purple_blist_get_localized_default_group_name(),
87fd9126902a blist: store localized name of default group to avoid contact splitting
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 35960
diff changeset
137 (GCompareFunc)purple_utf8_strcasecmp);
87fd9126902a blist: store localized name of default group to avoid contact splitting
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 35960
diff changeset
138 }
36009
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
139
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
140 if (l) {
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
141 /* The buddy is already on the local list. Update info. */
24950
143f594f0cd0 Alias foo. I think blist.h structs are now completely hidden.
Sadrul Habib Chowdhury <sadrul@pidgin.im>
parents: 24398
diff changeset
142 const char *servernick, *balias;
7955
fdb05712d343 [gaim-migrate @ 8630]
Nathan Walp <nwalp@pidgin.im>
parents: 7488
diff changeset
143
24199
8606cb4e94f5 The alias we retrieve from the roster is a private alias; use purple_serv_got_private_alias() to tell the core about it
Evan Schoenberg <evands@pidgin.im>
parents: 23975
diff changeset
144 /* Previously stored serverside / buddy-supplied alias */
15884
4de1981757fc sed -ie 's/gaim/purple/g'
Sean Egan <seanegan@pidgin.im>
parents: 15847
diff changeset
145 if((servernick = purple_blist_node_get_string((PurpleBlistNode*)b, "servernick")))
35499
c4c5e0a670b1 Fix namespaces issues in libpurple.
Ankit Vani <a@nevitus.org>
parents: 34935
diff changeset
146 purple_serv_got_alias(js->gc, jid, servernick);
7955
fdb05712d343 [gaim-migrate @ 8630]
Nathan Walp <nwalp@pidgin.im>
parents: 7488
diff changeset
147
24199
8606cb4e94f5 The alias we retrieve from the roster is a private alias; use purple_serv_got_private_alias() to tell the core about it
Evan Schoenberg <evands@pidgin.im>
parents: 23975
diff changeset
148 /* Alias from our roster retrieval */
34717
b3e588adef5a Global replace purple_buddy_get_local_buddy_alias() with purple_buddy_get_local_alias()
Ankit Vani <a@nevitus.org>
parents: 34699
diff changeset
149 balias = purple_buddy_get_local_alias(b);
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
150 if(alias && !purple_strequal(alias, balias))
24199
8606cb4e94f5 The alias we retrieve from the roster is a private alias; use purple_serv_got_private_alias() to tell the core about it
Evan Schoenberg <evands@pidgin.im>
parents: 23975
diff changeset
151 purple_serv_got_private_alias(js->gc, jid, alias);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
152 g_free(l->data);
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
153 groups = g_slist_delete_link(groups, l);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
154 } else {
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
155 /* This buddy isn't in the group on the server anymore */
35960
407e0fa6f7d1 blist: don't localize roster group name to avoid contact splitting
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 35958
diff changeset
156 purple_debug_info("jabber", "jabber_roster_parse(): "
407e0fa6f7d1 blist: don't localize roster group name to avoid contact splitting
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 35958
diff changeset
157 "Removing %s from group '%s' on the local list",
407e0fa6f7d1 blist: don't localize roster group name to avoid contact splitting
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 35958
diff changeset
158 purple_buddy_get_name(b),
407e0fa6f7d1 blist: don't localize roster group name to avoid contact splitting
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 35958
diff changeset
159 jabber_roster_group_get_global_name(g));
28758
6fb73f2ab8e2 jabber: Remove the roster pool stuff.
Paul Aurich <darkrain42@pidgin.im>
parents: 28622
diff changeset
160 purple_blist_remove_buddy(b);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
161 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
162 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
163
27282
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
164 if (groups) {
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
165 char *tmp = roster_groups_join(groups);
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
166 purple_debug_info("jabber", "jabber_roster_parse(): Adding %s to "
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
167 "groups: %s\n", jid, tmp);
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
168 g_free(tmp);
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
169 }
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
170
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
171 while(groups) {
34728
8efd73063ecf Renamed buddy list functions to more appropriate/simler names.
Ankit Vani <a@nevitus.org>
parents: 34717
diff changeset
172 PurpleGroup *g = purple_blist_find_group(groups->data);
28758
6fb73f2ab8e2 jabber: Remove the roster pool stuff.
Paul Aurich <darkrain42@pidgin.im>
parents: 28622
diff changeset
173 PurpleBuddy *b = purple_buddy_new(account, jid, alias);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
174
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
175 if(!g) {
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
176 g = purple_group_new(groups->data);
15884
4de1981757fc sed -ie 's/gaim/purple/g'
Sean Egan <seanegan@pidgin.im>
parents: 15847
diff changeset
177 purple_blist_add_group(g, NULL);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
178 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
179
15884
4de1981757fc sed -ie 's/gaim/purple/g'
Sean Egan <seanegan@pidgin.im>
parents: 15847
diff changeset
180 purple_blist_add_buddy(b, NULL, g, NULL);
34728
8efd73063ecf Renamed buddy list functions to more appropriate/simler names.
Ankit Vani <a@nevitus.org>
parents: 34717
diff changeset
181 purple_buddy_set_local_alias(b, alias);
13987
b5b1db6007b0 [gaim-migrate @ 16442]
Mark Doliner <markdoliner@pidgin.im>
parents: 13809
diff changeset
182
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
183 g_free(groups->data);
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
184 groups = g_slist_delete_link(groups, groups);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
185 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
186 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
187
25817
09d6a40a341d Pass IQ handlers type, from, id, and the child node
Paul Aurich <darkrain42@pidgin.im>
parents: 24672
diff changeset
188 void jabber_roster_parse(JabberStream *js, const char *from,
34935
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
189 JabberIqType type, const char *id, PurpleXmlNode *query)
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
190 {
34935
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
191 PurpleXmlNode *item, *group;
7445
f325eaaabe1c [gaim-migrate @ 8052]
Nathan Walp <nwalp@pidgin.im>
parents: 7425
diff changeset
192
27275
a7836fbdcfa2 Use jabber_is_own_account and perform way fewer normalizations per iteration
Paul Aurich <darkrain42@pidgin.im>
parents: 27242
diff changeset
193 if (!jabber_is_own_account(js, from)) {
a7836fbdcfa2 Use jabber_is_own_account and perform way fewer normalizations per iteration
Paul Aurich <darkrain42@pidgin.im>
parents: 27242
diff changeset
194 purple_debug_warning("jabber", "Received bogon roster push from %s\n",
a7836fbdcfa2 Use jabber_is_own_account and perform way fewer normalizations per iteration
Paul Aurich <darkrain42@pidgin.im>
parents: 27242
diff changeset
195 from);
a7836fbdcfa2 Use jabber_is_own_account and perform way fewer normalizations per iteration
Paul Aurich <darkrain42@pidgin.im>
parents: 27242
diff changeset
196 return;
7175
6d9b937e084f [gaim-migrate @ 7743]
Nathan Walp <nwalp@pidgin.im>
parents: 7171
diff changeset
197 }
6d9b937e084f [gaim-migrate @ 7743]
Nathan Walp <nwalp@pidgin.im>
parents: 7171
diff changeset
198
23975
8ee397f04ca9 We talked about this and decided it was probably cleaner to not use
Mark Doliner <markdoliner@pidgin.im>
parents: 23961
diff changeset
199 js->currently_parsing_roster_push = TRUE;
23961
0a9e9676f7b5 Hopefully fix the XMPP contact flipping/swapping between groups bug
Mark Doliner <markdoliner@pidgin.im>
parents: 23566
diff changeset
200
34935
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
201 for(item = purple_xmlnode_get_child(query, "item"); item; item = purple_xmlnode_get_next_twin(item))
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
202 {
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
203 const char *jid, *name, *subscription, *ask;
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
204 JabberBuddy *jb;
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
205
34935
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
206 subscription = purple_xmlnode_get_attrib(item, "subscription");
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
207 jid = purple_xmlnode_get_attrib(item, "jid");
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
208 name = purple_xmlnode_get_attrib(item, "name");
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
209 ask = purple_xmlnode_get_attrib(item, "ask");
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
210
8347
745bfd589263 [gaim-migrate @ 9071]
Nathan Walp <nwalp@pidgin.im>
parents: 8194
diff changeset
211 if(!jid)
745bfd589263 [gaim-migrate @ 9071]
Nathan Walp <nwalp@pidgin.im>
parents: 8194
diff changeset
212 continue;
745bfd589263 [gaim-migrate @ 9071]
Nathan Walp <nwalp@pidgin.im>
parents: 8194
diff changeset
213
745bfd589263 [gaim-migrate @ 9071]
Nathan Walp <nwalp@pidgin.im>
parents: 8194
diff changeset
214 if(!(jb = jabber_buddy_find(js, jid, TRUE)))
745bfd589263 [gaim-migrate @ 9071]
Nathan Walp <nwalp@pidgin.im>
parents: 8194
diff changeset
215 continue;
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
216
10289
18f2c2afebaf [gaim-migrate @ 11464]
Nathan Walp <nwalp@pidgin.im>
parents: 9990
diff changeset
217 if(subscription) {
38256
035f00c4fd87 Replace misused g_str_equal() with purple_strequal()
qarkai <qarkai@gmail.com>
parents: 38091
diff changeset
218 if (purple_strequal(subscription, "remove"))
29114
b3876f83a46c jabber: Fix removing a self-contact.
Paul Aurich <darkrain42@pidgin.im>
parents: 29103
diff changeset
219 jb->subscription = JABBER_SUB_REMOVE;
b3876f83a46c jabber: Fix removing a self-contact.
Paul Aurich <darkrain42@pidgin.im>
parents: 29103
diff changeset
220 else if (jb == js->user_jb)
12285
5a0f4619b0c5 [gaim-migrate @ 14589]
Etan Reisner <deryni@pidgin.im>
parents: 12088
diff changeset
221 jb->subscription = JABBER_SUB_BOTH;
38256
035f00c4fd87 Replace misused g_str_equal() with purple_strequal()
qarkai <qarkai@gmail.com>
parents: 38091
diff changeset
222 else if (purple_strequal(subscription, "none"))
12285
5a0f4619b0c5 [gaim-migrate @ 14589]
Etan Reisner <deryni@pidgin.im>
parents: 12088
diff changeset
223 jb->subscription = JABBER_SUB_NONE;
38256
035f00c4fd87 Replace misused g_str_equal() with purple_strequal()
qarkai <qarkai@gmail.com>
parents: 38091
diff changeset
224 else if (purple_strequal(subscription, "to"))
10289
18f2c2afebaf [gaim-migrate @ 11464]
Nathan Walp <nwalp@pidgin.im>
parents: 9990
diff changeset
225 jb->subscription = JABBER_SUB_TO;
38256
035f00c4fd87 Replace misused g_str_equal() with purple_strequal()
qarkai <qarkai@gmail.com>
parents: 38091
diff changeset
226 else if (purple_strequal(subscription, "from"))
10289
18f2c2afebaf [gaim-migrate @ 11464]
Nathan Walp <nwalp@pidgin.im>
parents: 9990
diff changeset
227 jb->subscription = JABBER_SUB_FROM;
38256
035f00c4fd87 Replace misused g_str_equal() with purple_strequal()
qarkai <qarkai@gmail.com>
parents: 38091
diff changeset
228 else if (purple_strequal(subscription, "both"))
10289
18f2c2afebaf [gaim-migrate @ 11464]
Nathan Walp <nwalp@pidgin.im>
parents: 9990
diff changeset
229 jb->subscription = JABBER_SUB_BOTH;
18f2c2afebaf [gaim-migrate @ 11464]
Nathan Walp <nwalp@pidgin.im>
parents: 9990
diff changeset
230 }
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
231
27276
d3c4ec6e0b2f Remove this; it's been commented out for about 3.5 years.
Paul Aurich <darkrain42@pidgin.im>
parents: 27275
diff changeset
232 if(purple_strequal(ask, "subscribe"))
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
233 jb->subscription |= JABBER_SUB_PENDING;
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
234 else
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
235 jb->subscription &= ~JABBER_SUB_PENDING;
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
236
28622
5d971bd4b001 jabber: Fix removing a buddy with a pending subscription.
Paul Aurich <darkrain42@pidgin.im>
parents: 28584
diff changeset
237 if(jb->subscription & JABBER_SUB_REMOVE) {
15884
4de1981757fc sed -ie 's/gaim/purple/g'
Sean Egan <seanegan@pidgin.im>
parents: 15847
diff changeset
238 remove_purple_buddies(js, jid);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
239 } else {
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
240 GSList *groups = NULL;
20221
28e31ee832cd applied changes from e56db1b8a7bb8729e30fb3bf99a94ff7887fe4ec
Luke Schierer <lschiere@pidgin.im>
parents: 19859
diff changeset
241
34935
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
242 for(group = purple_xmlnode_get_child(item, "group"); group; group = purple_xmlnode_get_next_twin(group)) {
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
243 char *group_name = purple_xmlnode_get_data(group);
13809
f7ca528786bc [gaim-migrate @ 16232]
Don Seiler <rizzo@gentoo.org>
parents: 12285
diff changeset
244
31794
9725839f5a19 jabber: Treat empty <group/> elements as "Buddies", not ""
Paul Aurich <darkrain42@pidgin.im>
parents: 30744
diff changeset
245 if (group_name == NULL || *group_name == '\0')
9725839f5a19 jabber: Treat empty <group/> elements as "Buddies", not ""
Paul Aurich <darkrain42@pidgin.im>
parents: 30744
diff changeset
246 /* Changing this string? Look in add_purple_buddy_to_groups */
36009
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
247 group_name = g_strdup(JABBER_ROSTER_DEFAULT_GROUP);
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
248
29373
481ec7d852d7 jabber: Fix another corner case that introduced duplicates to the list.
Paul Aurich <darkrain42@pidgin.im>
parents: 29358
diff changeset
249 /*
481ec7d852d7 jabber: Fix another corner case that introduced duplicates to the list.
Paul Aurich <darkrain42@pidgin.im>
parents: 29358
diff changeset
250 * See the note in add_purple_buddy_to_groups; the core handles
481ec7d852d7 jabber: Fix another corner case that introduced duplicates to the list.
Paul Aurich <darkrain42@pidgin.im>
parents: 29358
diff changeset
251 * names case-insensitively and this is required to not
481ec7d852d7 jabber: Fix another corner case that introduced duplicates to the list.
Paul Aurich <darkrain42@pidgin.im>
parents: 29358
diff changeset
252 * end up with duplicates if a buddy is in, e.g.,
481ec7d852d7 jabber: Fix another corner case that introduced duplicates to the list.
Paul Aurich <darkrain42@pidgin.im>
parents: 29358
diff changeset
253 * 'XMPP' and 'xmpp'
481ec7d852d7 jabber: Fix another corner case that introduced duplicates to the list.
Paul Aurich <darkrain42@pidgin.im>
parents: 29358
diff changeset
254 */
481ec7d852d7 jabber: Fix another corner case that introduced duplicates to the list.
Paul Aurich <darkrain42@pidgin.im>
parents: 29358
diff changeset
255 if (g_slist_find_custom(groups, group_name, (GCompareFunc)purple_utf8_strcasecmp))
481ec7d852d7 jabber: Fix another corner case that introduced duplicates to the list.
Paul Aurich <darkrain42@pidgin.im>
parents: 29358
diff changeset
256 g_free(group_name);
481ec7d852d7 jabber: Fix another corner case that introduced duplicates to the list.
Paul Aurich <darkrain42@pidgin.im>
parents: 29358
diff changeset
257 else
481ec7d852d7 jabber: Fix another corner case that introduced duplicates to the list.
Paul Aurich <darkrain42@pidgin.im>
parents: 29358
diff changeset
258 groups = g_slist_prepend(groups, group_name);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
259 }
27277
8a2ecbdd70e4 Various roster cleanups. Refs #7008.
Paul Aurich <darkrain42@pidgin.im>
parents: 27276
diff changeset
260
28071
a0706162fefd jabber: Store the "own JabberBuddy" in the JabberStream* struct.
Paul Aurich <darkrain42@pidgin.im>
parents: 27743
diff changeset
261 add_purple_buddy_to_groups(js, jid, name, groups);
a0706162fefd jabber: Store the "own JabberBuddy" in the JabberStream* struct.
Paul Aurich <darkrain42@pidgin.im>
parents: 27743
diff changeset
262 if (jb == js->user_jb)
a0706162fefd jabber: Store the "own JabberBuddy" in the JabberStream* struct.
Paul Aurich <darkrain42@pidgin.im>
parents: 27743
diff changeset
263 jabber_presence_fake_to_self(js, NULL);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
264 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
265 }
18196
a7992a42dc3d fix inital presence (fixes #1395)
Nathan Walp <nwalp@pidgin.im>
parents: 15884
diff changeset
266
29358
27de2111e8a1 jabber: Send the RFC-mandated ack IQ
Paul Aurich <darkrain42@pidgin.im>
parents: 29185
diff changeset
267 if (type == JABBER_IQ_SET) {
27de2111e8a1 jabber: Send the RFC-mandated ack IQ
Paul Aurich <darkrain42@pidgin.im>
parents: 29185
diff changeset
268 JabberIq *ack = jabber_iq_new(js, JABBER_IQ_RESULT);
27de2111e8a1 jabber: Send the RFC-mandated ack IQ
Paul Aurich <darkrain42@pidgin.im>
parents: 29185
diff changeset
269 jabber_iq_set_id(ack, id);
27de2111e8a1 jabber: Send the RFC-mandated ack IQ
Paul Aurich <darkrain42@pidgin.im>
parents: 29185
diff changeset
270 jabber_iq_send(ack);
27de2111e8a1 jabber: Send the RFC-mandated ack IQ
Paul Aurich <darkrain42@pidgin.im>
parents: 29185
diff changeset
271 }
27de2111e8a1 jabber: Send the RFC-mandated ack IQ
Paul Aurich <darkrain42@pidgin.im>
parents: 29185
diff changeset
272
29096
362b96f6f3da jabber: Roster Versioning support.
Paul Aurich <darkrain42@pidgin.im>
parents: 28758
diff changeset
273 js->currently_parsing_roster_push = FALSE;
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
274 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
275
27283
9a69f682a3ca Operate on the passed-in GSList.
Paul Aurich <darkrain42@pidgin.im>
parents: 27282
diff changeset
276 /* jabber_roster_update frees the GSList* passed in */
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
277 static void jabber_roster_update(JabberStream *js, const char *name,
27283
9a69f682a3ca Operate on the passed-in GSList.
Paul Aurich <darkrain42@pidgin.im>
parents: 27282
diff changeset
278 GSList *groups)
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
279 {
15884
4de1981757fc sed -ie 's/gaim/purple/g'
Sean Egan <seanegan@pidgin.im>
parents: 15847
diff changeset
280 PurpleBuddy *b;
4de1981757fc sed -ie 's/gaim/purple/g'
Sean Egan <seanegan@pidgin.im>
parents: 15847
diff changeset
281 PurpleGroup *g;
27283
9a69f682a3ca Operate on the passed-in GSList.
Paul Aurich <darkrain42@pidgin.im>
parents: 27282
diff changeset
282 GSList *l;
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
283 JabberIq *iq;
34935
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
284 PurpleXmlNode *query, *item, *group;
24950
143f594f0cd0 Alias foo. I think blist.h structs are now completely hidden.
Sadrul Habib Chowdhury <sadrul@pidgin.im>
parents: 24398
diff changeset
285 const char *balias;
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
286
23975
8ee397f04ca9 We talked about this and decided it was probably cleaner to not use
Mark Doliner <markdoliner@pidgin.im>
parents: 23961
diff changeset
287 if (js->currently_parsing_roster_push)
23961
0a9e9676f7b5 Hopefully fix the XMPP contact flipping/swapping between groups bug
Mark Doliner <markdoliner@pidgin.im>
parents: 23566
diff changeset
288 return;
0a9e9676f7b5 Hopefully fix the XMPP contact flipping/swapping between groups bug
Mark Doliner <markdoliner@pidgin.im>
parents: 23566
diff changeset
289
34728
8efd73063ecf Renamed buddy list functions to more appropriate/simler names.
Ankit Vani <a@nevitus.org>
parents: 34717
diff changeset
290 if(!(b = purple_blist_find_buddy(purple_connection_get_account(js->gc), name)))
20221
28e31ee832cd applied changes from e56db1b8a7bb8729e30fb3bf99a94ff7887fe4ec
Luke Schierer <lschiere@pidgin.im>
parents: 19859
diff changeset
291 return;
28e31ee832cd applied changes from e56db1b8a7bb8729e30fb3bf99a94ff7887fe4ec
Luke Schierer <lschiere@pidgin.im>
parents: 19859
diff changeset
292
27283
9a69f682a3ca Operate on the passed-in GSList.
Paul Aurich <darkrain42@pidgin.im>
parents: 27282
diff changeset
293 if (groups) {
27282
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
294 char *tmp = roster_groups_join(groups);
27230
17f893b060d7 Add a few more roster debug messages and improve.
Paul Aurich <darkrain42@pidgin.im>
parents: 27229
diff changeset
295
27283
9a69f682a3ca Operate on the passed-in GSList.
Paul Aurich <darkrain42@pidgin.im>
parents: 27282
diff changeset
296 purple_debug_info("jabber", "jabber_roster_update(%s): [Source: "
9a69f682a3ca Operate on the passed-in GSList.
Paul Aurich <darkrain42@pidgin.im>
parents: 27282
diff changeset
297 "groups]: groups: %s\n", name, tmp);
27282
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
298 g_free(tmp);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
299 } else {
34728
8efd73063ecf Renamed buddy list functions to more appropriate/simler names.
Ankit Vani <a@nevitus.org>
parents: 34717
diff changeset
300 GSList *buddies = purple_blist_find_buddies(purple_connection_get_account(js->gc), name);
27282
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
301 char *tmp;
27230
17f893b060d7 Add a few more roster debug messages and improve.
Paul Aurich <darkrain42@pidgin.im>
parents: 27229
diff changeset
302
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
303 if(!buddies)
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
304 return;
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
305 while(buddies) {
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
306 b = buddies->data;
15884
4de1981757fc sed -ie 's/gaim/purple/g'
Sean Egan <seanegan@pidgin.im>
parents: 15847
diff changeset
307 g = purple_buddy_get_group(b);
36009
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
308 groups = g_slist_append(groups,
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
309 (char *)jabber_roster_group_get_global_name(g));
40079
a37a1e349491 Replace g_[s]list_remove with g_[s]list_delete_link.
Elliott Sales de Andrade <qulogic@pidgin.im>
parents: 40052
diff changeset
310 buddies = g_slist_delete_link(buddies, buddies);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
311 }
27230
17f893b060d7 Add a few more roster debug messages and improve.
Paul Aurich <darkrain42@pidgin.im>
parents: 27229
diff changeset
312
27282
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
313 tmp = roster_groups_join(groups);
27230
17f893b060d7 Add a few more roster debug messages and improve.
Paul Aurich <darkrain42@pidgin.im>
parents: 27229
diff changeset
314 purple_debug_info("jabber", "jabber_roster_update(%s): [Source: local blist]: groups: %s\n",
27282
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
315 name, tmp);
791c6a965694 Debug output when changing group memberships.
Paul Aurich <darkrain42@pidgin.im>
parents: 27281
diff changeset
316 g_free(tmp);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
317 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
318
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
319 iq = jabber_iq_new_query(js, JABBER_IQ_SET, "jabber:iq:roster");
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
320
34935
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
321 query = purple_xmlnode_get_child(iq->node, "query");
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
322 item = purple_xmlnode_new_child(query, "item");
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
323
34935
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
324 purple_xmlnode_set_attrib(item, "jid", name);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
325
34717
b3e588adef5a Global replace purple_buddy_get_local_buddy_alias() with purple_buddy_get_local_alias()
Ankit Vani <a@nevitus.org>
parents: 34699
diff changeset
326 balias = purple_buddy_get_local_alias(b);
34935
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
327 purple_xmlnode_set_attrib(item, "name", balias ? balias : "");
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
328
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
329 for(l = groups; l; l = l->next) {
34935
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
330 group = purple_xmlnode_new_child(item, "group");
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
331 purple_xmlnode_insert_data(group, l->data, -1);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
332 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
333
27283
9a69f682a3ca Operate on the passed-in GSList.
Paul Aurich <darkrain42@pidgin.im>
parents: 27282
diff changeset
334 g_slist_free(groups);
26042
4dabdb5fe213 Remove some extra trailing whitespace I noticed after merging mlundblad's
Elliott Sales de Andrade <qulogic@pidgin.im>
parents: 24983
diff changeset
335
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
336 jabber_iq_send(iq);
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
337 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
338
40708
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
339 void
41967
025eee9e6f1d Bump C standard to C99 for XMPP and fix warnings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41791
diff changeset
340 jabber_roster_add_buddy(G_GNUC_UNUSED PurpleProtocolServer *protocol_server,
40708
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
341 PurpleConnection *gc, PurpleBuddy *buddy,
41967
025eee9e6f1d Bump C standard to C99 for XMPP and fix warnings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41791
diff changeset
342 G_GNUC_UNUSED PurpleGroup *group,
025eee9e6f1d Bump C standard to C99 for XMPP and fix warnings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41791
diff changeset
343 G_GNUC_UNUSED const char *message)
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
344 {
32277
97f16af01a05 Convert jabber prpl to use accessor functions purple_connection_get_protocol_data() and purple_connection_set_protocol_data().
Andrew Victor <andrew.victor@mxit.com>
parents: 31794
diff changeset
345 JabberStream *js = purple_connection_get_protocol_data(gc);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
346 char *who;
28431
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
347 JabberID *jid;
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
348 JabberBuddy *jb;
7488
788b9d6f1510 [gaim-migrate @ 8101]
Nathan Walp <nwalp@pidgin.im>
parents: 7482
diff changeset
349 JabberBuddyResource *jbr;
24398
4865c2ee6ea8 Start hiding blist.h internals in prpls.
Sadrul Habib Chowdhury <sadrul@pidgin.im>
parents: 24199
diff changeset
350 const char *name;
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
351
27278
b34a1cea4872 Use js->state to track whether the roster has been retrieved.
Paul Aurich <darkrain42@pidgin.im>
parents: 27277
diff changeset
352 /* If we haven't received the roster yet, ignore any adds */
b34a1cea4872 Use js->state to track whether the roster has been retrieved.
Paul Aurich <darkrain42@pidgin.im>
parents: 27277
diff changeset
353 if (js->state != JABBER_STREAM_CONNECTED)
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
354 return;
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
355
24398
4865c2ee6ea8 Start hiding blist.h internals in prpls.
Sadrul Habib Chowdhury <sadrul@pidgin.im>
parents: 24199
diff changeset
356 name = purple_buddy_get_name(buddy);
28431
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
357 jid = jabber_id_new(name);
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
358 if (jid == NULL) {
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
359 /* TODO: Remove the buddy from the list? */
7425
ae71f8b98322 [gaim-migrate @ 8028]
Nathan Walp <nwalp@pidgin.im>
parents: 7316
diff changeset
360 return;
28431
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
361 }
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
362
34670
9bd5bd903dc7 Renamed chat buddies to chat users, and IM conversation typing state to IM typing state.
Ankit Vani <a@nevitus.org>
parents: 32678
diff changeset
363 /* Adding a chat room or a chat user to the roster is *not* supported. */
28584
1226297d1ba9 jabber: Don't crash when adding a buddy without a node (no '@'). Closes #10261.
Paul Aurich <darkrain42@pidgin.im>
parents: 28431
diff changeset
364 if (jid->node && jabber_chat_find(js, jid->node, jid->domain) != NULL) {
28431
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
365 /*
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
366 * This is the same thing Bonjour does. If it causes problems, move
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
367 * it to an idle callback.
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
368 */
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
369 purple_debug_warning("jabber", "Cowardly refusing to add a MUC user "
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
370 "to your buddy list and removing the buddy. "
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
371 "Buddies can only be added by real (non-MUC) "
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
372 "JID\n");
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
373 purple_blist_remove_buddy(buddy);
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
374 jabber_id_free(jid);
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
375 return;
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
376 }
7425
ae71f8b98322 [gaim-migrate @ 8028]
Nathan Walp <nwalp@pidgin.im>
parents: 7316
diff changeset
377
28431
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
378 who = jabber_id_get_bare_jid(jid);
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
379 if (jid->resource != NULL) {
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
380 /*
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
381 * If the buddy name added contains a resource, strip that off and
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
382 * rename the buddy.
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
383 */
34728
8efd73063ecf Renamed buddy list functions to more appropriate/simler names.
Ankit Vani <a@nevitus.org>
parents: 34717
diff changeset
384 purple_buddy_set_name(buddy, who);
28431
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
385 }
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
386
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
387 jb = jabber_buddy_find(js, who, FALSE);
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
388
8450418b5abd jabber: Properly handle adding buddies that contain a resource. Closes #10151.
Paul Aurich <darkrain42@pidgin.im>
parents: 28322
diff changeset
389 purple_debug_info("jabber", "jabber_roster_add_buddy(): Adding %s\n", who);
27230
17f893b060d7 Add a few more roster debug messages and improve.
Paul Aurich <darkrain42@pidgin.im>
parents: 27229
diff changeset
390
23566
fabe91dee1e1 Alright, I'm getting rid of this "groups" thing for the reason listed
Mark Doliner <markdoliner@pidgin.im>
parents: 22993
diff changeset
391 jabber_roster_update(js, who, NULL);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
392
28071
a0706162fefd jabber: Store the "own JabberBuddy" in the JabberStream* struct.
Paul Aurich <darkrain42@pidgin.im>
parents: 27743
diff changeset
393 if (jb == js->user_jb) {
27280
55a39efcf7b8 Simplify the fake_to_self function.
Paul Aurich <darkrain42@pidgin.im>
parents: 27278
diff changeset
394 jabber_presence_fake_to_self(js, NULL);
9954
52a14a58a33e [gaim-migrate @ 10851]
Nathan Walp <nwalp@pidgin.im>
parents: 9927
diff changeset
395 } else if(!jb || !(jb->subscription & JABBER_SUB_TO)) {
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
396 jabber_presence_subscription_set(js, who, "subscribe");
9954
52a14a58a33e [gaim-migrate @ 10851]
Nathan Walp <nwalp@pidgin.im>
parents: 9927
diff changeset
397 } else if((jbr =jabber_buddy_find_resource(jb, NULL))) {
36545
23b59a16c808 Replaced some _prpl_ stuff with _protocol_
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
398 purple_protocol_got_user_status(purple_connection_get_account(gc), who,
9954
52a14a58a33e [gaim-migrate @ 10851]
Nathan Walp <nwalp@pidgin.im>
parents: 9927
diff changeset
399 jabber_buddy_state_get_status_id(jbr->state),
9990
37b4db8472e6 [gaim-migrate @ 10903]
Nathan Walp <nwalp@pidgin.im>
parents: 9954
diff changeset
400 "priority", jbr->priority, jbr->status ? "message" : NULL, jbr->status, NULL);
9954
52a14a58a33e [gaim-migrate @ 10851]
Nathan Walp <nwalp@pidgin.im>
parents: 9927
diff changeset
401 }
7425
ae71f8b98322 [gaim-migrate @ 8028]
Nathan Walp <nwalp@pidgin.im>
parents: 7316
diff changeset
402
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
403 g_free(who);
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
404 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
405
40708
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
406 void
41967
025eee9e6f1d Bump C standard to C99 for XMPP and fix warnings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41791
diff changeset
407 jabber_roster_alias_change(G_GNUC_UNUSED PurpleProtocolServer *protocol_server,
40708
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
408 PurpleConnection *gc, const gchar *name,
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
409 const gchar *alias)
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
410 {
34728
8efd73063ecf Renamed buddy list functions to more appropriate/simler names.
Ankit Vani <a@nevitus.org>
parents: 34717
diff changeset
411 PurpleBuddy *b = purple_blist_find_buddy(purple_connection_get_account(gc), name);
7449
caa227328a0d [gaim-migrate @ 8060]
Nathan Walp <nwalp@pidgin.im>
parents: 7445
diff changeset
412
15321
5ca8c8b913b1 [gaim-migrate @ 18049]
Nathan Walp <nwalp@pidgin.im>
parents: 15265
diff changeset
413 if(b != NULL) {
34728
8efd73063ecf Renamed buddy list functions to more appropriate/simler names.
Ankit Vani <a@nevitus.org>
parents: 34717
diff changeset
414 purple_buddy_set_local_alias(b, alias);
7449
caa227328a0d [gaim-migrate @ 8060]
Nathan Walp <nwalp@pidgin.im>
parents: 7445
diff changeset
415
27230
17f893b060d7 Add a few more roster debug messages and improve.
Paul Aurich <darkrain42@pidgin.im>
parents: 27229
diff changeset
416 purple_debug_info("jabber", "jabber_roster_alias_change(): Aliased %s to %s\n",
27242
05618d46ac91 Ladedah I dislike the need to explicitly check for NULL strings.
Paul Aurich <darkrain42@pidgin.im>
parents: 27230
diff changeset
417 name, alias ? alias : "(null)");
27229
3a0922120d87 Pluck Adium's roster debugging from 86720de21a854aa
Paul Aurich <darkrain42@pidgin.im>
parents: 26707
diff changeset
418
32277
97f16af01a05 Convert jabber prpl to use accessor functions purple_connection_get_protocol_data() and purple_connection_set_protocol_data().
Andrew Victor <andrew.victor@mxit.com>
parents: 31794
diff changeset
419 jabber_roster_update(purple_connection_get_protocol_data(gc), name, NULL);
15321
5ca8c8b913b1 [gaim-migrate @ 18049]
Nathan Walp <nwalp@pidgin.im>
parents: 15265
diff changeset
420 }
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
421 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
422
40708
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
423 void
41967
025eee9e6f1d Bump C standard to C99 for XMPP and fix warnings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41791
diff changeset
424 jabber_roster_group_change(G_GNUC_UNUSED PurpleProtocolServer *protocol_server,
40708
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
425 PurpleConnection *gc, const gchar *name,
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
426 const gchar *old_group, const gchar *new_group)
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
427 {
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
428 GSList *buddies, *groups = NULL;
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
429
38258
9a6551eba09c Replace !strcmp() with purple_strequal()
qarkai <qarkai@gmail.com>
parents: 38257
diff changeset
430 if(!old_group || !new_group || purple_strequal(old_group, new_group))
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
431 return;
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
432
34728
8efd73063ecf Renamed buddy list functions to more appropriate/simler names.
Ankit Vani <a@nevitus.org>
parents: 34717
diff changeset
433 buddies = purple_blist_find_buddies(purple_connection_get_account(gc), name);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
434 while(buddies) {
36022
256604cbbe34 Make it possible to move buddies out of default group
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 36013
diff changeset
435 groups = g_slist_append(groups, (char*)new_group);
40079
a37a1e349491 Replace g_[s]list_remove with g_[s]list_delete_link.
Elliott Sales de Andrade <qulogic@pidgin.im>
parents: 40052
diff changeset
436 buddies = g_slist_delete_link(buddies, buddies);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
437 }
27229
3a0922120d87 Pluck Adium's roster debugging from 86720de21a854aa
Paul Aurich <darkrain42@pidgin.im>
parents: 26707
diff changeset
438
27230
17f893b060d7 Add a few more roster debug messages and improve.
Paul Aurich <darkrain42@pidgin.im>
parents: 27229
diff changeset
439 purple_debug_info("jabber", "jabber_roster_group_change(): Moving %s from %s to %s\n",
17f893b060d7 Add a few more roster debug messages and improve.
Paul Aurich <darkrain42@pidgin.im>
parents: 27229
diff changeset
440 name, old_group, new_group);
27229
3a0922120d87 Pluck Adium's roster debugging from 86720de21a854aa
Paul Aurich <darkrain42@pidgin.im>
parents: 26707
diff changeset
441
32277
97f16af01a05 Convert jabber prpl to use accessor functions purple_connection_get_protocol_data() and purple_connection_set_protocol_data().
Andrew Victor <andrew.victor@mxit.com>
parents: 31794
diff changeset
442 jabber_roster_update(purple_connection_get_protocol_data(gc), name, groups);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
443 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
444
40708
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
445 void
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
446 jabber_roster_group_rename(PurpleProtocolServer *protocol_server,
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
447 PurpleConnection *gc, const gchar *old_name,
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
448 PurpleGroup *group, GList *moved_buddies)
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
449 {
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
450 GList *l;
36009
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
451 const char *gname = jabber_roster_group_get_global_name(group);
40708
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
452
9285
9cedf5d26577 [gaim-migrate @ 10088]
Mark Doliner <markdoliner@pidgin.im>
parents: 8347
diff changeset
453 for(l = moved_buddies; l; l = l->next) {
15884
4de1981757fc sed -ie 's/gaim/purple/g'
Sean Egan <seanegan@pidgin.im>
parents: 15847
diff changeset
454 PurpleBuddy *buddy = l->data;
40708
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
455
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
456 jabber_roster_group_change(protocol_server, gc,
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
457 purple_buddy_get_name(buddy), old_name,
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
458 gname);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
459 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
460 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
461
40708
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
462 void
41967
025eee9e6f1d Bump C standard to C99 for XMPP and fix warnings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41791
diff changeset
463 jabber_roster_remove_buddy(G_GNUC_UNUSED PurpleProtocolServer *protocol_server,
40708
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
464 PurpleConnection *gc, PurpleBuddy *buddy,
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
465 PurpleGroup *group)
53a26c29d26c Move the PurpleProtocolServer interface to its own file.
Gary Kramlich <grim@reaperworld.com>
parents: 40474
diff changeset
466 {
24398
4865c2ee6ea8 Start hiding blist.h internals in prpls.
Sadrul Habib Chowdhury <sadrul@pidgin.im>
parents: 24199
diff changeset
467 const char *name = purple_buddy_get_name(buddy);
34728
8efd73063ecf Renamed buddy list functions to more appropriate/simler names.
Ankit Vani <a@nevitus.org>
parents: 34717
diff changeset
468 GSList *buddies = purple_blist_find_buddies(purple_connection_get_account(gc), name);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
469
9285
9cedf5d26577 [gaim-migrate @ 10088]
Mark Doliner <markdoliner@pidgin.im>
parents: 8347
diff changeset
470 buddies = g_slist_remove(buddies, buddy);
15847
da522f9a7743 Don't use g_list_length() and g_slist_length() when all you want to
Mark Doliner <markdoliner@pidgin.im>
parents: 15695
diff changeset
471 if(buddies != NULL) {
15884
4de1981757fc sed -ie 's/gaim/purple/g'
Sean Egan <seanegan@pidgin.im>
parents: 15847
diff changeset
472 PurpleBuddy *tmpbuddy;
4de1981757fc sed -ie 's/gaim/purple/g'
Sean Egan <seanegan@pidgin.im>
parents: 15847
diff changeset
473 PurpleGroup *tmpgroup;
20225
684334efdc19 applied changes from d4b316d73ebaf93803ca2642e78b8821c3b5d5c7
Luke Schierer <lschiere@pidgin.im>
parents: 20221
diff changeset
474 GSList *groups = NULL;
9285
9cedf5d26577 [gaim-migrate @ 10088]
Mark Doliner <markdoliner@pidgin.im>
parents: 8347
diff changeset
475
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
476 while(buddies) {
9285
9cedf5d26577 [gaim-migrate @ 10088]
Mark Doliner <markdoliner@pidgin.im>
parents: 8347
diff changeset
477 tmpbuddy = buddies->data;
15884
4de1981757fc sed -ie 's/gaim/purple/g'
Sean Egan <seanegan@pidgin.im>
parents: 15847
diff changeset
478 tmpgroup = purple_buddy_get_group(tmpbuddy);
36009
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
479 groups = g_slist_append(groups,
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
480 (char *)jabber_roster_group_get_global_name(tmpgroup));
40079
a37a1e349491 Replace g_[s]list_remove with g_[s]list_delete_link.
Elliott Sales de Andrade <qulogic@pidgin.im>
parents: 40052
diff changeset
481 buddies = g_slist_delete_link(buddies, buddies);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
482 }
9285
9cedf5d26577 [gaim-migrate @ 10088]
Mark Doliner <markdoliner@pidgin.im>
parents: 8347
diff changeset
483
36009
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
484 purple_debug_info("jabber", "jabber_roster_remove_buddy(): "
35960
407e0fa6f7d1 blist: don't localize roster group name to avoid contact splitting
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 35958
diff changeset
485 "Removing %s from %s", purple_buddy_get_name(buddy),
36009
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
486 jabber_roster_group_get_global_name(group));
27229
3a0922120d87 Pluck Adium's roster debugging from 86720de21a854aa
Paul Aurich <darkrain42@pidgin.im>
parents: 26707
diff changeset
487
32277
97f16af01a05 Convert jabber prpl to use accessor functions purple_connection_get_protocol_data() and purple_connection_set_protocol_data().
Andrew Victor <andrew.victor@mxit.com>
parents: 31794
diff changeset
488 jabber_roster_update(purple_connection_get_protocol_data(gc), name, groups);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
489 } else {
32277
97f16af01a05 Convert jabber prpl to use accessor functions purple_connection_get_protocol_data() and purple_connection_set_protocol_data().
Andrew Victor <andrew.victor@mxit.com>
parents: 31794
diff changeset
490 JabberIq *iq = jabber_iq_new_query(purple_connection_get_protocol_data(gc), JABBER_IQ_SET,
7171
907ae6bd8b40 [gaim-migrate @ 7738]
Nathan Walp <nwalp@pidgin.im>
parents: 7014
diff changeset
491 "jabber:iq:roster");
34935
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
492 PurpleXmlNode *query = purple_xmlnode_get_child(iq->node, "query");
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
493 PurpleXmlNode *item = purple_xmlnode_new_child(query, "item");
7171
907ae6bd8b40 [gaim-migrate @ 7738]
Nathan Walp <nwalp@pidgin.im>
parents: 7014
diff changeset
494
34935
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
495 purple_xmlnode_set_attrib(item, "jid", name);
686fa55b0deb Replaced xmlnode with PurpleXmlNode, and xmlnode_* API with purple_xmlnode_* API
Ankit Vani <a@nevitus.org>
parents: 34864
diff changeset
496 purple_xmlnode_set_attrib(item, "subscription", "remove");
7171
907ae6bd8b40 [gaim-migrate @ 7738]
Nathan Walp <nwalp@pidgin.im>
parents: 7014
diff changeset
497
27230
17f893b060d7 Add a few more roster debug messages and improve.
Paul Aurich <darkrain42@pidgin.im>
parents: 27229
diff changeset
498 purple_debug_info("jabber", "jabber_roster_remove_buddy(): Removing %s\n",
17f893b060d7 Add a few more roster debug messages and improve.
Paul Aurich <darkrain42@pidgin.im>
parents: 27229
diff changeset
499 purple_buddy_get_name(buddy));
17f893b060d7 Add a few more roster debug messages and improve.
Paul Aurich <darkrain42@pidgin.im>
parents: 27229
diff changeset
500
7171
907ae6bd8b40 [gaim-migrate @ 7738]
Nathan Walp <nwalp@pidgin.im>
parents: 7014
diff changeset
501 jabber_iq_send(iq);
7014
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
502 }
11471fae7ba0 [gaim-migrate @ 7577]
Nathan Walp <nwalp@pidgin.im>
parents:
diff changeset
503 }
36009
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
504
41791
3bf884522663 xmpp: Remove unused prototypes and code
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 40726
diff changeset
505 static const gchar *
36009
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
506 jabber_roster_group_get_global_name(PurpleGroup *group)
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
507 {
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
508 const gchar *name = NULL;
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
509
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
510 if (group)
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
511 name = purple_group_get_name(group);
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
512
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
513 if (name == NULL)
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
514 name = JABBER_ROSTER_DEFAULT_GROUP;
38358
30ba44276e74 Merge release-2.x.y into default
dx <dx@dxzone.com.ar>
parents: 38240 38258
diff changeset
515 else if (purple_strequal(name, PURPLE_BLIST_DEFAULT_GROUP_NAME))
36009
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
516 name = JABBER_ROSTER_DEFAULT_GROUP;
38358
30ba44276e74 Merge release-2.x.y into default
dx <dx@dxzone.com.ar>
parents: 38240 38258
diff changeset
517 else if (purple_strequal(name, _purple_blist_get_localized_default_group_name()))
35961
87fd9126902a blist: store localized name of default group to avoid contact splitting
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 35960
diff changeset
518 name = JABBER_ROSTER_DEFAULT_GROUP;
36009
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
519
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
520 return name;
4db2936dd842 Backport 407e0fa6f7d1: don't split contacts on default group (xmpp)
Tomasz Wasilczyk <twasilczyk@pidgin.im>
parents: 31794
diff changeset
521 }

mercurial