Mon, 21 Aug 2006 22:50:58 +0000
[gaim-migrate @ 16963]
Fix a crazy bug that we found at meebo. I'm not sure it
affects gtk Gaim in quite the same way, but what was
happeing is that the conversation sequence number should
be incremented by 1 each time a new conversation is
created (whether created by someone else or created by
you). However, in one place in Gaim conv_seq was being
incremented BEFORE it was used and in another it was
being incremented AFTER it was used. This can lead to
a sequence number being used twice.
| 8810 | 1 | /** |
| 2 | * @file history.c MSN history functions | |
| 3 | * | |
| 4 | * gaim | |
| 5 | * | |
|
9198
e8eb6d5eb9eb
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
8810
diff
changeset
|
6 | * Gaim is the legal property of its developers, whose names are too numerous |
|
e8eb6d5eb9eb
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
8810
diff
changeset
|
7 | * to list here. Please refer to the COPYRIGHT file distributed with this |
|
e8eb6d5eb9eb
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
8810
diff
changeset
|
8 | * source distribution. |
| 8810 | 9 | * |
| 10 | * This program is free software; you can redistribute it and/or modify | |
| 11 | * it under the terms of the GNU General Public License as published by | |
| 12 | * the Free Software Foundation; either version 2 of the License, or | |
| 13 | * (at your option) any later version. | |
| 14 | * | |
| 15 | * This program is distributed in the hope that it will be useful, | |
| 16 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 17 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
| 18 | * GNU General Public License for more details. | |
| 19 | * | |
| 20 | * You should have received a copy of the GNU General Public License | |
| 21 | * along with this program; if not, write to the Free Software | |
| 22 | * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | |
| 23 | */ | |
| 24 | #include "msn.h" | |
| 25 | #include "history.h" | |
| 26 | ||
| 27 | MsnHistory * | |
| 28 | msn_history_new(void) | |
| 29 | { | |
| 30 | MsnHistory *history = g_new0(MsnHistory, 1); | |
|
9198
e8eb6d5eb9eb
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
8810
diff
changeset
|
31 | |
| 8810 | 32 | history->trId = 1; |
|
9198
e8eb6d5eb9eb
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
8810
diff
changeset
|
33 | |
| 8810 | 34 | history->queue = g_queue_new(); |
| 35 | ||
| 36 | return history; | |
| 37 | } | |
| 38 | ||
| 39 | void | |
| 40 | msn_history_destroy(MsnHistory *history) | |
| 41 | { | |
| 42 | MsnTransaction *trans; | |
| 43 | ||
| 44 | while ((trans = g_queue_pop_head(history->queue)) != NULL) | |
| 45 | msn_transaction_destroy(trans); | |
| 46 | ||
| 47 | g_queue_free(history->queue); | |
| 48 | g_free(history); | |
| 49 | } | |
| 50 | ||
| 51 | MsnTransaction * | |
| 52 | msn_history_find(MsnHistory *history, unsigned int trId) | |
| 53 | { | |
| 54 | MsnTransaction *trans; | |
| 55 | GList *list; | |
| 56 | ||
| 57 | for (list = history->queue->head; list != NULL; list = list->next) | |
| 58 | { | |
| 59 | trans = list->data; | |
| 60 | if (trans->trId == trId) | |
| 61 | return trans; | |
| 62 | } | |
| 63 | ||
| 64 | return NULL; | |
| 65 | } | |
| 66 | ||
| 67 | void | |
| 68 | msn_history_add(MsnHistory *history, MsnTransaction *trans) | |
| 69 | { | |
|
10296
9badf1cedc6e
[gaim-migrate @ 11476]
Felipe Contreras <felipe.contreras@gmail.com>
parents:
9198
diff
changeset
|
70 | GQueue *queue; |
|
9badf1cedc6e
[gaim-migrate @ 11476]
Felipe Contreras <felipe.contreras@gmail.com>
parents:
9198
diff
changeset
|
71 | |
|
9badf1cedc6e
[gaim-migrate @ 11476]
Felipe Contreras <felipe.contreras@gmail.com>
parents:
9198
diff
changeset
|
72 | g_return_if_fail(history != NULL); |
|
9badf1cedc6e
[gaim-migrate @ 11476]
Felipe Contreras <felipe.contreras@gmail.com>
parents:
9198
diff
changeset
|
73 | g_return_if_fail(trans != NULL); |
|
9badf1cedc6e
[gaim-migrate @ 11476]
Felipe Contreras <felipe.contreras@gmail.com>
parents:
9198
diff
changeset
|
74 | |
|
9badf1cedc6e
[gaim-migrate @ 11476]
Felipe Contreras <felipe.contreras@gmail.com>
parents:
9198
diff
changeset
|
75 | queue = history->queue; |
| 8810 | 76 | |
| 77 | trans->trId = history->trId++; | |
|
9198
e8eb6d5eb9eb
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
8810
diff
changeset
|
78 | |
| 8810 | 79 | g_queue_push_tail(queue, trans); |
|
9198
e8eb6d5eb9eb
[gaim-migrate @ 9993]
Christian Hammond <chipx86@chipx86.com>
parents:
8810
diff
changeset
|
80 | |
| 8810 | 81 | if (queue->length > MSN_HIST_ELEMS) |
| 82 | { | |
| 83 | trans = g_queue_pop_head(queue); | |
| 84 | msn_transaction_destroy(trans); | |
| 85 | } | |
| 86 | } |