Thu, 24 Apr 2025 22:19:39 -0500
IRCv3: check if a member is in a conversation before adding them
Awhile ago we update the NAMREPLY handler to build a separate
Purple.ConversationMembers and then splice that onto the existing one to help
with sorting and other performance issues. However, we didn't check if the
users already existed in the existing list, so we would get duplicates. This
address that.
Also fixed a reference leak.
Testing Done:
Joined a channel and sent `/quote names #channel` multiple times and verified that the member list did not grow to include a bunch of duplicates.
Reviewed at https://reviews.imfreedom.org/r/3987/
|
42937
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
1 | /* |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
2 | * Purple - Internet Messaging Library |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
3 | * Copyright (C) Pidgin Developers <devel@pidgin.im> |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
4 | * |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
5 | * Purple is the legal property of its developers, whose names are too numerous |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
6 | * to list here. Please refer to the COPYRIGHT file distributed with this |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
7 | * source distribution. |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
8 | * |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
9 | * This library is free software; you can redistribute it and/or modify |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
10 | * it under the terms of the GNU General Public License as published by |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
11 | * the Free Software Foundation; either version 2 of the License, or |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
12 | * (at your option) any later version. |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
13 | * |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
14 | * This library is distributed in the hope that it will be useful, |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
15 | * but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
16 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
17 | * GNU General Public License for more details. |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
18 | * |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
19 | * You should have received a copy of the GNU General Public License |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
20 | * along with this library; if not, see <https://www.gnu.org/licenses/>. |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
21 | */ |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
22 | |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
23 | #if !defined(PURPLE_IRCV3_GLOBAL_HEADER_INSIDE) && \ |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
24 | !defined(PURPLE_IRCV3_COMPILATION) |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
25 | # error "only <libpurple/protocols/ircv3.h> may be included directly" |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
26 | #endif |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
27 | |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
28 | #ifndef PURPLE_IRCV3_CTCP_HANDLERS_H |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
29 | #define PURPLE_IRCV3_CTCP_HANDLERS_H |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
30 | |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
31 | #include <glib.h> |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
32 | |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
33 | #include <ibis.h> |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
34 | |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
35 | #include <purple.h> |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
36 | |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
37 | #include "purpleircv3connection.h" |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
38 | |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
39 | G_BEGIN_DECLS |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
40 | |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
41 | G_GNUC_INTERNAL void purple_ircv3_ctcp_handler(PurpleIRCv3Connection *connection, IbisClient *client, IbisMessage *message); |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
42 | |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
43 | G_END_DECLS |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
44 | |
|
34ac8ac8c7b6
Implement CTCP VERSION response
Gary Kramlich <grim@reaperworld.com>
parents:
diff
changeset
|
45 | #endif /* PURPLE_IRCV3_CTCP_HANDLERS_H */ |