Thu, 07 Apr 2005 14:55:02 +0000
[gaim-migrate @ 12431]
" The following log snippets should explain it: " --rlaager
(20:24:00) rlaager: Regarding the signal handling
conversation the other day... I've written a patch to stop
calling signal handlers and return as soon as we find one
signal handler that returns TRUE to indicate that it's
handled the signal. Is this the right approach?
(20:24:22) Ethan Blanton (Paco-Paco): the trouble is that it's
documented to behave exactly the way it does
(20:24:31) Ethan Blanton (Paco-Paco): so changing it is
notbackwards compatible
(20:24:31) rlaager: I'm talking for HEAD.
(20:24:41) Ethan Blanton (Paco-Paco): oh, I think that's a
good approach, yes
(20:24:53) rlaager: The way I've described is how I
*expected* it to work, having not read the documentation.
(20:25:09) Ethan Blanton (Paco-Paco): I'm convinced
(20:27:04) Stu Tomlinson (nosnilmot): rlaager: this, I
assume, breaks the generic-ness of signals, by assuming
that any that return values return booleans?
(20:27:26) Ethan Blanton (Paco-Paco): please break it
(20:27:33) Ethan Blanton (Paco-Paco): we already have
out-parameters
(20:27:42) rlaager: nosnilmot: from what I can see, the
return type is handled as a (void *)... so I'm checking that
ret_value != NULL
(20:27:57) rlaager: nosnilmot: that's the correct way to do it,
right?
...
(20:29:01) Ethan Blanton (Paco-Paco): allowing a
meaningful return value is an over-engineering
(20:30:07) rlaager: even after this patch, you should be able
to return meaningful return values
(20:30:15) rlaager: it'll just short-circuit on the first handler
that does
committer: Luke Schierer <lschiere@pidgin.im>
| 9359 | 1 | # |
| 2 | # Makefile.mingw | |
| 3 | # | |
|
10201
6fd2263c79cc
[gaim-migrate @ 11319]
Herman Bloggs <herman@bluedigits.com>
parents:
9570
diff
changeset
|
4 | # Description: Makefile for win32 (mingw) version of libsilc protocol plugin |
| 9359 | 5 | # |
| 6 | ||
| 7 | # | |
| 8 | # PATHS | |
| 9 | # | |
| 10 | ||
| 11 | INCLUDE_DIR := . | |
| 12 | GTK_TOP := ../../../../win32-dev/gtk_2_0 | |
| 13 | GAIM_TOP := ../../.. | |
|
10201
6fd2263c79cc
[gaim-migrate @ 11319]
Herman Bloggs <herman@bluedigits.com>
parents:
9570
diff
changeset
|
14 | SILC_TOP := . |
| 9359 | 15 | GAIM_INSTALL_DIR := $(GAIM_TOP)/win32-install-dir |
|
10201
6fd2263c79cc
[gaim-migrate @ 11319]
Herman Bloggs <herman@bluedigits.com>
parents:
9570
diff
changeset
|
16 | SILC_TOOLKIT := ../../../../win32-dev/silc-toolkit-0.9.12 |
| 9359 | 17 | |
| 18 | ## | |
| 19 | ## VARIABLE DEFINITIONS | |
| 20 | ## | |
| 21 | ||
|
10201
6fd2263c79cc
[gaim-migrate @ 11319]
Herman Bloggs <herman@bluedigits.com>
parents:
9570
diff
changeset
|
22 | TARGET = libsilc |
| 9359 | 23 | |
|
10201
6fd2263c79cc
[gaim-migrate @ 11319]
Herman Bloggs <herman@bluedigits.com>
parents:
9570
diff
changeset
|
24 | NEEDED_DLLS = $(SILC_TOOLKIT)/lib/silc.dll \ |
|
6fd2263c79cc
[gaim-migrate @ 11319]
Herman Bloggs <herman@bluedigits.com>
parents:
9570
diff
changeset
|
25 | $(SILC_TOOLKIT)/lib/silcclient.dll |
| 9359 | 26 | |
| 27 | # Compiler Options | |
| 28 | ||
| 29 | CFLAGS = | |
| 30 | ||
| 31 | DEFINES = | |
| 32 | ||
| 33 | # Static or Plugin... | |
| 34 | ifeq ($(TYPE),STATIC) | |
| 35 | DEFINES += -DSTATIC | |
| 36 | DLL_INSTALL_DIR = $(GAIM_INSTALL_DIR) | |
| 37 | else | |
| 38 | ifeq ($(TYPE),PLUGIN) | |
| 39 | DLL_INSTALL_DIR = $(GAIM_INSTALL_DIR)/plugins | |
| 40 | endif | |
| 41 | endif | |
| 42 | ||
| 43 | ||
| 44 | ## | |
| 45 | ## INCLUDE MAKEFILES | |
| 46 | ## | |
| 47 | ||
| 48 | include $(GAIM_TOP)/src/win32/global.mak | |
| 49 | ||
| 50 | ## | |
| 51 | ## INCLUDE PATHS | |
| 52 | ## | |
| 53 | ||
|
10201
6fd2263c79cc
[gaim-migrate @ 11319]
Herman Bloggs <herman@bluedigits.com>
parents:
9570
diff
changeset
|
54 | INCLUDE_PATHS += -I$(SILC_TOP) \ |
| 9359 | 55 | -I$(GTK_TOP)/include \ |
| 56 | -I$(GTK_TOP)/include/gtk-2.0 \ | |
| 57 | -I$(GTK_TOP)/include/glib-2.0 \ | |
| 58 | -I$(GTK_TOP)/include/pango-1.0 \ | |
| 59 | -I$(GTK_TOP)/include/atk-1.0 \ | |
| 60 | -I$(GTK_TOP)/lib/glib-2.0/include \ | |
| 61 | -I$(GTK_TOP)/lib/gtk-2.0/include \ | |
| 62 | -I$(GAIM_TOP)/src \ | |
| 63 | -I$(GAIM_TOP)/src/win32 \ | |
| 64 | -I$(GAIM_TOP) \ | |
|
10201
6fd2263c79cc
[gaim-migrate @ 11319]
Herman Bloggs <herman@bluedigits.com>
parents:
9570
diff
changeset
|
65 | -I$(SILC_TOOLKIT)/include |
| 9359 | 66 | |
| 67 | ||
|
9570
8b3f38824cd3
[gaim-migrate @ 10413]
Herman Bloggs <herman@bluedigits.com>
parents:
9359
diff
changeset
|
68 | LIB_PATHS = -L$(GTK_TOP)/lib \ |
| 9359 | 69 | -L$(GAIM_TOP)/src \ |
|
10201
6fd2263c79cc
[gaim-migrate @ 11319]
Herman Bloggs <herman@bluedigits.com>
parents:
9570
diff
changeset
|
70 | -L$(SILC_TOOLKIT)/lib |
| 9359 | 71 | |
| 72 | ||
| 73 | ## | |
| 74 | ## SOURCES, OBJECTS | |
| 75 | ## | |
| 76 | ||
|
9570
8b3f38824cd3
[gaim-migrate @ 10413]
Herman Bloggs <herman@bluedigits.com>
parents:
9359
diff
changeset
|
77 | C_SRC = silc.c \ |
| 9359 | 78 | buddy.c \ |
| 79 | chat.c \ | |
| 80 | ft.c \ | |
| 81 | ops.c \ | |
| 82 | pk.c \ | |
| 83 | util.c | |
| 84 | ||
| 85 | ||
| 86 | OBJECTS = $(C_SRC:%.c=%.o) | |
| 87 | ||
| 88 | ||
| 89 | ## | |
| 90 | ## LIBRARIES | |
| 91 | ## | |
| 92 | ||
|
9570
8b3f38824cd3
[gaim-migrate @ 10413]
Herman Bloggs <herman@bluedigits.com>
parents:
9359
diff
changeset
|
93 | LIBS = -lgtk-win32-2.0 \ |
| 9359 | 94 | -lglib-2.0 \ |
| 95 | -lgdk-win32-2.0 \ | |
| 96 | -lgmodule-2.0 \ | |
| 97 | -lgobject-2.0 \ | |
| 98 | -lws2_32 \ | |
| 99 | -lintl \ | |
| 100 | -lgaim \ | |
|
10201
6fd2263c79cc
[gaim-migrate @ 11319]
Herman Bloggs <herman@bluedigits.com>
parents:
9570
diff
changeset
|
101 | -lsilc \ |
|
6fd2263c79cc
[gaim-migrate @ 11319]
Herman Bloggs <herman@bluedigits.com>
parents:
9570
diff
changeset
|
102 | -lsilcclient |
| 9359 | 103 | |
| 104 | ||
| 105 | ## | |
| 106 | ## RULES | |
| 107 | ## | |
| 108 | ||
| 109 | # How to make a C file | |
| 110 | ||
| 111 | %.o: %.c | |
| 112 | $(CC) $(CFLAGS) $(DEFINES) $(INCLUDE_PATHS) -o $@ -c $< | |
| 113 | ||
| 114 | ## | |
| 115 | ## TARGET DEFINITIONS | |
| 116 | ## | |
| 117 | ||
| 118 | .PHONY: all clean | |
| 119 | ||
| 120 | all: $(TARGET).dll | |
| 121 | ||
| 122 | install: | |
|
10201
6fd2263c79cc
[gaim-migrate @ 11319]
Herman Bloggs <herman@bluedigits.com>
parents:
9570
diff
changeset
|
123 | cp $(SILC_TOP)/$(TARGET).dll $(DLL_INSTALL_DIR) |
| 9359 | 124 | cp $(NEEDED_DLLS) $(GAIM_INSTALL_DIR) |
| 125 | ||
| 126 | ||
| 127 | ## | |
| 128 | ## BUILD Dependencies | |
| 129 | ## | |
| 130 | ||
| 131 | $(GAIM_TOP)/src/gaim.lib: | |
| 132 | $(MAKE) -C $(GAIM_TOP)/src -f Makefile.mingw gaim.lib | |
| 133 | ||
| 134 | ## | |
| 135 | ## BUILD DLL | |
| 136 | ## | |
| 137 | ||
| 138 | $(TARGET).dll: $(OBJECTS) $(GAIM_TOP)/src/gaim.lib | |
|
9570
8b3f38824cd3
[gaim-migrate @ 10413]
Herman Bloggs <herman@bluedigits.com>
parents:
9359
diff
changeset
|
139 | $(CC) -shared $(OBJECTS) $(LIB_PATHS) $(LIBS) $(DLL_LD_FLAGS) -Wl,--image-base,0x64000000 -o $(TARGET).dll |
| 9359 | 140 | |
| 141 | ## | |
| 142 | ## CLEAN RULES | |
| 143 | ## | |
| 144 | ||
| 145 | clean: | |
| 146 | rm -rf *.o | |
| 147 | rm -rf $(TARGET).dll | |
| 148 | rm -rf $(TARGET).lib |