Thu, 07 Apr 2005 14:55:02 +0000
[gaim-migrate @ 12431]
" The following log snippets should explain it: " --rlaager
(20:24:00) rlaager: Regarding the signal handling
conversation the other day... I've written a patch to stop
calling signal handlers and return as soon as we find one
signal handler that returns TRUE to indicate that it's
handled the signal. Is this the right approach?
(20:24:22) Ethan Blanton (Paco-Paco): the trouble is that it's
documented to behave exactly the way it does
(20:24:31) Ethan Blanton (Paco-Paco): so changing it is
notbackwards compatible
(20:24:31) rlaager: I'm talking for HEAD.
(20:24:41) Ethan Blanton (Paco-Paco): oh, I think that's a
good approach, yes
(20:24:53) rlaager: The way I've described is how I
*expected* it to work, having not read the documentation.
(20:25:09) Ethan Blanton (Paco-Paco): I'm convinced
(20:27:04) Stu Tomlinson (nosnilmot): rlaager: this, I
assume, breaks the generic-ness of signals, by assuming
that any that return values return booleans?
(20:27:26) Ethan Blanton (Paco-Paco): please break it
(20:27:33) Ethan Blanton (Paco-Paco): we already have
out-parameters
(20:27:42) rlaager: nosnilmot: from what I can see, the
return type is handled as a (void *)... so I'm checking that
ret_value != NULL
(20:27:57) rlaager: nosnilmot: that's the correct way to do it,
right?
...
(20:29:01) Ethan Blanton (Paco-Paco): allowing a
meaningful return value is an over-engineering
(20:30:07) rlaager: even after this patch, you should be able
to return meaningful return values
(20:30:15) rlaager: it'll just short-circuit on the first handler
that does
committer: Luke Schierer <lschiere@pidgin.im>
| 2086 | 1 | /* This file is part of the Project Athena Zephyr Notification System. |
| 2 | * It contains source for the ZInitialize function. | |
| 3 | * | |
| 4 | * Created by: Robert French | |
| 5 | * | |
| 6 | * $Source$ | |
|
8792
b0645c9dc276
[gaim-migrate @ 9554]
Christian Hammond <chipx86@chipx86.com>
parents:
2419
diff
changeset
|
7 | * $Author: chipx86 $ |
| 2086 | 8 | * |
| 9 | * Copyright (c) 1987, 1991 by the Massachusetts Institute of Technology. | |
| 10 | * For copying and distribution information, see the file | |
| 11 | * "mit-copyright.h". | |
| 12 | */ | |
| 13 | /* $Header$ */ | |
| 14 | ||
| 15 | #ifndef lint | |
| 16 | static char rcsid_ZInitialize_c[] = | |
| 17 | "$Zephyr: /afs/athena.mit.edu/astaff/project/zephyr/src/lib/RCS/ZInitialize.c,v 1.17 89/05/30 18:11:25 jtkohl Exp $"; | |
| 18 | #endif | |
| 19 | ||
|
8792
b0645c9dc276
[gaim-migrate @ 9554]
Christian Hammond <chipx86@chipx86.com>
parents:
2419
diff
changeset
|
20 | #include "internal.h" |
| 2086 | 21 | |
| 22 | #include <sys/socket.h> | |
| 23 | #ifdef ZEPHYR_USES_KERBEROS | |
| 24 | #include <krb_err.h> | |
| 25 | #endif | |
| 26 | ||
| 2419 | 27 | #ifndef INADDR_NONE |
| 28 | #define INADDR_NONE 0xffffffff | |
| 29 | #endif | |
| 30 | ||
| 2086 | 31 | Code_t ZInitialize() |
| 32 | { | |
| 33 | struct servent *hmserv; | |
| 2419 | 34 | struct hostent *hostent; |
| 35 | char addr[4], hostname[MAXHOSTNAMELEN]; | |
| 36 | struct in_addr servaddr; | |
| 37 | struct sockaddr_in sin; | |
| 38 | int s, sinsize = sizeof(sin); | |
| 39 | Code_t code; | |
| 40 | ZNotice_t notice; | |
| 2086 | 41 | #ifdef ZEPHYR_USES_KERBEROS |
| 2419 | 42 | char *krealm = NULL; |
| 2086 | 43 | int krbval; |
| 2419 | 44 | char d1[ANAME_SZ], d2[INST_SZ]; |
| 2086 | 45 | |
| 46 | initialize_krb_error_table(); | |
| 47 | #endif | |
| 48 | ||
| 49 | initialize_zeph_error_table(); | |
| 50 | ||
| 51 | (void) memset((char *)&__HM_addr, 0, sizeof(__HM_addr)); | |
| 52 | ||
| 53 | __HM_addr.sin_family = AF_INET; | |
| 54 | ||
| 55 | /* Set up local loopback address for HostManager */ | |
| 56 | addr[0] = 127; | |
| 57 | addr[1] = 0; | |
| 58 | addr[2] = 0; | |
| 59 | addr[3] = 1; | |
| 60 | ||
| 61 | hmserv = (struct servent *)getservbyname(HM_SVCNAME, "udp"); | |
| 62 | __HM_addr.sin_port = (hmserv) ? hmserv->s_port : HM_SVC_FALLBACK; | |
| 63 | ||
| 64 | (void) memcpy((char *)&__HM_addr.sin_addr, addr, 4); | |
| 65 | ||
| 66 | __HM_set = 0; | |
| 67 | ||
| 2419 | 68 | /* Initialize the input queue */ |
| 69 | __Q_Tail = NULL; | |
| 70 | __Q_Head = NULL; | |
| 71 | ||
| 72 | /* if the application is a server, there might not be a zhm. The | |
| 73 | code will fall back to something which might not be "right", | |
| 74 | but this is is ok, since none of the servers call krb_rd_req. */ | |
| 75 | ||
| 76 | servaddr.s_addr = INADDR_NONE; | |
| 77 | if (! __Zephyr_server) { | |
| 78 | if ((code = ZOpenPort(NULL)) != ZERR_NONE) | |
| 79 | return(code); | |
| 80 | ||
| 81 | if ((code = ZhmStat(NULL, ¬ice)) != ZERR_NONE) | |
| 82 | return(code); | |
| 83 | ||
| 84 | ZClosePort(); | |
| 85 | ||
| 86 | /* the first field, which is NUL-terminated, is the server name. | |
| 87 | If this code ever support a multiplexing zhm, this will have to | |
| 88 | be made smarter, and probably per-message */ | |
| 89 | ||
| 2086 | 90 | #ifdef ZEPHYR_USES_KERBEROS |
| 2419 | 91 | krealm = krb_realmofhost(notice.z_message); |
| 92 | #endif | |
| 93 | hostent = gethostbyname(notice.z_message); | |
| 94 | if (hostent && hostent->h_addrtype == AF_INET) | |
| 95 | memcpy(&servaddr, hostent->h_addr, sizeof(servaddr)); | |
| 96 | ||
| 97 | ZFreeNotice(¬ice); | |
| 98 | } | |
| 99 | ||
| 100 | #ifdef ZEPHYR_USES_KERBEROS | |
| 101 | if (krealm) { | |
| 102 | strcpy(__Zephyr_realm, krealm); | |
| 103 | } else if ((krb_get_tf_fullname(TKT_FILE, d1, d2, __Zephyr_realm) | |
| 104 | != KSUCCESS) && | |
| 105 | ((krbval = krb_get_lrealm(__Zephyr_realm, 1)) != KSUCCESS)) { | |
| 2086 | 106 | return (krbval); |
| 2419 | 107 | } |
| 108 | #else | |
| 109 | strcpy(__Zephyr_realm, "local-realm"); | |
| 2086 | 110 | #endif |
| 111 | ||
| 2419 | 112 | __My_addr.s_addr = INADDR_NONE; |
| 113 | if (servaddr.s_addr != INADDR_NONE) { | |
| 114 | /* Try to get the local interface address by connecting a UDP | |
| 115 | * socket to the server address and getting the local address. | |
| 116 | * Some broken operating systems (e.g. Solaris 2.0-2.5) yield | |
| 117 | * INADDR_ANY (zero), so we have to check for that. */ | |
| 118 | s = socket(AF_INET, SOCK_DGRAM, 0); | |
| 119 | if (s != -1) { | |
| 120 | memset(&sin, 0, sizeof(sin)); | |
| 121 | sin.sin_family = AF_INET; | |
| 122 | memcpy(&sin.sin_addr, &servaddr, sizeof(servaddr)); | |
| 123 | sin.sin_port = HM_SRV_SVC_FALLBACK; | |
| 124 | if (connect(s, (struct sockaddr *) &sin, sizeof(sin)) == 0 | |
| 125 | && getsockname(s, (struct sockaddr *) &sin, &sinsize) == 0 | |
| 126 | && sin.sin_addr.s_addr != 0) | |
| 127 | memcpy(&__My_addr, &sin.sin_addr, sizeof(__My_addr)); | |
| 128 | close(s); | |
| 129 | } | |
| 130 | } | |
| 131 | if (__My_addr.s_addr == INADDR_NONE) { | |
| 132 | /* We couldn't figure out the local interface address by the | |
| 133 | * above method. Try by resolving the local hostname. (This | |
| 134 | * is a pretty broken thing to do, and unfortunately what we | |
| 135 | * always do on server machines.) */ | |
| 136 | if (gethostname(hostname, sizeof(hostname)) == 0) { | |
| 137 | hostent = gethostbyname(hostname); | |
| 138 | if (hostent && hostent->h_addrtype == AF_INET) | |
| 139 | memcpy(&__My_addr, hostent->h_addr, sizeof(__My_addr)); | |
| 140 | } | |
| 141 | } | |
| 142 | /* If the above methods failed, zero out __My_addr so things will | |
| 143 | * sort of kind of work. */ | |
| 144 | if (__My_addr.s_addr == INADDR_NONE) | |
| 145 | __My_addr.s_addr = 0; | |
| 146 | ||
| 2086 | 147 | /* Get the sender so we can cache it */ |
| 148 | (void) ZGetSender(); | |
| 149 | ||
| 150 | return (ZERR_NONE); | |
| 151 | } | |
| 2419 | 152 |