src/protocols/zephyr/ZSendRaw.c@cabd145237d8 (annotated)
src/protocols/zephyr/ZSendRaw.c
Thu, 07 Apr 2005 14:55:02 +0000
- author
- Richard Laager <rlaager@pidgin.im>
- date
- Thu, 07 Apr 2005 14:55:02 +0000
- changeset 10789
- cabd145237d8
- parent 8792
- b0645c9dc276
- child 11105
- 842fa517e08c
- permissions
- -rw-r--r--
[gaim-migrate @ 12431]
" The following log snippets should explain it: " --rlaager
(20:24:00) rlaager: Regarding the signal handling
conversation the other day... I've written a patch to stop
calling signal handlers and return as soon as we find one
signal handler that returns TRUE to indicate that it's
handled the signal. Is this the right approach?
(20:24:22) Ethan Blanton (Paco-Paco): the trouble is that it's
documented to behave exactly the way it does
(20:24:31) Ethan Blanton (Paco-Paco): so changing it is
notbackwards compatible
(20:24:31) rlaager: I'm talking for HEAD.
(20:24:41) Ethan Blanton (Paco-Paco): oh, I think that's a
good approach, yes
(20:24:53) rlaager: The way I've described is how I
*expected* it to work, having not read the documentation.
(20:25:09) Ethan Blanton (Paco-Paco): I'm convinced
(20:27:04) Stu Tomlinson (nosnilmot): rlaager: this, I
assume, breaks the generic-ness of signals, by assuming
that any that return values return booleans?
(20:27:26) Ethan Blanton (Paco-Paco): please break it
(20:27:33) Ethan Blanton (Paco-Paco): we already have
out-parameters
(20:27:42) rlaager: nosnilmot: from what I can see, the
return type is handled as a (void *)... so I'm checking that
ret_value != NULL
(20:27:57) rlaager: nosnilmot: that's the correct way to do it,
right?
...
(20:29:01) Ethan Blanton (Paco-Paco): allowing a
meaningful return value is an over-engineering
(20:30:07) rlaager: even after this patch, you should be able
to return meaningful return values
(20:30:15) rlaager: it'll just short-circuit on the first handler
that does
committer: Luke Schierer <lschiere@pidgin.im>
| 2086 | 1 | /* This file is part of the Project Athena Zephyr Notification System. |
| 2 | * It contains source for the ZSendRawNotice function. | |
| 3 | * | |
| 4 | * Created by: Robert French | |
| 5 | * | |
| 6 | * $Source$ | |
|
8792
b0645c9dc276
[gaim-migrate @ 9554]
Christian Hammond <chipx86@chipx86.com>
parents:
2086
diff
changeset
|
7 | * $Author: chipx86 $ |
| 2086 | 8 | * |
| 9 | * Copyright (c) 1987 by the Massachusetts Institute of Technology. | |
| 10 | * For copying and distribution information, see the file | |
| 11 | * "mit-copyright.h". | |
| 12 | */ | |
| 13 | /* $Header$ */ | |
| 14 | ||
| 15 | #ifndef lint | |
| 16 | static char rcsid_ZSendRawNotice_c[] = "$Header$"; | |
| 17 | #endif | |
| 18 | ||
|
8792
b0645c9dc276
[gaim-migrate @ 9554]
Christian Hammond <chipx86@chipx86.com>
parents:
2086
diff
changeset
|
19 | #include "internal.h" |
| 2086 | 20 | |
| 21 | Code_t ZSendRawNotice(notice) | |
| 22 | ZNotice_t *notice; | |
| 23 | { | |
| 24 | Code_t retval; | |
| 25 | ZNotice_t newnotice; | |
| 26 | char *buffer; | |
| 27 | int len; | |
| 28 | ||
| 29 | if ((retval = ZFormatRawNotice(notice, &buffer, &len)) != | |
| 30 | ZERR_NONE) | |
| 31 | return (retval); | |
| 32 | ||
| 33 | if ((retval = ZParseNotice(buffer, len, &newnotice)) != ZERR_NONE) | |
| 34 | return (retval); | |
| 35 | ||
| 36 | retval = Z_SendFragmentedNotice(&newnotice, len, NULL, Z_XmitFragment); | |
| 37 | ||
| 38 | free(buffer); | |
| 39 | ||
| 40 | return (retval); | |
| 41 | } |
