src/protocols/zephyr/com_err.h@cabd145237d8 (annotated)
src/protocols/zephyr/com_err.h
Thu, 07 Apr 2005 14:55:02 +0000
- author
- Richard Laager <rlaager@pidgin.im>
- date
- Thu, 07 Apr 2005 14:55:02 +0000
- changeset 10789
- cabd145237d8
- parent 2086
- 007508451e2c
- permissions
- -rw-r--r--
[gaim-migrate @ 12431]
" The following log snippets should explain it: " --rlaager
(20:24:00) rlaager: Regarding the signal handling
conversation the other day... I've written a patch to stop
calling signal handlers and return as soon as we find one
signal handler that returns TRUE to indicate that it's
handled the signal. Is this the right approach?
(20:24:22) Ethan Blanton (Paco-Paco): the trouble is that it's
documented to behave exactly the way it does
(20:24:31) Ethan Blanton (Paco-Paco): so changing it is
notbackwards compatible
(20:24:31) rlaager: I'm talking for HEAD.
(20:24:41) Ethan Blanton (Paco-Paco): oh, I think that's a
good approach, yes
(20:24:53) rlaager: The way I've described is how I
*expected* it to work, having not read the documentation.
(20:25:09) Ethan Blanton (Paco-Paco): I'm convinced
(20:27:04) Stu Tomlinson (nosnilmot): rlaager: this, I
assume, breaks the generic-ness of signals, by assuming
that any that return values return booleans?
(20:27:26) Ethan Blanton (Paco-Paco): please break it
(20:27:33) Ethan Blanton (Paco-Paco): we already have
out-parameters
(20:27:42) rlaager: nosnilmot: from what I can see, the
return type is handled as a (void *)... so I'm checking that
ret_value != NULL
(20:27:57) rlaager: nosnilmot: that's the correct way to do it,
right?
...
(20:29:01) Ethan Blanton (Paco-Paco): allowing a
meaningful return value is an over-engineering
(20:30:07) rlaager: even after this patch, you should be able
to return meaningful return values
(20:30:15) rlaager: it'll just short-circuit on the first handler
that does
committer: Luke Schierer <lschiere@pidgin.im>
| 2086 | 1 | /* |
| 2 | * Header file for common error description library. | |
| 3 | * | |
| 4 | * Copyright 1988, Student Information Processing Board of the | |
| 5 | * Massachusetts Institute of Technology. | |
| 6 | * | |
| 7 | * For copyright and distribution info, see the documentation supplied | |
| 8 | * with this package. | |
| 9 | */ | |
| 10 | ||
| 11 | #ifndef __COM_ERR_H | |
| 12 | #define __COM_ERR_H | |
| 13 | ||
| 14 | #define COM_ERR_BUF_LEN 25 | |
| 15 | ||
| 16 | /* Use __STDC__ to guess whether we can use stdarg, prototypes, and const. | |
| 17 | * This is a public header file, so autoconf can't help us here. */ | |
| 18 | #ifdef __STDC__ | |
| 19 | # include <stdarg.h> | |
| 20 | # define ETP(x) x | |
| 21 | # define ETCONST const | |
| 22 | #else | |
| 23 | # define ETP(x) () | |
| 24 | # define ETCONST | |
| 25 | #endif | |
| 26 | ||
| 27 | typedef void (*error_handler_t) ETP((ETCONST char *, long, ETCONST char *, | |
| 28 | va_list)); | |
| 29 | extern error_handler_t com_err_hook; | |
| 30 | void com_err ETP((ETCONST char *, long, ETCONST char *, ...)); | |
| 31 | ETCONST char *error_message ETP((long)); | |
| 32 | ETCONST char *error_message_r ETP((long, char *)); | |
| 33 | error_handler_t set_com_err_hook ETP((error_handler_t)); | |
| 34 | error_handler_t reset_com_err_hook ETP((void)); | |
| 35 | ||
| 36 | #undef ETP | |
| 37 | ||
| 38 | #endif /* ! defined(__COM_ERR_H) */ |
