src/protocols/oscar/invite.c@cb0a6cbd0023 (annotated)
src/protocols/oscar/invite.c
Sat, 18 Sep 2004 23:17:18 +0000
- author
- Rian Hunter <chrono86@users.sourceforge.net>
- date
- Sat, 18 Sep 2004 23:17:18 +0000
- changeset 10039
- cb0a6cbd0023
- parent 4071
- f0c425b22b92
- permissions
- -rw-r--r--
[gaim-migrate @ 10998]
A patch from rian hunter (chrono86):
In src/protocols/oscar/oscar.c, in the function
gaim_plugin_oscar_convert_to_best_encoding. g_convert
is called multiple times. As its 5th argument g_convert
takes a gsize* (8 byte), yet the argument to
gaim_plugin_oscar_convert_to_best_encoding is a int* (4
byte).
On LP64 machines this can allow the int* to be
overwritten. This is especially bad on big endian
64-bit machines, causing the high 32-bits to be written
into the low 32-bits of the int.
This is a quick fix patch that lets g_convert deal with
a gsize* pointer instead, then casting the value at
gsize* to the value at the int*.
A real fix would be to fix the aim_sendimext_args
structure to have a gsize instead of an int (and all
functions that use the aim_sendimext_args struct), and
changing gaim_plugin_oscar_convert_to_best_encoding to
accept a gsize*. of course, this woudl promote glib2
dependence, so that's probably not the best thing to do.
committer: Mark Doliner <markdoliner@pidgin.im>
| 2672 | 1 | /* |
|
3952
d13e1fde68d8
[gaim-migrate @ 4133]
Mark Doliner <markdoliner@pidgin.im>
parents:
2672
diff
changeset
|
2 | * Family 0x0006 - This isn't really ever used by anyone anymore. |
| 2672 | 3 | * |
| 4 | * Once upon a time, there used to be a menu item in AIM clients that | |
| 5 | * said something like "Invite a friend to use AIM..." and then it would | |
| 6 | * ask for an email address and it would sent a mail to them saying | |
| 7 | * how perfectly wonderful the AIM service is and why you should use it | |
| 8 | * and click here if you hate the person who sent this to you and want to | |
| 9 | * complain and yell at them in a small box with pretty fonts. | |
| 10 | * | |
| 11 | * I could've sworn libfaim had this implemented once, a long long time ago, | |
| 12 | * but I can't find it. | |
| 13 | * | |
| 14 | * I'm mainly adding this so that I can keep advertising that we support | |
| 15 | * group 6, even though we don't. | |
| 16 | * | |
| 17 | */ | |
| 18 | ||
| 19 | #define FAIM_INTERNAL | |
| 20 | #include <aim.h> | |
| 21 | ||
| 22 | faim_internal int invite_modfirst(aim_session_t *sess, aim_module_t *mod) | |
| 23 | { | |
| 24 | ||
| 25 | mod->family = 0x0006; | |
| 26 | mod->version = 0x0001; | |
| 27 | mod->toolid = 0x0110; | |
|
4071
f0c425b22b92
[gaim-migrate @ 4283]
Mark Doliner <markdoliner@pidgin.im>
parents:
3952
diff
changeset
|
28 | mod->toolversion = 0x0629; |
| 2672 | 29 | mod->flags = 0; |
| 30 | strncpy(mod->name, "invite", sizeof(mod->name)); | |
| 31 | mod->snachandler = NULL; | |
| 32 | ||
| 33 | return 0; | |
| 34 | } |
