Sat, 09 Aug 2025 02:43:31 -0500
Fix some broken logic in Purple.Conversation.send_message_async
The callback was doing some nonsense trying to give the user an error if
Purple.ProtocolConversation.send_message_async returned false without setting
error. This was then clearing the error using g_clear_error even if error was
set, but G.Task.return_error takes ownership of the error which is what lead
to the crash.
This wasn't caught by the unit tests because we don't have a test for
purple_conversation_send_message_async and
purple_conversation_send_message_finish. We should add one at some point as we
also weren't exposing purple_conversation_send_message_finish which I
discovered while debugging this.
Anyways, we should implement a unit test for this but it needs a protocol
as well and I didn't want to bother with this right now as the fix is more
important.
Testing Done:
Modified the demo protocol to return errors and verified the crash was gone. Reverted that and verified that sending messages worked.
Also called in the turtles.
Reviewed at https://reviews.imfreedom.org/r/4095/
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
1 | af |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
2 | am |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
3 | ar |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
4 | ar_SA |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
5 | as |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
6 | ast |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
7 | az |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
8 | az@latin |
|
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
9 | az_AZ |
|
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
10 | be |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
11 | be@latin |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
12 | bg |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
13 | bn |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
14 | bn_IN |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
15 | br |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
16 | brx |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
17 | bs |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
18 | ca |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
19 | ca@valencia |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
20 | cs |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
21 | cy |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
22 | da |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
23 | da_DK |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
24 | de |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
25 | dz |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
26 | el |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
27 | en_AU |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
28 | en_CA |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
29 | en_GB |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
30 | eo |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
31 | es |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
32 | es_AR |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
33 | es_CO |
|
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
34 | es_VE |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
35 | et |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
36 | eu |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
37 | fa |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
38 | fi |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
39 | fr |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
40 | fr_FR |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
41 | ga |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
42 | gl |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
43 | gu |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
44 | he |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
45 | hi |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
46 | hr |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
47 | hu |
|
40459
fcb900a70edf
We were missing the hy language
Gary Kramlich <grim@reaperworld.com>
parents:
39102
diff
changeset
|
48 | hy |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
49 | hy_AM |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
50 | id |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
51 | it |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
52 | ja |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
53 | ka |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
54 | kk |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
55 | km |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
56 | kn |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
57 | ko |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
58 | ks |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
59 | ku |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
60 | ku_IQ |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
61 | ky |
|
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
62 | ln |
|
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
63 | lo |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
64 | lt |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
65 | lv |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
66 | mai |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
67 | mhr |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
68 | mk |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
69 | ml |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
70 | mn |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
71 | mr |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
72 | ms_MY |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
73 | my_MM |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
74 | nb |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
75 | ne |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
76 | nl |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
77 | nn |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
78 | nqo |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
79 | oc |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
80 | or |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
81 | pa |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
82 | pl |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
83 | pms |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
84 | ps |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
85 | pt |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
86 | pt_BR |
|
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
87 | pt_PT |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
88 | ro |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
89 | ro_RO |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
90 | ru |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
91 | ru_RU |
|
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
92 | sat |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
93 | sd |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
94 | si |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
95 | sk |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
96 | sl |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
97 | sq |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
98 | sr |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
99 | sr@latin |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
100 | sv |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
101 | sw |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
102 | szl |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
103 | ta |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
104 | te |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
105 | tg |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
106 | th |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
107 | tr |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
108 | tt |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
109 | uk |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
110 | ur |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
111 | ur_PK |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
112 | uz |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
113 | vi |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
114 | xh |
|
43112
3515fa54e789
Update LINUGUAS and all po files from transifex
Gary Kramlich <grim@reaperworld.com>
parents:
40459
diff
changeset
|
115 | zh |
|
39102
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
116 | zh_CN |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
117 | zh_HK |
|
2267e036dd58
po: Move ALL_LINGUAS variable to po/LINGUAS file
Mike Ruprecht <cmaiku@gmail.com>
parents:
diff
changeset
|
118 | zh_TW |