po/meson.build@cddf3066f1bc (annotated)
po/meson.build
Sat, 09 Aug 2025 02:43:31 -0500
- author
- Gary Kramlich <grim@reaperworld.com>
- date
- Sat, 09 Aug 2025 02:43:31 -0500
- changeset 43303
- cddf3066f1bc
- parent 42473
- c2cb3f628555
- permissions
- -rw-r--r--
Fix some broken logic in Purple.Conversation.send_message_async
The callback was doing some nonsense trying to give the user an error if
Purple.ProtocolConversation.send_message_async returned false without setting
error. This was then clearing the error using g_clear_error even if error was
set, but G.Task.return_error takes ownership of the error which is what lead
to the crash.
This wasn't caught by the unit tests because we don't have a test for
purple_conversation_send_message_async and
purple_conversation_send_message_finish. We should add one at some point as we
also weren't exposing purple_conversation_send_message_finish which I
discovered while debugging this.
Anyways, we should implement a unit test for this but it needs a protocol
as well and I didn't want to bother with this right now as the fix is more
important.
Testing Done:
Modified the demo protocol to return errors and verified the crash was gone. Reverted that and verified that sending messages worked.
Also called in the turtles.
Reviewed at https://reviews.imfreedom.org/r/4095/
|
40461
25f653ee017e
Change the logic for determining whether or not to install translations
Gary Kramlich <grim@reaperworld.com>
parents:
39707
diff
changeset
|
1 | i18n = import('i18n') |
|
25f653ee017e
Change the logic for determining whether or not to install translations
Gary Kramlich <grim@reaperworld.com>
parents:
39707
diff
changeset
|
2 | |
|
41297
4960320545ef
Move our i18n setup to the glib preset.
Gary Kramlich <grim@reaperworld.com>
parents:
40461
diff
changeset
|
3 | # use the glib preset which is defined at |
|
4960320545ef
Move our i18n setup to the glib preset.
Gary Kramlich <grim@reaperworld.com>
parents:
40461
diff
changeset
|
4 | # https://github.com/mesonbuild/meson/blob/master/mesonbuild/modules/i18n.py#L93 |
|
4960320545ef
Move our i18n setup to the glib preset.
Gary Kramlich <grim@reaperworld.com>
parents:
40461
diff
changeset
|
5 | # at the time of this comment. |
|
42454
37bcbcd66c6f
Set our gettext package to pidgin3 so it can we can install next to pidgin2
Gary Kramlich <grim@reaperworld.com>
parents:
41485
diff
changeset
|
6 | i18n.gettext(GETTEXT_PACKAGE, preset : 'glib') |
|
42473
c2cb3f628555
Update a bunch of gettext stuff
Gary Kramlich <grim@reaperworld.com>
parents:
42454
diff
changeset
|
7 | |
|
c2cb3f628555
Update a bunch of gettext stuff
Gary Kramlich <grim@reaperworld.com>
parents:
42454
diff
changeset
|
8 | devenv.append('PURPLE_LOCALE_DIR', meson.current_build_dir()) |
