libgaim/protocols/yahoo/yahoo_auth.h@f3d13f21350c (annotated)
libgaim/protocols/yahoo/yahoo_auth.h
Tue, 26 Sep 2006 17:38:09 +0000
- author
- Richard Laager <rlaager@pidgin.im>
- date
- Tue, 26 Sep 2006 17:38:09 +0000
- changeset 14686
- f3d13f21350c
- parent 14254
- 77edc7a6191a
- child 20470
- 77693555855f
- permissions
- -rwxr-xr-x
[gaim-migrate @ 17356]
After the comments on gaim-devel about 'bad' code, I looked into the function referenced. It appears that yahoo_buddy_icon_upload_connected() is only called as a callback. It's registered from yahoo_buddy_icon_upload(). yahoo_buddy_icon_upload() is only called twice. In neither case can a NULL make it down to yahoo_buddy_icon_upload_connected(). As this is an exceptional case rather than a normal one, a g_return_if_fail() is more appropriate. That adds logging, makes the intent clearer, and will help the Coverity software detect violations of this assumption.
| 8350 | 1 | /* |
| 2 | * yahoo_auth.h: Header for Yahoo Messenger authentication schemes. Eew. | |
| 3 | * | |
| 4 | * Copyright(c) 2003 Cerulean Studios | |
| 5 | */ | |
| 6 | ||
| 7 | #ifndef _YAHOO_AUTH_H_ | |
| 8 | #define _YAHOO_AUTH_H_ | |
| 9 | ||
| 10 | #define NUM_TYPE_THREES 105 | |
| 11 | #define NUM_TYPE_FOURS 56 | |
| 12 | #define NUM_TYPE_FIVES 37 | |
| 13 | ||
| 14 | unsigned int yahoo_auth_finalCountdown(unsigned int challenge, int divisor, int inner_loop, int outer_loop); | |
| 15 | ||
| 16 | /* We've defined the Yahoo authentication functions as having types 1-5; all take either 1 or 2 arguments. | |
| 17 | */ | |
| 18 | ||
| 19 | typedef struct _auth { | |
| 20 | int type; | |
| 21 | int var1; | |
| 22 | int var2; | |
| 23 | } auth_function_t; | |
| 24 | ||
| 25 | /* Type 3, 4 and 5 require lookups into ypager.exe's many static chunks of 256 bytes. Store them here. | |
| 26 | */ | |
| 27 | ||
| 28 | struct buffer_t { | |
| 29 | unsigned int buffer_start; | |
| 30 | unsigned char buffer[257]; | |
| 31 | }; | |
| 32 | ||
| 33 | #endif /* _YAHOO_AUTH_H_ */ |
