libgaim/protocols/zephyr/ZPending.c@f3d13f21350c (annotated)
libgaim/protocols/zephyr/ZPending.c
Tue, 26 Sep 2006 17:38:09 +0000
- author
- Richard Laager <rlaager@pidgin.im>
- date
- Tue, 26 Sep 2006 17:38:09 +0000
- changeset 14686
- f3d13f21350c
- parent 14254
- 77edc7a6191a
- child 20470
- 77693555855f
- permissions
- -rw-r--r--
[gaim-migrate @ 17356]
After the comments on gaim-devel about 'bad' code, I looked into the function referenced. It appears that yahoo_buddy_icon_upload_connected() is only called as a callback. It's registered from yahoo_buddy_icon_upload(). yahoo_buddy_icon_upload() is only called twice. In neither case can a NULL make it down to yahoo_buddy_icon_upload_connected(). As this is an exceptional case rather than a normal one, a g_return_if_fail() is more appropriate. That adds logging, makes the intent clearer, and will help the Coverity software detect violations of this assumption.
| 2086 | 1 | /* This file is part of the Project Athena Zephyr Notification System. |
| 2 | * It contains source for the ZPending function. | |
| 3 | * | |
| 4 | * Created by: Robert French | |
| 5 | * | |
| 6 | * Copyright (c) 1987 by the Massachusetts Institute of Technology. | |
| 7 | * For copying and distribution information, see the file | |
| 8 | * "mit-copyright.h". | |
| 9 | */ | |
| 10 | ||
|
8792
b0645c9dc276
[gaim-migrate @ 9554]
Christian Hammond <chipx86@chipx86.com>
parents:
2086
diff
changeset
|
11 | #include "internal.h" |
| 2086 | 12 | |
| 13 | int ZPending() | |
| 14 | { | |
| 15 | int retval; | |
| 16 | ||
| 17 | if (ZGetFD() < 0) { | |
| 18 | errno = ZERR_NOPORT; | |
| 19 | return (-1); | |
| 20 | } | |
| 21 | ||
| 22 | if ((retval = Z_ReadEnqueue()) != ZERR_NONE) { | |
| 23 | errno = retval; | |
| 24 | return (-1); | |
| 25 | } | |
| 26 | ||
| 27 | return(ZQLength()); | |
| 28 | } |
