libgaim/protocols/zephyr/error_table.h@f3d13f21350c (annotated)
libgaim/protocols/zephyr/error_table.h
Tue, 26 Sep 2006 17:38:09 +0000
- author
- Richard Laager <rlaager@pidgin.im>
- date
- Tue, 26 Sep 2006 17:38:09 +0000
- changeset 14686
- f3d13f21350c
- parent 14254
- 77edc7a6191a
- child 20470
- 77693555855f
- permissions
- -rw-r--r--
[gaim-migrate @ 17356]
After the comments on gaim-devel about 'bad' code, I looked into the function referenced. It appears that yahoo_buddy_icon_upload_connected() is only called as a callback. It's registered from yahoo_buddy_icon_upload(). yahoo_buddy_icon_upload() is only called twice. In neither case can a NULL make it down to yahoo_buddy_icon_upload_connected(). As this is an exceptional case rather than a normal one, a g_return_if_fail() is more appropriate. That adds logging, makes the intent clearer, and will help the Coverity software detect violations of this assumption.
| 2086 | 1 | /* |
| 2 | * Copyright 1988 by the Student Information Processing Board of the | |
| 3 | * Massachusetts Institute of Technology. | |
| 4 | * | |
| 5 | * For copyright info, see mit-sipb-copyright.h. | |
| 6 | */ | |
| 7 | ||
| 8 | #ifndef _ET_H | |
| 9 | struct error_table { | |
| 10 | char const * const * msgs; | |
| 11 | long base; | |
| 12 | int n_msgs; | |
| 13 | }; | |
| 14 | struct et_list { | |
| 15 | struct et_list *next; | |
| 16 | const struct error_table *table; | |
| 17 | }; | |
| 18 | extern struct et_list * _et_list; | |
| 19 | ||
| 20 | #define ERRCODE_RANGE 8 /* # of bits to shift table number */ | |
| 21 | #define BITS_PER_CHAR 6 /* # bits to shift per character in name */ | |
| 22 | ||
|
12497
a17568773be3
[gaim-migrate @ 14809]
Richard Laager <rlaager@pidgin.im>
parents:
12323
diff
changeset
|
23 | const char *error_table_name(void); |
| 2086 | 24 | #define _ET_H |
| 25 | #endif |
