pidgin3: comparison libpurple/protocols/zephyr/zephyr.c

-:1f67d7260477
+:d036174d9e22
 typedef struct _zephyr_triple zephyr_triple;
 typedef struct _zephyr_account zephyr_account;
 typedef gssize (*PollableInputStreamReadFunc)(GPollableInputStream *stream, void *bufcur, GError **error);
 typedef gboolean (*ZephyrLoginFunc)(zephyr_account *zephyr);
+typedef Code_t (*ZephyrSubscribeToFunc)(zephyr_account *zephyr, char *class, char *instance, char *recipient);
 typedef enum {
 	PURPLE_ZEPHYR_NONE, /* Non-kerberized ZEPH0.2 */
 	PURPLE_ZEPHYR_KRB4, /* ZEPH0.2 w/ KRB4 support */
 	PURPLE_ZEPHYR_TZC,  /* tzc executable proxy */
 	char *exposure;
 	GSubprocess *tzc_proc;
 	GOutputStream *tzc_stdin;
 	GInputStream *tzc_stdout;
 	gchar *away;
+	ZephyrSubscribeToFunc subscribe_to;
 };
 #define MAXCHILDREN 20
 struct _zephyr_triple {
 		g_error_free(error);
 	}
 	return success;
 }
-static Code_t zephyr_subscribe_to(zephyr_account* zephyr, char* class, char *instance, char *recipient, char* galaxy) {
+static Code_t
+subscribe_to_tzc(zephyr_account *zephyr, char *class, char *instance, char *recipient)
+{
 	Code_t ret_val = -1;
+	gchar *zsubstr;
-	if (use_tzc(zephyr)) {
-		/* ((tzcfodder . subscribe) ("class" "instance" "recipient")) */
+	/* ((tzcfodder . subscribe) ("class" "instance" "recipient")) */
-		gchar *zsubstr;
+	zsubstr = g_strdup_printf("((tzcfodder . subscribe) (\"%s\" \"%s\" \"%s\"))\n",
+	                          class, instance, recipient);
-		zsubstr = g_strdup_printf(
+	if (zephyr_write_message(zephyr, zsubstr)) {
-		        "((tzcfodder . subscribe) (\"%s\" \"%s\" \"%s\"))\n", class,
+		ret_val = ZERR_NONE;
-		        instance, recipient);
+	}
-		if (zephyr_write_message(zephyr, zsubstr)) {
+	g_free(zsubstr);
-			ret_val = ZERR_NONE;
-		}
-		g_free(zsubstr);
-	}
-	else {
-		if (use_zeph02(zephyr)) {
-			ZSubscription_t sub;
-			sub.zsub_class = class;
-			sub.zsub_classinst = instance;
-			sub.zsub_recipient = recipient;
-			ret_val = ZSubscribeTo(&sub,1,0);
-		}
-	}
 	return ret_val;
+}
+static Code_t
+subscribe_to_zeph02(G_GNUC_UNUSED zephyr_account *zephyr, char *class, char *instance, char *recipient)
+{
+	ZSubscription_t sub;
+	sub.zsub_class = class;
+	sub.zsub_classinst = instance;
+	sub.zsub_recipient = recipient;
+	return ZSubscribeTo(&sub, 1, 0);
 }
 char *local_zephyr_normalize(zephyr_account* zephyr,const char *);
 static void zephyr_chat_set_topic(PurpleConnection * gc, int id, const char *topic);
 char* zephyr_tzc_deescape_str(const char *message);
 	if (f) {
 		char **triple;
 		char *recip;
 		char *z_class;
 		char *z_instance;
-		char *z_galaxy = NULL;
 		while (fgets(buff, BUFSIZ, f)) {
 			strip_comments(buff);
 			if (buff[0]) {
 				triple = g_strsplit(buff, ",", 3);
 					}
 					/* There should be some sort of error report listing classes that couldn't be subbed to.
 					   Not important right now though */
-					if (zephyr_subscribe_to(zephyr,z_class, z_instance, recip,z_galaxy) != ZERR_NONE) {
+					if (zephyr->subscribe_to(zephyr, z_class, z_instance, recip) != ZERR_NONE) {
 						purple_debug_error("zephyr", "Couldn't subscribe to %s, %s, %s\n", z_class,z_instance,recip);
 					}
 					zephyr->subscrips = g_slist_append(zephyr->subscrips, new_triple(zephyr,z_class,z_instance,recip));
 					/*					  g_hash_table_destroy(sub_hash_table); */
 	if (purple_account_get_bool(account, "use_tzc", FALSE)) {
 		zephyr->connection_type = PURPLE_ZEPHYR_TZC;
 		login = login_tzc;
 		check_notify = check_notify_tzc;
+		zephyr->subscribe_to = subscribe_to_tzc;
 	} else {
 		zephyr->connection_type = PURPLE_ZEPHYR_KRB4;
 		login = login_zeph02;
 		check_notify = check_notify_zeph02;
+		zephyr->subscribe_to = subscribe_to_zeph02;
 	}
 	zephyr->encoding = (char *)purple_account_get_string(account, "encoding", ZEPHYR_FALLBACK_CHARSET);
 	purple_connection_update_progress(gc, _("Connecting"), 0, 8);
 	/* For now */
 	zephyr->galaxy = NULL;
 	zephyr->krbtkfile = NULL;
 	zephyr_inithosts(zephyr);
-	if (zephyr_subscribe_to(zephyr,"MESSAGE","PERSONAL",zephyr->username,NULL) != ZERR_NONE) {
+	if (zephyr->subscribe_to(zephyr, "MESSAGE", "PERSONAL", zephyr->username) != ZERR_NONE) {
 		/* XXX don't translate this yet. It could be written better */
 		/* XXX error messages could be handled with more detail */
 		purple_notify_error(gc, NULL,
 			"Unable to subscribe to messages", "Unable to subscribe to initial messages",
 			purple_request_cpar_from_connection(gc));
 	/*	sub.zsub_class = zt1->class;
 		sub.zsub_classinst = zt1->instance;
 		sub.zsub_recipient = zt1->recipient; */
-	if (zephyr_subscribe_to(zephyr,zt1->class,zt1->instance,zt1->recipient,NULL) != ZERR_NONE) {
+	if (zephyr->subscribe_to(zephyr, zt1->class, zt1->instance, zt1->recipient) != ZERR_NONE) {
 		/* XXX output better subscription information */
 		zephyr_subscribe_failed(gc,zt1->class,zt1->instance,zt1->recipient,NULL);
 		free_triple(zt1);
 		return;
 	}
 static int zephyr_resubscribe(PurpleConnection *gc)
 {
 	/* Resubscribe to the in-memory list of subscriptions and also
 	   unsubscriptions*/
 	zephyr_account *zephyr = purple_connection_get_protocol_data(gc);
-	GSList *s = zephyr->subscrips;
+	for (GSList *s = zephyr->subscrips; s; s = s->next) {
-	zephyr_triple *zt;
+		zephyr_triple *zt = s->data;
-	while (s) {
-		zt = s->data;
 		/* XXX We really should care if this fails */
-		zephyr_subscribe_to(zephyr,zt->class,zt->instance,zt->recipient,NULL);
+		zephyr->subscribe_to(zephyr, zt->class, zt->instance, zt->recipient);
-		s = s->next;
 	}
 	/* XXX handle unsubscriptions */
 	return 1;
 }

Mercurial > pidgin3 / file comparison

comparison: libpurple/protocols/zephyr/zephyr.c

libpurple/protocols/zephyr/zephyr.c