libpurple/enums.h.in@1dff6e343f9f
libpurple/enums.h.in
Mon, 12 Sep 2016 08:55:35 -0500
- author
- Mike Ruprecht <cmaiku@gmail.com>
- date
- Mon, 12 Sep 2016 08:55:35 -0500
- changeset 38142
- 1dff6e343f9f
- parent 35487
- 494f09f7f331
- child 38511
- cddada195a91
- permissions
- -rw-r--r--
gg: Protect against issues when closing while connecting
Since the GIOStream is cancelled when data is freed, any cancelled
callbacks are called after such data is freed. This patch guards against
cancelled calls by safely returning without accessing any freed data if
the connection has been cancelled (aka closed).
Futhermore, if GG tries to connect and is quickly disconnected,
ggp_tcpsocket_close() is never called. As far as I can tell, it's an
existing bug, but PurpleSockets both work differently when closing and
are closed by the connection if any leak. So the issue wasn't a major
problem. This patch lessens the issue by guarding against it, but it
should be fixed at some point.
/*** BEGIN file-header ***/ /* purple * * Purple is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #ifndef PURPLE_ENUMS_H #define PURPLE_ENUMS_H /** * SECTION:enums * @section_id: libpurple-enums * @short_description: <filename>enums.h</filename> * @title: GEnums and GFlags * * This file contains all the #GEnum and #GFlags type definitions of libpurple. */ #include <glib-object.h> G_BEGIN_DECLS /*** END file-header ***/ /*** BEGIN file-production ***/ /* enumerations from "@filename@" */ /*** END file-production ***/ /*** BEGIN value-header ***/ GType @enum_name@_get_type(void) G_GNUC_CONST; #define @ENUMPREFIX@_TYPE_@ENUMSHORT@ (@enum_name@_get_type()) /*** END value-header ***/ /*** BEGIN file-tail ***/ G_END_DECLS #endif /* PURPLE_ENUMS_H */ /*** END file-tail ***/
