Mon, 12 Sep 2016 08:55:35 -0500
gg: Protect against issues when closing while connecting
Since the GIOStream is cancelled when data is freed, any cancelled
callbacks are called after such data is freed. This patch guards against
cancelled calls by safely returning without accessing any freed data if
the connection has been cancelled (aka closed).
Futhermore, if GG tries to connect and is quickly disconnected,
ggp_tcpsocket_close() is never called. As far as I can tell, it's an
existing bug, but PurpleSockets both work differently when closing and
are closed by the connection if any leak. So the issue wasn't a major
problem. This patch lessens the issue by guarding against it, but it
should be fixed at some point.
/** * @file yahoo_friend.h The Yahoo! protocol plugin YahooFriend object * * purple * * Purple is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #ifndef _YAHOO_FRIEND_H_ #define _YAHOO_FRIEND_H_ #include "ymsg.h" #include "yahoo_packet.h" typedef enum { YAHOO_PRESENCE_DEFAULT = 0, YAHOO_PRESENCE_ONLINE, YAHOO_PRESENCE_PERM_OFFLINE } YahooPresenceVisibility; typedef enum { YAHOO_P2PSTATUS_NOT_CONNECTED = 0, YAHOO_P2PSTATUS_DO_NOT_CONNECT, YAHOO_P2PSTATUS_WE_ARE_SERVER, YAHOO_P2PSTATUS_WE_ARE_CLIENT } YahooP2PStatus; /* these are called friends instead of buddies mainly so I can use variables * named f and not confuse them with variables named b */ typedef struct _YahooFriend { enum yahoo_status status; gchar *msg; gchar *game; int idle; int away; gboolean sms; gchar *ip; gboolean bicon_sent_request; YahooPresenceVisibility presence; long int version_id; YahooPersonalDetails ypd; YahooP2PStatus p2p_status; gboolean p2p_packet_sent; /* 0:not sent, 1=sent */ gint session_id; /* session id of friend */ } YahooFriend; YahooFriend *yahoo_friend_find(PurpleConnection *gc, const char *name); YahooFriend *yahoo_friend_find_or_new(PurpleConnection *gc, const char *name); void yahoo_friend_set_ip(YahooFriend *f, const char *ip); const char *yahoo_friend_get_ip(YahooFriend *f); void yahoo_friend_set_game(YahooFriend *f, const char *game); const char *yahoo_friend_get_game(YahooFriend *f); void yahoo_friend_set_status_message(YahooFriend *f, char *msg); const char *yahoo_friend_get_status_message(YahooFriend *f); void yahoo_friend_set_alias_id(YahooFriend *f, const char *alias_id); const char *yahoo_friend_get_alias_id(YahooFriend *f); void yahoo_friend_set_buddy_icon_need_request(YahooFriend *f, gboolean needs); gboolean yahoo_friend_get_buddy_icon_need_request(YahooFriend *f); void yahoo_friend_free(gpointer p); void yahoo_process_presence(PurpleConnection *gc, struct yahoo_packet *pkt); void yahoo_friend_update_presence(PurpleConnection *gc, const char *name, YahooPresenceVisibility presence); void yahoo_friend_set_p2p_status(YahooFriend *f, YahooP2PStatus p2p_status); YahooP2PStatus yahoo_friend_get_p2p_status(YahooFriend *f); #endif /* _YAHOO_FRIEND_H_ */