libpurple/protocols/yahoo/yahoo_picture.h@1dff6e343f9f
libpurple/protocols/yahoo/yahoo_picture.h
Mon, 12 Sep 2016 08:55:35 -0500
- author
- Mike Ruprecht <cmaiku@gmail.com>
- date
- Mon, 12 Sep 2016 08:55:35 -0500
- changeset 38142
- 1dff6e343f9f
- parent 35834
- 5eb0ba6d126d
- permissions
- -rw-r--r--
gg: Protect against issues when closing while connecting
Since the GIOStream is cancelled when data is freed, any cancelled
callbacks are called after such data is freed. This patch guards against
cancelled calls by safely returning without accessing any freed data if
the connection has been cancelled (aka closed).
Futhermore, if GG tries to connect and is quickly disconnected,
ggp_tcpsocket_close() is never called. As far as I can tell, it's an
existing bug, but PurpleSockets both work differently when closing and
are closed by the connection if any leak. So the issue wasn't a major
problem. This patch lessens the issue by guarding against it, but it
should be fixed at some point.
/* * purple * * Purple is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA * */ #ifndef _YAHOO_PICTURE_H_ #define _YAHOO_PICTURE_H_ void yahoo_send_picture_request(PurpleConnection *gc, const char *who); void yahoo_send_picture_info(PurpleConnection *gc, const char *who); void yahoo_send_picture_checksum(PurpleConnection *gc); void yahoo_send_picture_update(PurpleConnection *gc, int type); void yahoo_send_picture_update_to_user(PurpleConnection *gc, const char *who, int type); void yahoo_process_picture(PurpleConnection *gc, struct yahoo_packet *pkt); void yahoo_process_picture_checksum(PurpleConnection *gc, struct yahoo_packet *pkt); void yahoo_process_picture_upload(PurpleConnection *gc, struct yahoo_packet *pkt); void yahoo_process_avatar_update(PurpleConnection *gc, struct yahoo_packet *pkt); void yahoo_set_buddy_icon(PurpleConnection *gc, PurpleImage *img); void yahoo_buddy_icon_upload(PurpleConnection *gc, struct yahoo_buddy_icon_upload_data *d); void yahoo_buddy_icon_upload_data_free(struct yahoo_buddy_icon_upload_data *d); #endif /* _YAHOO_PICTURE_H_ */
