pidgin/gtkdnd-hints.h@210f318db492
pidgin/gtkdnd-hints.h
Tue, 09 Jul 2024 02:03:20 -0500
- author
- Yoann Congal <yoann.congal@smile.fr>
- date
- Tue, 09 Jul 2024 02:03:20 -0500
- branch
- release-2.x.y
- changeset 42808
- 210f318db492
- parent 26727
- b8885bab55ab
- child 32790
- b95c7c504118
- permissions
- -rw-r--r--
Fix incompatible pointer types for GtkItemFactoryCallbacks on gcc-14
The GtkItemFactoryEntry struct callback is of type GtkItemFactoryCallbacks
(aka void (*)(void)) but is initialised with GtkItemFactoryCallback1 types
(aka void (*)(void *, guint, GtkWidget *)).
This is coherent with the gtk-2 documentation:
> gtk_item_factory_create_items(..., GtkItemFactoryEntry *entries,...)
> entries : an array of GtkItemFactoryEntrys whose callback members must by of
> type GtkItemFactoryCallback1
But, under gcc-14, the implicit cast from GtkItemFactoryCallback1 to
GtkItemFactoryCallback triggers an incompatible-pointer-types error (See [gcc-doc]).
An exemple of this error:
pidgin/gtkconv.c:3096:66: error: initialization of 'void (*)(void)' from incompatible pointer type 'void (*)(void *, guint, GtkWidget *)' {aka 'void (*)(void *, unsigned int, struct _GtkWidget *)'} [-Wincompatible-pointer-types]
3096 | { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb,
| ^~~~~~~~~~~~~~~~
pidgin/gtkconv.c:3096:66: note: (near initialization for 'menu_items[1].callback')
To fix this, explicitely cast to GtkItemFactoryCallback where needed.
[0]: https://gcc.gnu.org/gcc-14/porting_to.html#incompatible-pointer-types
Testing Done:
Built with gcc-14, started and clicked on some affected menus
Reviewed at https://reviews.imfreedom.org/r/3282/
/** * @file gtkdnd-hints.h GTK+ Drag-and-Drop arrow hints * @ingroup pidgin */ /* Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2, or (at your option) * any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301, USA. */ #ifndef _PIDGIN_DND_HINTS_H_ #define _PIDGIN_DND_HINTS_H_ #include <glib.h> #include <gtk/gtk.h> /** * Conversation drag-and-drop arrow types. */ typedef enum { HINT_ARROW_UP, /**< Up arrow. */ HINT_ARROW_DOWN, /**< Down arrow. */ HINT_ARROW_LEFT, /**< Left arrow. */ HINT_ARROW_RIGHT /**< Right arrow. */ } DndHintWindowId; /** * Conversation drag-and-drop arrow positions. */ typedef enum { HINT_POSITION_RIGHT, /**< Position to the right of a tab. */ HINT_POSITION_LEFT, /**< Position to the left of a tab. */ HINT_POSITION_TOP, /**< Position above a tab. */ HINT_POSITION_BOTTOM, /**< Position below a tab. */ HINT_POSITION_CENTER /**< Position in the center of a tab. */ } DndHintPosition; /** * Shows a drag-and-drop hint at the specified location. * * @param id The ID of the hint to show. * @param x The X location to show it at. * @param y The Y location to show it at. */ void dnd_hints_show(DndHintWindowId id, gint x, gint y); /** * Hides the specified drag-and-drop hint. * * @param id The ID of the hint to hide. */ void dnd_hints_hide(DndHintWindowId id); /** * Hides all drag-and-drop hints. */ void dnd_hints_hide_all(void); /** * Shows a drag-and-drop hint relative to a widget. * * @param id The ID of the hint. * @param widget The widget that the hint is relative to. * @param horiz The horizontal relative position. * @param vert The vertical relative position. */ void dnd_hints_show_relative(DndHintWindowId id, GtkWidget *widget, DndHintPosition horiz, DndHintPosition vert); #endif /* _PIDGIN_DND_HINTS_H_ */
