pidgin/gtkplugin.h@210f318db492
pidgin/gtkplugin.h
Tue, 09 Jul 2024 02:03:20 -0500
- author
- Yoann Congal <yoann.congal@smile.fr>
- date
- Tue, 09 Jul 2024 02:03:20 -0500
- branch
- release-2.x.y
- changeset 42808
- 210f318db492
- parent 38258
- 9a6551eba09c
- child 38358
- 30ba44276e74
- permissions
- -rw-r--r--
Fix incompatible pointer types for GtkItemFactoryCallbacks on gcc-14
The GtkItemFactoryEntry struct callback is of type GtkItemFactoryCallbacks
(aka void (*)(void)) but is initialised with GtkItemFactoryCallback1 types
(aka void (*)(void *, guint, GtkWidget *)).
This is coherent with the gtk-2 documentation:
> gtk_item_factory_create_items(..., GtkItemFactoryEntry *entries,...)
> entries : an array of GtkItemFactoryEntrys whose callback members must by of
> type GtkItemFactoryCallback1
But, under gcc-14, the implicit cast from GtkItemFactoryCallback1 to
GtkItemFactoryCallback triggers an incompatible-pointer-types error (See [gcc-doc]).
An exemple of this error:
pidgin/gtkconv.c:3096:66: error: initialization of 'void (*)(void)' from incompatible pointer type 'void (*)(void *, guint, GtkWidget *)' {aka 'void (*)(void *, unsigned int, struct _GtkWidget *)'} [-Wincompatible-pointer-types]
3096 | { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb,
| ^~~~~~~~~~~~~~~~
pidgin/gtkconv.c:3096:66: note: (near initialization for 'menu_items[1].callback')
To fix this, explicitely cast to GtkItemFactoryCallback where needed.
[0]: https://gcc.gnu.org/gcc-14/porting_to.html#incompatible-pointer-types
Testing Done:
Built with gcc-14, started and clicked on some affected menus
Reviewed at https://reviews.imfreedom.org/r/3282/
/** * @file gtkplugin.h GTK+ Plugin API * @ingroup pidgin */ /* pidgin * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #ifndef _PIDGINPLUGIN_H_ #define _PIDGINPLUGIN_H_ #include "pidgin.h" #include "plugin.h" typedef struct _PidginPluginUiInfo PidginPluginUiInfo; /** * A GTK+ UI structure for plugins. */ struct _PidginPluginUiInfo { GtkWidget *(*get_config_frame)(PurplePlugin *plugin); int page_num; /**< Reserved */ /* padding */ void (*_pidgin_reserved1)(void); void (*_pidgin_reserved2)(void); void (*_pidgin_reserved3)(void); void (*_pidgin_reserved4)(void); }; #define PIDGIN_PLUGIN_TYPE PIDGIN_UI #define PIDGIN_IS_PIDGIN_PLUGIN(plugin) \ ((plugin)->info != NULL && (plugin)->info->ui_info != NULL && \ purple_strequal((plugin)->info->ui_requirement, PIDGIN_PLUGIN_TYPE)) #define PIDGIN_PLUGIN_UI_INFO(plugin) \ ((PidginPluginUiInfo *)(plugin)->info->ui_info) /** * Returns the configuration frame widget for a GTK+ plugin, if one * exists. * * @param plugin The plugin. * * @return The frame, if the plugin is a GTK+ plugin and provides a * configuration frame. */ GtkWidget *pidgin_plugin_get_config_frame(PurplePlugin *plugin); /** * Saves all loaded plugins. */ void pidgin_plugins_save(void); /** * Shows the Plugins dialog */ void pidgin_plugin_dialog_show(void); #endif /* _PIDGINPLUGIN_H_ */
