Tue, 09 Jul 2024 02:03:20 -0500
Fix incompatible pointer types for GtkItemFactoryCallbacks on gcc-14
The GtkItemFactoryEntry struct callback is of type GtkItemFactoryCallbacks
(aka void (*)(void)) but is initialised with GtkItemFactoryCallback1 types
(aka void (*)(void *, guint, GtkWidget *)).
This is coherent with the gtk-2 documentation:
> gtk_item_factory_create_items(..., GtkItemFactoryEntry *entries,...)
> entries : an array of GtkItemFactoryEntrys whose callback members must by of
> type GtkItemFactoryCallback1
But, under gcc-14, the implicit cast from GtkItemFactoryCallback1 to
GtkItemFactoryCallback triggers an incompatible-pointer-types error (See [gcc-doc]).
An exemple of this error:
pidgin/gtkconv.c:3096:66: error: initialization of 'void (*)(void)' from incompatible pointer type 'void (*)(void *, guint, GtkWidget *)' {aka 'void (*)(void *, unsigned int, struct _GtkWidget *)'} [-Wincompatible-pointer-types]
3096 | { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb,
| ^~~~~~~~~~~~~~~~
pidgin/gtkconv.c:3096:66: note: (near initialization for 'menu_items[1].callback')
To fix this, explicitely cast to GtkItemFactoryCallback where needed.
[0]: https://gcc.gnu.org/gcc-14/porting_to.html#incompatible-pointer-types
Testing Done:
Built with gcc-14, started and clicked on some affected menus
Reviewed at https://reviews.imfreedom.org/r/3282/
/* * @file gtkstyle.c GTK+ Style utility functions * @ingroup pidgin */ /* pidgin * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA * */ #include "gtkstyle.h" /* Assume light mode */ static gboolean dark_mode_cache = FALSE; gboolean pidgin_style_is_dark(GtkStyle *style) { GdkColor bg; if (!style) { return dark_mode_cache; } bg = style->base[GTK_STATE_NORMAL]; if (bg.red != 0xFFFF || bg.green != 0xFFFF || bg.blue != 0xFFFF) { dark_mode_cache = ((int) bg.red + (int) bg.green + (int) bg.blue) < (65536 * 3 / 2); } return dark_mode_cache; } void pidgin_style_adjust_contrast(GtkStyle *style, GdkColor *color) { if (pidgin_style_is_dark(style)) { gdouble r, g, b, h, s, v; r = ((gdouble) color->red) / 65535.0; g = ((gdouble) color->green) / 65535.0; b = ((gdouble) color->blue) / 65535.0; gtk_rgb_to_hsv(r, g, b, &h, &s, &v); v += 0.3; v = v > 1.0 ? 1.0 : v; s = 0.7; gtk_hsv_to_rgb(h, s, v, &r, &g, &b); color->red = (guint16) (r * 65535.0); color->green = (guint16) (g * 65535.0); color->blue = (guint16) (b * 65535.0); } }