pidgin/gtkwhiteboard.h@210f318db492
pidgin/gtkwhiteboard.h
Tue, 09 Jul 2024 02:03:20 -0500
- author
- Yoann Congal <yoann.congal@smile.fr>
- date
- Tue, 09 Jul 2024 02:03:20 -0500
- branch
- release-2.x.y
- changeset 42808
- 210f318db492
- parent 38089
- da90fe7312d3
- child 38240
- 0552f69f1996
- permissions
- -rw-r--r--
Fix incompatible pointer types for GtkItemFactoryCallbacks on gcc-14
The GtkItemFactoryEntry struct callback is of type GtkItemFactoryCallbacks
(aka void (*)(void)) but is initialised with GtkItemFactoryCallback1 types
(aka void (*)(void *, guint, GtkWidget *)).
This is coherent with the gtk-2 documentation:
> gtk_item_factory_create_items(..., GtkItemFactoryEntry *entries,...)
> entries : an array of GtkItemFactoryEntrys whose callback members must by of
> type GtkItemFactoryCallback1
But, under gcc-14, the implicit cast from GtkItemFactoryCallback1 to
GtkItemFactoryCallback triggers an incompatible-pointer-types error (See [gcc-doc]).
An exemple of this error:
pidgin/gtkconv.c:3096:66: error: initialization of 'void (*)(void)' from incompatible pointer type 'void (*)(void *, guint, GtkWidget *)' {aka 'void (*)(void *, unsigned int, struct _GtkWidget *)'} [-Wincompatible-pointer-types]
3096 | { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb,
| ^~~~~~~~~~~~~~~~
pidgin/gtkconv.c:3096:66: note: (near initialization for 'menu_items[1].callback')
To fix this, explicitely cast to GtkItemFactoryCallback where needed.
[0]: https://gcc.gnu.org/gcc-14/porting_to.html#incompatible-pointer-types
Testing Done:
Built with gcc-14, started and clicked on some affected menus
Reviewed at https://reviews.imfreedom.org/r/3282/
/** * @file gtkwhiteboard.h The PidginWhiteboard frontend object */ /* pidgin * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #ifndef _PIDGINWHITEBOARD_H_ #define _PIDGINWHITEBOARD_H_ #include "pidgin.h" #include "whiteboard.h" #define FULL_CIRCLE_DEGREES 23040 /* TODO: Make into an enum. */ #define BRUSH_STATE_UP 0 #define BRUSH_STATE_DOWN 1 #define BRUSH_STATE_MOTION 2 #define PALETTE_NUM_COLORS 7 /** * A PidginWhiteboard */ typedef struct _PidginWhiteboard { PurpleWhiteboard *wb; /**< backend data for this whiteboard */ GtkWidget *window; /**< Window for the Doodle session */ GtkWidget *drawing_area; /**< Drawing area */ GdkPixmap *pixmap; /**< Memory for drawing area */ int width; /**< Canvas width */ int height; /**< Canvas height */ int brush_color; /**< Foreground color */ int brush_size; /**< Brush size */ } PidginWhiteboard; #ifdef __cplusplus extern "C" { #endif /* __cplusplus */ /*****************************************************************************/ /** @name PidginWhiteboard API */ /*****************************************************************************/ /*@{*/ /** * Gets the GtkWhiteboard UI Operations. * * @return The GtkWhiteboard UI Operations. */ PurpleWhiteboardUiOps *pidgin_whiteboard_get_ui_ops( void ); /*@}*/ #ifdef __cplusplus } #endif /* __cplusplus */ #endif /* _PIDGINWHITEBOARD_H_ */
