pidgin/pidgin.h@210f318db492
pidgin/pidgin.h
Tue, 09 Jul 2024 02:03:20 -0500
- author
- Yoann Congal <yoann.congal@smile.fr>
- date
- Tue, 09 Jul 2024 02:03:20 -0500
- branch
- release-2.x.y
- changeset 42808
- 210f318db492
- parent 40859
- 2ff89178eb3d
- permissions
- -rw-r--r--
Fix incompatible pointer types for GtkItemFactoryCallbacks on gcc-14
The GtkItemFactoryEntry struct callback is of type GtkItemFactoryCallbacks
(aka void (*)(void)) but is initialised with GtkItemFactoryCallback1 types
(aka void (*)(void *, guint, GtkWidget *)).
This is coherent with the gtk-2 documentation:
> gtk_item_factory_create_items(..., GtkItemFactoryEntry *entries,...)
> entries : an array of GtkItemFactoryEntrys whose callback members must by of
> type GtkItemFactoryCallback1
But, under gcc-14, the implicit cast from GtkItemFactoryCallback1 to
GtkItemFactoryCallback triggers an incompatible-pointer-types error (See [gcc-doc]).
An exemple of this error:
pidgin/gtkconv.c:3096:66: error: initialization of 'void (*)(void)' from incompatible pointer type 'void (*)(void *, guint, GtkWidget *)' {aka 'void (*)(void *, unsigned int, struct _GtkWidget *)'} [-Wincompatible-pointer-types]
3096 | { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb,
| ^~~~~~~~~~~~~~~~
pidgin/gtkconv.c:3096:66: note: (near initialization for 'menu_items[1].callback')
To fix this, explicitely cast to GtkItemFactoryCallback where needed.
[0]: https://gcc.gnu.org/gcc-14/porting_to.html#incompatible-pointer-types
Testing Done:
Built with gcc-14, started and clicked on some affected menus
Reviewed at https://reviews.imfreedom.org/r/3282/
/** * @file pidgin.h UI definitions and includes * @ingroup pidgin */ /* pidgin * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ /* #warning ***pidgin*** */ #ifndef _PIDGIN_H_ #define _PIDGIN_H_ #include <gtk/gtk.h> #ifdef GDK_WINDOWING_X11 # include <gdk/gdkx.h> #endif #ifdef _WIN32 # include "win32/gtkwin32dep.h" #endif /** * Our UI's identifier. */ /* leave this as gtk-gaim until we have a decent way to migrate UI-prefs */ #define PIDGIN_UI "gtk-gaim" /* change this only when we have a sane upgrade path for old prefs */ #define PIDGIN_PREFS_ROOT "/pidgin" /* Translators may want to transliterate the name. It is not to be translated. */ #define PIDGIN_NAME _("Pidgin") #ifndef _WIN32 # define PIDGIN_ALERT_TITLE "" #else # define PIDGIN_ALERT_TITLE PIDGIN_NAME #endif /* * Spacings between components, as defined by the * GNOME Human Interface Guidelines. */ #define PIDGIN_HIG_CAT_SPACE 18 #define PIDGIN_HIG_BORDER 12 #define PIDGIN_HIG_BOX_SPACE 6 #if !GTK_CHECK_VERSION(2,16,0) || !defined(PIDGIN_DISABLE_DEPRECATED) /* * Older versions of GNOME defaulted to using an asterisk as the invisible * character. But this is ugly and we want to use something nicer. * * The default invisible character was changed in GNOME revision 21446 * (GTK+ 2.16) from an asterisk to the first available character out of * 0x25cf, 0x2022, 0x2731, 0x273a. See GNOME bugs 83935 and 307304 for * discussion leading up to the change. * * Here's the change: * http://svn.gnome.org/viewvc/gtk%2B?view=revision&revision=21446 * */ #define PIDGIN_INVISIBLE_CHAR (gunichar)0x25cf #endif /* Less than GTK+ 2.16 */ #endif /* _PIDGIN_H_ */
