Mon, 05 Aug 2024 23:32:59 -0500
Use the subtitle property instead of data when displaying notifications
Testing Done:
Created a generic notification with no data and set the subtitle instead.
Reviewed at https://reviews.imfreedom.org/r/3346/
/* * Pidgin - Internet Messenger * Copyright (C) Pidgin Developers <devel@pidgin.im> * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, see <https://www.gnu.org/licenses/>. */ #include <glib/gi18n-lib.h> #include <purple.h> #include "pidgin/pidginnotificationlist.h" #include "pidgin/pidginnotifiable.h" #include "pidgin/pidginnotificationaddcontact.h" #include "pidgin/pidginnotificationauthorizationrequest.h" #include "pidgin/pidginnotificationconnectionerror.h" enum { PROP_0, N_PROPERTIES, /* Overrides */ PROP_NEEDS_ATTENTION = N_PROPERTIES, PROP_NOTIFICATION_COUNT, }; /* There's no global properties because we only have overrides right now. */ struct _PidginNotificationList { GtkBox parent; GtkStack *stack; GtkSingleSelection *selection_model; }; /****************************************************************************** * Helpers *****************************************************************************/ static GtkWidget * pidgin_notification_list_unknown_notification(PurpleNotification *notification) { GtkWidget *widget = NULL; gchar *label = NULL; const gchar *title = NULL; title = purple_notification_get_title(notification); if(title != NULL) { label = g_strdup_printf(_("Unknown notification type %d: %s"), purple_notification_get_notification_type(notification), title); } else { label = g_strdup_printf(_("Unknown notification type %d"), purple_notification_get_notification_type(notification)); } widget = gtk_label_new(label); g_free(label); return widget; } static GtkWidget * pidgin_notification_generic_new(PurpleNotification *notification) { GtkWidget *row = NULL; GtkWidget *icon = NULL; icon = gtk_image_new(); gtk_image_set_icon_size(GTK_IMAGE(icon), GTK_ICON_SIZE_LARGE); g_object_bind_property(notification, "icon-name", icon, "icon-name", G_BINDING_SYNC_CREATE); row = adw_action_row_new(); adw_action_row_add_prefix(ADW_ACTION_ROW(row), icon); g_object_bind_property(notification, "title", row, "title", G_BINDING_SYNC_CREATE); g_object_bind_property(notification, "subtitle", row, "subtitle", G_BINDING_SYNC_CREATE); return row; } static guint pidgin_notification_list_get_count(PidginNotificationList *list) { g_return_val_if_fail(PIDGIN_IS_NOTIFICATION_LIST(list), 0); return g_list_model_get_n_items(G_LIST_MODEL(list->selection_model)); } static gboolean pidgin_notification_list_get_needs_attention(PidginNotificationList *list) { guint count = 0; g_return_val_if_fail(PIDGIN_IS_NOTIFICATION_LIST(list), FALSE); count = g_list_model_get_n_items(G_LIST_MODEL(list->selection_model)); return (count > 0); } /****************************************************************************** * Callbacks *****************************************************************************/ static void pidgin_notification_list_items_changed_cb(GListModel *model, G_GNUC_UNUSED guint position, G_GNUC_UNUSED guint added, G_GNUC_UNUSED guint removed, gpointer data) { PidginNotificationList *list = data; GObject *obj = G_OBJECT(list); if(g_list_model_get_n_items(model) != 0) { gtk_stack_set_visible_child_name(list->stack, "view"); } else { gtk_stack_set_visible_child_name(list->stack, "placeholder"); } g_object_freeze_notify(obj); g_object_notify(obj, "needs-attention"); g_object_notify(obj, "notification-count"); g_object_thaw_notify(obj); } static void pidgin_notification_list_bind_cb(G_GNUC_UNUSED GtkSignalListItemFactory *self, GObject *object, G_GNUC_UNUSED gpointer data) { PurpleNotification *notification = NULL; GtkListItem *item = GTK_LIST_ITEM(object); GtkWidget *widget = NULL; notification = gtk_list_item_get_item(item); switch(purple_notification_get_notification_type(notification)) { case PURPLE_NOTIFICATION_TYPE_GENERIC: widget = pidgin_notification_generic_new(notification); break; case PURPLE_NOTIFICATION_TYPE_CONNECTION_ERROR: widget = pidgin_notification_connection_error_new(notification); break; case PURPLE_NOTIFICATION_TYPE_AUTHORIZATION_REQUEST: widget = pidgin_notification_authorization_request_new(notification); break; case PURPLE_NOTIFICATION_TYPE_ADD_CONTACT: widget = pidgin_notification_add_contact_new(notification); break; default: widget = pidgin_notification_list_unknown_notification(notification); break; } if(!GTK_IS_WIDGET(widget)) { widget = pidgin_notification_list_unknown_notification(notification); } gtk_list_item_set_child(item, widget); } /****************************************************************************** * PidginNotifiable Implementation *****************************************************************************/ static void pidgin_notification_list_notifiable_init(G_GNUC_UNUSED PidginNotifiableInterface *iface) { } /****************************************************************************** * GObject Implementation *****************************************************************************/ G_DEFINE_FINAL_TYPE_WITH_CODE( PidginNotificationList, pidgin_notification_list, GTK_TYPE_BOX, G_IMPLEMENT_INTERFACE(PIDGIN_TYPE_NOTIFIABLE, pidgin_notification_list_notifiable_init)) static void pidgin_notification_list_get_property(GObject *obj, guint param_id, GValue *value, GParamSpec *pspec) { PidginNotificationList *list = PIDGIN_NOTIFICATION_LIST(obj); switch(param_id) { case PROP_NEEDS_ATTENTION: g_value_set_boolean(value, pidgin_notification_list_get_needs_attention(list)); break; case PROP_NOTIFICATION_COUNT: g_value_set_uint(value, pidgin_notification_list_get_count(list)); break; default: G_OBJECT_WARN_INVALID_PROPERTY_ID(obj, param_id, pspec); break; } } static void pidgin_notification_list_init(PidginNotificationList *list) { GListModel *model = NULL; gtk_widget_init_template(GTK_WIDGET(list)); model = purple_notification_manager_get_default_as_model(); gtk_single_selection_set_model(list->selection_model, model); g_signal_connect(model, "items-changed", G_CALLBACK(pidgin_notification_list_items_changed_cb), list); pidgin_notification_list_items_changed_cb(model, 0, 0, 0, list); } static void pidgin_notification_list_class_init(PidginNotificationListClass *klass) { GObjectClass *obj_class = G_OBJECT_CLASS(klass); GtkWidgetClass *widget_class = GTK_WIDGET_CLASS(klass); obj_class->get_property = pidgin_notification_list_get_property; g_object_class_override_property(obj_class, PROP_NEEDS_ATTENTION, "needs-attention"); g_object_class_override_property(obj_class, PROP_NOTIFICATION_COUNT, "notification-count"); gtk_widget_class_set_template_from_resource( widget_class, "/im/pidgin/Pidgin3/notificationlist.ui" ); gtk_widget_class_bind_template_child(widget_class, PidginNotificationList, stack); gtk_widget_class_bind_template_child(widget_class, PidginNotificationList, selection_model); gtk_widget_class_bind_template_callback(widget_class, pidgin_notification_list_bind_cb); } /****************************************************************************** * API *****************************************************************************/ GtkWidget * pidgin_notification_list_new(void) { return g_object_new(PIDGIN_TYPE_NOTIFICATION_LIST, NULL); }