Thu, 16 Mar 2023 22:36:19 -0500
Embed PidginAccountEditor into PidginAccountManager
The account manager now uses a stack to switch between a single editor instance
and the list of accounts. The save button from the editor got moved next to the
new back button, but we should probably prompt or throw up an info box when the
user starts making changes or prompt before moving back.
Also, the app.edit-account action now will lose any changes to an account that
is currently being edited, which we should disallow from happening in the future
as well.
Testing Done:
Opened the account manager and selected accounts and moved backed and saved accounts and made sure everything there worked.
Opened the account editor from a connection error notification and verified that opened properly as well.
Reviewed at https://reviews.imfreedom.org/r/2333/
/* * Pidgin - Internet Messenger * Copyright (C) Pidgin Developers <devel@pidgin.im> * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, see <https://www.gnu.org/licenses/>. */ #if !defined(PIDGIN_GLOBAL_HEADER_INSIDE) && !defined(PIDGIN_COMPILATION) # error "only <pidgin.h> may be included directly" #endif #ifndef PIDGIN_ACCOUNT_MANAGER_H #define PIDGIN_ACCOUNT_MANAGER_H #include <gtk/gtk.h> G_BEGIN_DECLS /** * PidginAccountManager: * * A singleton dialog for managing accounts. * * Since: 3.0.0 */ #define PIDGIN_TYPE_ACCOUNT_MANAGER (pidgin_account_manager_get_type()) G_DECLARE_FINAL_TYPE(PidginAccountManager, pidgin_account_manager, PIDGIN, ACCOUNT_MANAGER, GtkDialog) /** * pidgin_account_manager_new: * * Creates a new account manager dialog. * * Returns: (transfer full): The dialog. * * Since: 3.0.0 */ GtkWidget *pidgin_account_manager_new(void); /** * pidgin_account_managet_show_overview: * @manager: The instance. * * Switches @manager to the overview page. This is useful as @manager might * already be visible but editing an account. * * Since: 3.0.0 */ void pidgin_account_manager_show_overview(PidginAccountManager *manager); /** * pidgin_account_manager_edit_account: * @manager: The instance. * @account: The account to edit. * * Opens the account editor in @manager for the given account. * * Since: 3.0.0 */ void pidgin_account_manager_edit_account(PidginAccountManager *manager, PurpleAccount *account); G_END_DECLS #endif /* PIDGIN_ACCOUNT_MANAGER_H */