Mon, 29 Aug 2022 22:06:07 -0500
Move network preferences to Adwaita preference widgets
This does make the TURN server settings longer vertically, but that seems more consistent with everything.
Also fix the `leave` event on the TURN server setting.
Testing Done:
Toggled all the options and checked that stuff happened in the Debug Window.
Also, I'm not sure why the `GtkSpinButton` and `GtkEntry` expand to different sizes; they both have `hexpand=1`, and the spin button is next to text that's _shorter_ than the entry, but somehow ends up farther right. Seems like a bug in GTK.
PS, be careful of this page; it tries to get your public IP address and displays it when it succeeds.
Reviewed at https://reviews.imfreedom.org/r/1680/
/* * Pidgin - Internet Messenger * Copyright (C) Pidgin Developers <devel@pidgin.im> * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, see <https://www.gnu.org/licenses/>. */ #include <glib/gi18n-lib.h> #include <purple.h> #include <adwaita.h> #include <talkatu.h> #include "pidginconversationprefs.h" #include "pidgincore.h" #include "pidginprefsinternal.h" struct _PidginConversationPrefs { AdwPreferencesPage parent; GtkWidget *show_incoming_formatting; struct { GtkWidget *send_typing; } im; GtkWidget *use_smooth_scrolling; struct { GtkWidget *blink_im; } win32; GtkWidget *minimum_entry_lines; GtkTextBuffer *format_buffer; GtkWidget *format_view; }; G_DEFINE_TYPE(PidginConversationPrefs, pidgin_conversation_prefs, ADW_TYPE_PREFERENCES_PAGE) /****************************************************************************** * Helpers *****************************************************************************/ static void formatting_toggle_cb(TalkatuActionGroup *ag, GAction *action, const gchar *name, gpointer data) { gboolean activated = talkatu_action_group_get_action_activated(ag, name); if(g_ascii_strcasecmp(TALKATU_ACTION_FORMAT_BOLD, name) != 0) { purple_prefs_set_bool(PIDGIN_PREFS_ROOT "/conversations/send_bold", activated); } else if(g_ascii_strcasecmp(TALKATU_ACTION_FORMAT_ITALIC, name) != 0) { purple_prefs_set_bool(PIDGIN_PREFS_ROOT "/conversations/send_italic", activated); } else if(g_ascii_strcasecmp(TALKATU_ACTION_FORMAT_UNDERLINE, name) != 0) { purple_prefs_set_bool(PIDGIN_PREFS_ROOT "/conversations/send_underline", activated); } else if(g_ascii_strcasecmp(TALKATU_ACTION_FORMAT_STRIKETHROUGH, name) != 0) { purple_prefs_set_bool(PIDGIN_PREFS_ROOT "/conversations/send_strike", activated); } } /****************************************************************************** * GObject Implementation *****************************************************************************/ static void pidgin_conversation_prefs_class_init(PidginConversationPrefsClass *klass) { GtkWidgetClass *widget_class = GTK_WIDGET_CLASS(klass); gtk_widget_class_set_template_from_resource( widget_class, "/im/pidgin/Pidgin3/Prefs/conversation.ui" ); gtk_widget_class_bind_template_child( widget_class, PidginConversationPrefs, show_incoming_formatting); gtk_widget_class_bind_template_child( widget_class, PidginConversationPrefs, im.send_typing); gtk_widget_class_bind_template_child( widget_class, PidginConversationPrefs, use_smooth_scrolling); gtk_widget_class_bind_template_child( widget_class, PidginConversationPrefs, win32.blink_im); gtk_widget_class_bind_template_child( widget_class, PidginConversationPrefs, minimum_entry_lines); gtk_widget_class_bind_template_child( widget_class, PidginConversationPrefs, format_buffer); gtk_widget_class_bind_template_child( widget_class, PidginConversationPrefs, format_view); } static void pidgin_conversation_prefs_init(PidginConversationPrefs *prefs) { GSimpleActionGroup *ag = NULL; gtk_widget_init_template(GTK_WIDGET(prefs)); pidgin_prefs_bind_checkbox(PIDGIN_PREFS_ROOT "/conversations/show_incoming_formatting", prefs->show_incoming_formatting); pidgin_prefs_bind_checkbox("/purple/conversations/im/send_typing", prefs->im.send_typing); pidgin_prefs_bind_checkbox(PIDGIN_PREFS_ROOT "/conversations/use_smooth_scrolling", prefs->use_smooth_scrolling); #ifdef _WIN32 pidgin_prefs_bind_checkbox(PIDGIN_PREFS_ROOT "/win32/blink_im", prefs->win32.blink_im); #else gtk_widget_hide(prefs->win32.blink_im); #endif pidgin_prefs_bind_spin_button( PIDGIN_PREFS_ROOT "/conversations/minimum_entry_lines", prefs->minimum_entry_lines); ag = talkatu_buffer_get_action_group(TALKATU_BUFFER(prefs->format_buffer)); g_signal_connect_after(G_OBJECT(ag), "action-activated", G_CALLBACK(formatting_toggle_cb), NULL); } /****************************************************************************** * API *****************************************************************************/ GtkWidget * pidgin_conversation_prefs_new(void) { return GTK_WIDGET(g_object_new(PIDGIN_TYPE_CONVERSATION_PREFS, NULL)); }