pidgin/prefs/pidginnetworkprefs.c

Mon, 29 Aug 2022 22:06:07 -0500

author
Elliott Sales de Andrade <quantum.analyst@gmail.com>
date
Mon, 29 Aug 2022 22:06:07 -0500
changeset 41623
78cf94d0f8c8
parent 41618
7e9ad20d503a
child 41640
d8636f8db50a
permissions
-rw-r--r--

Move network preferences to Adwaita preference widgets

This does make the TURN server settings longer vertically, but that seems more consistent with everything.

Also fix the `leave` event on the TURN server setting.

Testing Done:
Toggled all the options and checked that stuff happened in the Debug Window.

Also, I'm not sure why the `GtkSpinButton` and `GtkEntry` expand to different sizes; they both have `hexpand=1`, and the spin button is next to text that's _shorter_ than the entry, but somehow ends up farther right. Seems like a bug in GTK.

PS, be careful of this page; it tries to get your public IP address and displays it when it succeeds.

Reviewed at https://reviews.imfreedom.org/r/1680/

/*
 * Pidgin - Internet Messenger
 * Copyright (C) Pidgin Developers <devel@pidgin.im>
 *
 * Pidgin is the legal property of its developers, whose names are too numerous
 * to list here.  Please refer to the COPYRIGHT file distributed with this
 * source distribution.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, see <https://www.gnu.org/licenses/>.
 */

#include <glib/gi18n-lib.h>

#include <purple.h>

#include <adwaita.h>
#include <nice.h>

#include "pidginnetworkprefs.h"
#include "pidginprefsinternal.h"

struct _PidginNetworkPrefs {
	AdwPreferencesPage parent;

	GtkWidget *stun_server;
	GtkWidget *auto_ip_row;
	GtkWidget *auto_ip;
	GtkWidget *public_ip;
	GtkWidget *public_ip_row;
	GtkWidget *map_ports;
	GtkWidget *ports_range_use;
	GtkWidget *ports_range_start;
	GtkWidget *ports_range_end;
	GtkWidget *turn_server;
	GtkWidget *turn_port_udp;
	GtkWidget *turn_port_tcp;
	GtkWidget *turn_username;
	GtkWidget *turn_password;
};

G_DEFINE_TYPE(PidginNetworkPrefs, pidgin_network_prefs,
              ADW_TYPE_PREFERENCES_PAGE)

/******************************************************************************
 * Helpers
 *****************************************************************************/
static void
network_ip_changed(GtkEditable *editable, gpointer data)
{
	const gchar *text = gtk_editable_get_text(editable);
	GtkWidget *widget = GTK_WIDGET(editable);

	if (text && *text) {
		if (g_hostname_is_ip_address(text)) {
			purple_network_set_public_ip(text);
			gtk_widget_remove_css_class(widget, "error");
			gtk_widget_add_css_class(widget, "success");
		} else {
			gtk_widget_remove_css_class(widget, "success");
			gtk_widget_add_css_class(widget, "error");
		}

	} else {
		purple_network_set_public_ip("");
		gtk_widget_remove_css_class(widget, "success");
		gtk_widget_remove_css_class(widget, "error");
	}
}

static void
network_stun_server_changed_cb(G_GNUC_UNUSED GtkEventControllerFocus *focus,
                               gpointer data)
{
	GtkEditable *editable = data;

	purple_prefs_set_string("/purple/network/stun_server",
	                        gtk_editable_get_text(editable));
	purple_network_set_stun_server(gtk_editable_get_text(editable));
}

static void
network_turn_server_changed_cb(G_GNUC_UNUSED GtkEventControllerFocus *focus,
                               gpointer data)
{
	GtkEditable *editable = data;

	purple_prefs_set_string("/purple/network/turn_server",
	                        gtk_editable_get_text(editable));
	purple_network_set_turn_server(gtk_editable_get_text(editable));
}

static void
auto_ip_button_clicked_cb(G_GNUC_UNUSED GObject *obj,
                          G_GNUC_UNUSED GParamSpec *pspec, gpointer data)
{
	PidginNetworkPrefs *prefs = PIDGIN_NETWORK_PREFS(data);
	const char *ip;
	PurpleStunNatDiscovery *stun;
	char *auto_ip_text;
	GList *list = NULL;

	/* Make a lookup for the auto-detected IP ourselves. */
	if (purple_prefs_get_bool("/purple/network/auto_ip")) {
		/* Check if STUN discovery was already done */
		stun = purple_stun_discover(NULL);
		if ((stun != NULL) && (stun->status == PURPLE_STUN_STATUS_DISCOVERED)) {
			ip = stun->publicip;
		} else {
			/* Attempt to get the IP from a NAT device using UPnP */
			ip = purple_upnp_get_public_ip();
			if (ip == NULL) {
				/* Attempt to get the IP from a NAT device using NAT-PMP */
				ip = purple_pmp_get_public_ip();
				if (ip == NULL) {
					/* Just fetch the first IP of the local system */
					list = nice_interfaces_get_local_ips(FALSE);
					if (list) {
						ip = list->data;
					} else {
						ip = "0.0.0.0";
					}
				}
			}
		}
	} else {
		ip = _("Disabled");
	}

	auto_ip_text = g_strdup_printf(_("Use _automatically detected IP address: %s"), ip);
	adw_preferences_row_set_title(ADW_PREFERENCES_ROW(prefs->auto_ip_row),
	                              auto_ip_text);
	g_free(auto_ip_text);
	g_list_free_full(list, g_free);
}

/******************************************************************************
 * GObject Implementation
 *****************************************************************************/
static void
pidgin_network_prefs_class_init(PidginNetworkPrefsClass *klass)
{
	GtkWidgetClass *widget_class = GTK_WIDGET_CLASS(klass);

	gtk_widget_class_set_template_from_resource(
		widget_class,
		"/im/pidgin/Pidgin3/Prefs/network.ui"
	);

	gtk_widget_class_bind_template_child(widget_class, PidginNetworkPrefs,
	                                     stun_server);
	gtk_widget_class_bind_template_child(widget_class, PidginNetworkPrefs,
	                                     auto_ip_row);
	gtk_widget_class_bind_template_child(widget_class, PidginNetworkPrefs,
	                                     auto_ip);
	gtk_widget_class_bind_template_child(widget_class, PidginNetworkPrefs,
	                                     public_ip);
	gtk_widget_class_bind_template_child(widget_class, PidginNetworkPrefs,
	                                     public_ip_row);
	gtk_widget_class_bind_template_child(widget_class, PidginNetworkPrefs,
	                                     map_ports);
	gtk_widget_class_bind_template_child(widget_class, PidginNetworkPrefs,
	                                     ports_range_use);
	gtk_widget_class_bind_template_child(widget_class, PidginNetworkPrefs,
	                                     ports_range_start);
	gtk_widget_class_bind_template_child(widget_class, PidginNetworkPrefs,
	                                     ports_range_end);
	gtk_widget_class_bind_template_child(widget_class, PidginNetworkPrefs,
	                                     turn_server);
	gtk_widget_class_bind_template_child(widget_class, PidginNetworkPrefs,
	                                     turn_port_udp);
	gtk_widget_class_bind_template_child(widget_class, PidginNetworkPrefs,
	                                     turn_port_tcp);
	gtk_widget_class_bind_template_child(widget_class, PidginNetworkPrefs,
	                                     turn_username);
	gtk_widget_class_bind_template_child(widget_class, PidginNetworkPrefs,
	                                     turn_password);
	gtk_widget_class_bind_template_callback(widget_class,
	                                        network_stun_server_changed_cb);
	gtk_widget_class_bind_template_callback(widget_class,
	                                        auto_ip_button_clicked_cb);
	gtk_widget_class_bind_template_callback(widget_class, network_ip_changed);
	gtk_widget_class_bind_template_callback(widget_class,
	                                        network_turn_server_changed_cb);
}

static void
pidgin_network_prefs_init(PidginNetworkPrefs *prefs)
{
	gtk_widget_init_template(GTK_WIDGET(prefs));

	gtk_editable_set_text(GTK_EDITABLE(prefs->stun_server),
	                      purple_prefs_get_string("/purple/network/stun_server"));

	pidgin_prefs_bind_switch("/purple/network/auto_ip", prefs->auto_ip);
	auto_ip_button_clicked_cb(NULL, NULL, prefs); /* Update label */

	gtk_editable_set_text(GTK_EDITABLE(prefs->public_ip),
	                      purple_network_get_public_ip());

	g_object_bind_property(prefs->auto_ip, "active",
	                       prefs->public_ip_row, "sensitive",
	                       G_BINDING_SYNC_CREATE|G_BINDING_INVERT_BOOLEAN);

	pidgin_prefs_bind_switch("/purple/network/map_ports", prefs->map_ports);

	pidgin_prefs_bind_expander_row("/purple/network/ports_range_use",
	                               prefs->ports_range_use);

	pidgin_prefs_bind_spin_button("/purple/network/ports_range_start",
			prefs->ports_range_start);
	pidgin_prefs_bind_spin_button("/purple/network/ports_range_end",
			prefs->ports_range_end);

	/* TURN server */
	gtk_editable_set_text(GTK_EDITABLE(prefs->turn_server),
	                      purple_prefs_get_string("/purple/network/turn_server"));

	pidgin_prefs_bind_spin_button("/purple/network/turn_port",
			prefs->turn_port_udp);

	pidgin_prefs_bind_spin_button("/purple/network/turn_port_tcp",
			prefs->turn_port_tcp);

	pidgin_prefs_bind_entry("/purple/network/turn_username",
			prefs->turn_username);
	pidgin_prefs_bind_entry("/purple/network/turn_password",
			prefs->turn_password);
}

/******************************************************************************
 * API
 *****************************************************************************/
GtkWidget *
pidgin_network_prefs_new(void) {
	return GTK_WIDGET(g_object_new(PIDGIN_TYPE_NETWORK_PREFS, NULL));
}

mercurial