Wed, 21 Dec 2005 18:36:19 +0000
[gaim-migrate @ 14934]
Enable the extra warnings regardless of --enable-debug.
Enable FORTIFY_SOURCE regardless of --enable-debug, adding a --disable-fortify flag to configure.
Enable (well, stop disabling) the missing initializer warnings.
This leads to warnings with: GValue v = {0,}; that must be worked around.
Basically, instead of:
GValue v = {0,};
...
g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */
We'd need to do:
GValue v;
...
v.g_type = 0;
g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */
Fix several cases of missing initializers. I don't think any of these are bugs, but having this warning seems like a good idea. It might prevent us from making a mistake in the future.
While I was fixing missing initializers, I optimized substitute_simple_word in plugins/spellchk.c, in the same way as I did substitute_word before. Yes, I'm bad for committing these together.
Added a --enable-fatal-asserts flag to configure. As the name implies, this makes g_return_... guards fatal. This is a useful flag to run on a debug copy of Gaim. It will make it very clear if your changes have triggered one of these guards. It's also useful in detecting g_return_... abuse, which helps prevent crashes if Gaim is compiled with G_DISABLE_ASSERT defined.
/** * @file debug.c Debug API * @ingroup core * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "debug.h" #include "internal.h" #include "prefs.h" static GaimDebugUiOps *debug_ui_ops = NULL; /* * This determines whether debug info should be written to the * console or not. * * It doesn't make sense to make this a normal Gaim preference * because it's a command line option. This will always be FALSE, * unless the user explicitly started Gaim with the -d flag. * It doesn't matter what this value was the last time Gaim was * started, so it doesn't make sense to save it in prefs. */ static gboolean debug_enabled = FALSE; static void gaim_debug_vargs(GaimDebugLevel level, const char *category, const char *format, va_list args) { GaimDebugUiOps *ops; g_return_if_fail(level != GAIM_DEBUG_ALL); g_return_if_fail(format != NULL); if (debug_enabled) { gchar *arg_s, *ts_s; arg_s = g_strdup_vprintf(format, args); if ((category != NULL) && (gaim_prefs_exists("/core/debug/timestamps")) && (gaim_prefs_get_bool("/core/debug/timestamps"))) { gchar mdate[64]; time_t mtime = time(NULL); strftime(mdate, sizeof(mdate), "%H:%M:%S", localtime(&mtime)); ts_s = g_strdup_printf("(%s) ", mdate); } else { ts_s = g_strdup(""); } if (category == NULL) g_print("%s%s", ts_s, arg_s); else g_print("%s%s: %s", ts_s, category, arg_s); g_free(arg_s); g_free(ts_s); } ops = gaim_debug_get_ui_ops(); if (ops != NULL && ops->print != NULL) ops->print(level, category, format, args); } void gaim_debug(GaimDebugLevel level, const char *category, const char *format, ...) { va_list args; g_return_if_fail(level != GAIM_DEBUG_ALL); g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(level, category, format, args); va_end(args); } void gaim_debug_misc(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_MISC, category, format, args); va_end(args); } void gaim_debug_info(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_INFO, category, format, args); va_end(args); } void gaim_debug_warning(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_WARNING, category, format, args); va_end(args); } void gaim_debug_error(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_ERROR, category, format, args); va_end(args); } void gaim_debug_fatal(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_FATAL, category, format, args); va_end(args); } void gaim_debug_set_enabled(gboolean enabled) { debug_enabled = enabled; } gboolean gaim_debug_is_enabled() { return debug_enabled; } void gaim_debug_set_ui_ops(GaimDebugUiOps *ops) { debug_ui_ops = ops; } GaimDebugUiOps * gaim_debug_get_ui_ops(void) { return debug_ui_ops; } void gaim_debug_init(void) { gaim_prefs_add_none("/core/debug"); /* * This pref is currently used by both the console * output and the debug window output. */ gaim_prefs_add_bool("/core/debug/timestamps", FALSE); }