Mercurial > pidgin3 / file revision

• file
• latest
• revisions
• annotate
• diff
• comparison
• raw

src/protocols/jabber/jutil.h@7ecd4441fdc7

src/protocols/jabber/jutil.h

Wed, 21 Dec 2005 18:36:19 +0000

author

Richard Laager <rlaager@pidgin.im>

date

Wed, 21 Dec 2005 18:36:19 +0000

changeset 12600

7ecd4441fdc7

parent 9954

52a14a58a33e

permissions

-rw-r--r--

[gaim-migrate @ 14934]
Enable the extra warnings regardless of --enable-debug.

Enable FORTIFY_SOURCE regardless of --enable-debug, adding a --disable-fortify flag to configure.

Enable (well, stop disabling) the missing initializer warnings.
This leads to warnings with: GValue v = {0,}; that must be worked around.
Basically, instead of:
GValue v = {0,};
...
g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */
We'd need to do:
GValue v;
...
v.g_type = 0;
g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */

Fix several cases of missing initializers. I don't think any of these are bugs, but having this warning seems like a good idea. It might prevent us from making a mistake in the future.

While I was fixing missing initializers, I optimized substitute_simple_word in plugins/spellchk.c, in the same way as I did substitute_word before. Yes, I'm bad for committing these together.

Added a --enable-fatal-asserts flag to configure. As the name implies, this makes g_return_... guards fatal. This is a useful flag to run on a debug copy of Gaim. It will make it very clear if your changes have triggered one of these guards. It's also useful in detecting g_return_... abuse, which helps prevent crashes if Gaim is compiled with G_DISABLE_ASSERT defined.

/**
 * @file jutil.h utility functions
 *
 * gaim
 *
 * Copyright (C) 2003 Nathan Walp <faceprint@faceprint.com>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 */
#ifndef _GAIM_JABBER_JUTIL_H_
#define _GAIM_JABBER_JUTIL_H_

#include "account.h"
#include "conversation.h"
#include "xmlnode.h"


typedef struct _JabberID {
	char *node;
	char *domain;
	char *resource;
} JabberID;

JabberID* jabber_id_new(const char *str);
void jabber_id_free(JabberID *jid);

char *jabber_get_resource(const char *jid);
char *jabber_get_bare_jid(const char *jid);

const char *jabber_normalize(const GaimAccount *account, const char *in);

gboolean jabber_nodeprep_validate(const char *);
gboolean jabber_nameprep_validate(const char *);
gboolean jabber_resourceprep_validate(const char *);

GaimConversation *jabber_find_unnormalized_conv(const char *name, GaimAccount *account);

#endif /* _GAIM_JABBER_JUTIL_H_ */