PLUGIN_HOWTO@82f6b5267eac
PLUGIN_HOWTO
Fri, 15 Apr 2022 13:21:50 -0500
- author
- Belgin Știrbu <belginstirbu@hotmail.com>
- date
- Fri, 15 Apr 2022 13:21:50 -0500
- branch
- release-2.x.y
- changeset 41327
- 82f6b5267eac
- parent 28289
- ae4cf144214c
- child 33955
- 55aa58076485
- permissions
- -rw-r--r--
Fix file transfers failing at 99% over IRC
File transfers over IRC sometimes failed because the sender `close()`d the socket before reading everything from it, resulting in a TCP RST packet being sent, which was interpreted by the receiver as a problem with the connection, sometimes dropping the last few bytes of the file as a result.
This patch reads everything from the socket before closing, thus avoiding the RST packet issue.
Testing Done:
Tested on Windows, Linux, Windows-to-Linux and vice-versa IRC file transfers.
Bugs closed: PIDGIN-15893
Reviewed at https://reviews.imfreedom.org/r/1385/
For information on writing a plugin for Purple, Pidgin or Finch, go http://developer.pidgin.im and click on API. From there, see the HOWTOs in the "Related Pages" section. You can also generate this documentation locally by installing doxygen and graphviz dot, then running "make docs" in the source tree. The documentation will be in the docs/html directory.
