Fri, 15 Apr 2022 13:21:50 -0500
Fix file transfers failing at 99% over IRC
File transfers over IRC sometimes failed because the sender `close()`d the socket before reading everything from it, resulting in a TCP RST packet being sent, which was interpreted by the receiver as a problem with the connection, sometimes dropping the last few bytes of the file as a result.
This patch reads everything from the socket before closing, thus avoiding the RST packet issue.
Testing Done:
Tested on Windows, Linux, Windows-to-Linux and vice-versa IRC file transfers.
Bugs closed: PIDGIN-15893
Reviewed at https://reviews.imfreedom.org/r/1385/
/** * @file gtkaccount.h GTK+ Account Editor UI * @ingroup pidgin * @see @ref gtkaccount-signals */ /* pidgin * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #ifndef _PIDGINACCOUNT_H_ #define _PIDGINACCOUNT_H_ #include "account.h" typedef enum { PIDGIN_ADD_ACCOUNT_DIALOG, PIDGIN_MODIFY_ACCOUNT_DIALOG } PidginAccountDialogType; /** * Shows the accounts window. */ void pidgin_accounts_window_show(void); /** * Hides the accounts window. */ void pidgin_accounts_window_hide(void); /** * Shows an add/modify account dialog. * * @param type The type of dialog. * @param account The associated account, or @c NULL for an Add dialog. */ void pidgin_account_dialog_show(PidginAccountDialogType type, PurpleAccount *account); /** * Returns the GTK+ account UI ops * * @return The UI operations structure. */ PurpleAccountUiOps *pidgin_accounts_get_ui_ops(void); /** * Returns the gtkaccounts handle * * @return The handle to the GTK+ account system */ void *pidgin_account_get_handle(void); /** * Initializes the GTK+ account system */ void pidgin_account_init(void); /** * Uninitializes the GTK+ account system */ void pidgin_account_uninit(void); #endif /* _PIDGINACCOUNT_H_ */