pidgin/gtkrequest.h@82f6b5267eac
pidgin/gtkrequest.h
Fri, 15 Apr 2022 13:21:50 -0500
- author
- Belgin Știrbu <belginstirbu@hotmail.com>
- date
- Fri, 15 Apr 2022 13:21:50 -0500
- branch
- release-2.x.y
- changeset 41327
- 82f6b5267eac
- parent 20147
- 66f05a854eee
- child 32790
- b95c7c504118
- permissions
- -rw-r--r--
Fix file transfers failing at 99% over IRC
File transfers over IRC sometimes failed because the sender `close()`d the socket before reading everything from it, resulting in a TCP RST packet being sent, which was interpreted by the receiver as a problem with the connection, sometimes dropping the last few bytes of the file as a result.
This patch reads everything from the socket before closing, thus avoiding the RST packet issue.
Testing Done:
Tested on Windows, Linux, Windows-to-Linux and vice-versa IRC file transfers.
Bugs closed: PIDGIN-15893
Reviewed at https://reviews.imfreedom.org/r/1385/
/** * @file gtkrequest.h GTK+ Request API * @ingroup pidgin */ /* pidgin * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #ifndef _PIDGINREQUEST_H_ #define _PIDGINREQUEST_H_ #include "request.h" /** * Returns the UI operations structure for GTK+ request functions. * * @return The GTK+ UI request operations structure. */ PurpleRequestUiOps *pidgin_request_get_ui_ops(void); #endif /* _PIDGINREQUEST_H_ */
