libpurple/tests/test_xmlnode.c

Mon, 18 Feb 2013 23:44:29 -0500

author
Daniel Atallah <datallah@pidgin.im>
date
Mon, 18 Feb 2013 23:44:29 -0500
branch
release-2.x.y
changeset 33769
96f89e35d24d
parent 31891
186f61a85ac2
child 32321
ae17a89ef666
child 32438
dc8991868906
permissions
-rw-r--r--

Fix various "Dereference before null check" issues

* Nothing problematic, just unnecessary NULL checks

#include <string.h>

#include "tests.h"
#include "../xmlnode.h"

/*
 * If we really wanted to test the billion laughs attack we would
 * need to have more than just 4 ha's.  But as long as this shorter
 * document fails to parse, the longer one should also fail to parse.
 */
START_TEST(test_xmlnode_billion_laughs_attack)
{
	const char *malicious_xml_doc = "<!DOCTYPE root [ <!ENTITY ha \"Ha !\"><!ENTITY ha2 \"&ha; &ha;\"><!ENTITY ha3 \"&ha2; &ha2;\"> ]><root>&ha3;</root>";

	/* Uncomment this line if you want to see the error message given by
	   the parser for the above XML document */
	/* purple_debug_set_enabled(TRUE); */

	fail_if(xmlnode_from_str(malicious_xml_doc, -1),
			"xmlnode_from_str() returned an XML tree, but we didn't want it to");
}
END_TEST

Suite *
xmlnode_suite(void)
{
	Suite *s = suite_create("Utility Functions");

	TCase *tc = tcase_create("xmlnode");
	tcase_add_test(tc, test_xmlnode_billion_laughs_attack);
	suite_add_tcase(s, tc);

	return s;
}

mercurial