Mon, 21 Aug 2006 22:50:58 +0000
[gaim-migrate @ 16963]
Fix a crazy bug that we found at meebo. I'm not sure it
affects gtk Gaim in quite the same way, but what was
happeing is that the conversation sequence number should
be incremented by 1 each time a new conversation is
created (whether created by someone else or created by
you). However, in one place in Gaim conv_seq was being
incremented BEFORE it was used and in another it was
being incremented AFTER it was used. This can lead to
a sequence number being used twice.
/** * @file command.c MSN command functions * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "msn.h" #include "command.h" static gboolean is_num(char *str) { char *c; for (c = str; *c; c++) { if (!(g_ascii_isdigit(*c))) return FALSE; } return TRUE; } MsnCommand * msn_command_from_string(const char *string) { MsnCommand *cmd; char *tmp; char *param_start; g_return_val_if_fail(string != NULL, NULL); tmp = g_strdup(string); param_start = strchr(tmp, ' '); cmd = g_new0(MsnCommand, 1); cmd->command = tmp; if (param_start) { char *param; int c; *param_start++ = '\0'; cmd->params = g_strsplit(param_start, " ", 0); for (c = 0; cmd->params[c]; c++); cmd->param_count = c; param = cmd->params[0]; cmd->trId = is_num(param) ? atoi(param) : 0; } else cmd->trId = 0; msn_command_ref(cmd); return cmd; } void msn_command_destroy(MsnCommand *cmd) { g_return_if_fail(cmd != NULL); if (cmd->ref_count > 0) { msn_command_unref(cmd); return; } if (cmd->payload != NULL) g_free(cmd->payload); g_free(cmd->command); g_strfreev(cmd->params); g_free(cmd); } MsnCommand * msn_command_ref(MsnCommand *cmd) { g_return_val_if_fail(cmd != NULL, NULL); cmd->ref_count++; return cmd; } MsnCommand * msn_command_unref(MsnCommand *cmd) { g_return_val_if_fail(cmd != NULL, NULL); g_return_val_if_fail(cmd->ref_count > 0, NULL); cmd->ref_count--; if (cmd->ref_count == 0) { msn_command_destroy(cmd); return NULL; } return cmd; }