Mon, 28 Feb 2011 07:12:27 +0000
Fix a memleak in the MSN prpl when removing a buddy from your buddy list.
We needed to call msn_user_unref() after calling msn_userlist_remove_user()
I chose to fix this by changing msn_userlist_add_user() and
msn_userlist_remove_user() to incremend and decrement the reference counter
themselves--after all, they ARE the ones who add/remove a reference to
the MsnUser struct. Conceptually I thought this made the most sense.
/* This file is part of the Project Athena Zephyr Notification System. * It contains source for the ZCheckIfNotice function. * * Created by: Robert French * * Copyright (c) 1987,1988 by the Massachusetts Institute of Technology. * For copying and distribution information, see the file * "mit-copyright.h". */ #include "internal.h" Code_t ZCheckIfNotice(notice, from, predicate, args) ZNotice_t *notice; struct sockaddr_in *from; register int (*predicate) __P((ZNotice_t *, void *)); void *args; { ZNotice_t tmpnotice; Code_t retval; register char *buffer; register struct _Z_InputQ *qptr; if ((retval = Z_ReadEnqueue()) != ZERR_NONE) return (retval); qptr = Z_GetFirstComplete(); while (qptr) { if ((retval = ZParseNotice(qptr->packet, qptr->packet_len, &tmpnotice)) != ZERR_NONE) return (retval); if ((*predicate)(&tmpnotice, args)) { if (!(buffer = (char *) malloc((unsigned) qptr->packet_len))) return (ENOMEM); (void) memcpy(buffer, qptr->packet, qptr->packet_len); if (from) *from = qptr->from; if ((retval = ZParseNotice(buffer, qptr->packet_len, notice)) != ZERR_NONE) { free(buffer); return (retval); } Z_RemQueue(qptr); return (ZERR_NONE); } qptr = Z_GetNextComplete(qptr); } return (ZERR_NONOTICE); }