Mon, 28 Feb 2011 07:12:27 +0000
Fix a memleak in the MSN prpl when removing a buddy from your buddy list.
We needed to call msn_user_unref() after calling msn_userlist_remove_user()
I chose to fix this by changing msn_userlist_add_user() and
msn_userlist_remove_user() to incremend and decrement the reference counter
themselves--after all, they ARE the ones who add/remove a reference to
the MsnUser struct. Conceptually I thought this made the most sense.
/* This file is part of the Project Athena Zephyr Notification System. * It contains source for the ZFormatNotice function. * * Created by: Robert French * * Copyright (c) 1987,1988 by the Massachusetts Institute of Technology. * For copying and distribution information, see the file * "mit-copyright.h". */ #include "internal.h" Code_t ZFormatNotice(notice, buffer, ret_len, cert_routine) register ZNotice_t *notice; char **buffer; int *ret_len; Z_AuthProc cert_routine; { char header[Z_MAXHEADERLEN]; int hdrlen; Code_t retval; if ((retval = Z_FormatHeader(notice, header, sizeof(header), &hdrlen, cert_routine)) != ZERR_NONE) return (retval); *ret_len = hdrlen+notice->z_message_len; /* Length can never be zero, don't have to worry about malloc(0). */ if (!(*buffer = (char *) malloc((unsigned)*ret_len))) return (ENOMEM); (void) memcpy(*buffer, header, hdrlen); (void) memcpy(*buffer+hdrlen, notice->z_message, notice->z_message_len); return (ZERR_NONE); }