Mon, 28 Feb 2011 07:12:27 +0000
Fix a memleak in the MSN prpl when removing a buddy from your buddy list.
We needed to call msn_user_unref() after calling msn_userlist_remove_user()
I chose to fix this by changing msn_userlist_add_user() and
msn_userlist_remove_user() to incremend and decrement the reference counter
themselves--after all, they ARE the ones who add/remove a reference to
the MsnUser struct. Conceptually I thought this made the most sense.
/* This file is part of the Project Athena Zephyr Notification System. * It contains source for the ZFormatSmallRawNoticeList function. * * Created by: John T. Kohl * * Copyright (c) 1988 by the Massachusetts Institute of Technology. * For copying and distribution information, see the file * "mit-copyright.h". */ #include "internal.h" #if 0 Code_t ZFormatSmallRawNoticeList(notice, list, nitems, buffer, ret_len) ZNotice_t *notice; char *list[]; int nitems; ZPacket_t buffer; int *ret_len; { Code_t retval; int hdrlen, i, size; char *ptr; if ((retval = Z_FormatRawHeader(notice, buffer, Z_MAXHEADERLEN, &hdrlen, NULL, NULL)) != ZERR_NONE) return (retval); size = 0; for (i=0;i<nitems;i++) size += strlen(list[i])+1; *ret_len = hdrlen+size; if (*ret_len > Z_MAXPKTLEN) return (ZERR_PKTLEN); ptr = buffer+hdrlen; for (;nitems;nitems--, list++) { i = strlen(*list)+1; (void) memcpy(ptr, *list, i); ptr += i; } return (ZERR_NONE); } #endif