Mon, 28 Feb 2011 07:12:27 +0000
Fix a memleak in the MSN prpl when removing a buddy from your buddy list.
We needed to call msn_user_unref() after calling msn_userlist_remove_user()
I chose to fix this by changing msn_userlist_add_user() and
msn_userlist_remove_user() to incremend and decrement the reference counter
themselves--after all, they ARE the ones who add/remove a reference to
the MsnUser struct. Conceptually I thought this made the most sense.
/* This file is part of the Project Athena Zephyr Notification System. * It contains source for the ZGetSubscriptions function. * * Created by: Robert French * * Copyright (c) 1987 by the Massachusetts Institute of Technology. * For copying and distribution information, see the file * "mit-copyright.h". */ #include "internal.h" #define min(a,b) ((a)<(b)?(a):(b)) /* Prototype for -Wmissing-prototypes */ Code_t ZGetSubscriptions(ZSubscription_t *subscription, int *numsubs); Code_t ZGetSubscriptions(ZSubscription_t *subscription, int *numsubs) { int i; if (!__subscriptions_list) return (ZERR_NOSUBSCRIPTIONS); if (__subscriptions_next == __subscriptions_num) return (ZERR_NOMORESUBSCRIPTIONS); for (i=0;i<min(*numsubs, __subscriptions_num-__subscriptions_next);i++) subscription[i] = __subscriptions_list[i+__subscriptions_next]; if (__subscriptions_num-__subscriptions_next < *numsubs) *numsubs = __subscriptions_num-__subscriptions_next; __subscriptions_next += *numsubs; return (ZERR_NONE); }