Mercurial > pidgin3 / file revision

• file
• latest
• revisions
• annotate
• diff
• comparison
• raw

libpurple/protocols/zephyr/ZRecvPkt.c@a189fa1292c9

libpurple/protocols/zephyr/ZRecvPkt.c

Mon, 28 Feb 2011 07:12:27 +0000

author

Mark Doliner <markdoliner@pidgin.im>

date

Mon, 28 Feb 2011 07:12:27 +0000

changeset 31482

a189fa1292c9

parent 31294

73607ab89c6f

child 40166

811f82db29dd

permissions

-rw-r--r--

Fix a memleak in the MSN prpl when removing a buddy from your buddy list.
We needed to call msn_user_unref() after calling msn_userlist_remove_user()

I chose to fix this by changing msn_userlist_add_user() and
msn_userlist_remove_user() to incremend and decrement the reference counter
themselves--after all, they ARE the ones who add/remove a reference to
the MsnUser struct. Conceptually I thought this made the most sense.

/* This file is part of the Project Athena Zephyr Notification System.
 * It contains source for ZReceivePacket function.
 *
 *	Created by:	Robert French
 *
 *	Copyright (c) 1987,1988 by the Massachusetts Institute of Technology.
 *	For copying and distribution information, see the file
 *	"mit-copyright.h".
 */

#include "internal.h"

Code_t ZReceivePacket(buffer, ret_len, from)
    ZPacket_t buffer;
    int *ret_len;
    struct sockaddr_in *from;
{
    Code_t retval;
    struct _Z_InputQ *nextq;

    if ((retval = Z_WaitForComplete()) != ZERR_NONE)
	return (retval);

    nextq = Z_GetFirstComplete();

    *ret_len = nextq->packet_len;
    if (*ret_len > Z_MAXPKTLEN)
	return (ZERR_PKTLEN);

    (void) memcpy(buffer, nextq->packet, *ret_len);

    if (from)
	*from = nextq->from;

    Z_RemQueue(nextq);

    return (ZERR_NONE);
}