Fri, 23 Dec 2005 19:26:04 +0000
[gaim-migrate @ 14983]
SF Patch #1314512 from Sadrul (who has a patch for everything)
"This patch introduces a flag for protocol plugins that
support offline messages (like Y!M and ICQ). This was
encouraged by the following conversation:
<sadrul> should offline buddies be listed/enabled in
the send-to menu?
<rekkanoryo> i would think only for protocols that
support offline messaging, if it's indicated that the
buddy is offline
-- <snip> --
<Bleeter> sadrul: personally, I'd like to see a
'supports offline' flag of some description
<Bleeter> one could then redirect (via plugins) through
email or alternative methods
<Bleeter> just a thought
<Paco-Paco> yeah, that sounds like a reasonble thing to have
This patch uses this flag to disable the buddies in the
send-to menu who are offline and the protocol doesn't
support offline messages."
I made this make the label insensitive instead of the whole menuitem. This
should address SimGuy's concerns about inconsistency (i.e. you could create a
conversation with someone via the buddy list that you couldn't create via the
Send To menu). I also hacked up some voodoo to show the label as sensitive when
moused-over, as that looks better (given the label-insensitive thing is itself a
hack). I think this works quite well.
BUG NOTE:
This makes more obvious an existing bug. The Send To menu isn't updated when
buddies sign on or off or change status (at least under some circumstances).
We need to fix that anyway, so I'm not going to let it hold up this commit.
Switching tabs will clear it up. I'm thinking we just might want to build the
contents of that menu when it is selected. That would save us a mess of
inefficient signal callbacks that update the Send To menus in open windows all
the time.
AIM NOTE:
This assumes that AIM can't offline message. That's not strictly true. You can
message invisible users on AIM. However, by design, we can't tell when a user
is invisible without resorting to dirty hackery. In practice, this isn't a
problem, as you can still select the AIM user from the menu. And really, how
often will you be choosing the Invisible contact, rather than the user going
Invisible in the middle of a conversation or IMing you while they're Invisible?
JABBER NOTE:
This assumes that Jabber can always offline message. This isn't strictly true.
Sadrul said:
I have updated Jabber according to this link which seems to
talk about how to determine the existence offline-message
support in a server:
http://www.jabber.org/jeps/jep-0013.html#discover
However, jabber.org doesn't seem to send the required
info. So I am not sure about it.
He later said:
I talked to Nathan and he said offline message support is
mostly assumed for most jabber servers. GTalk doesn't yet
support it, but they are working on it. So I have made
jabber to always return TRUE.
If there is truly no way to detect offline messaging capability, then this is
an acceptable solution. We could special case Google Talk because of its
popularity, and remove that later. It's probably not worth it though.
MSN NOTE:
This assumes that MSN can never offline message. That's effectively true, but
to be technically correct, MSN can offline message if there's already a
switchboard conversation open with a user. We could write an offline_message
function in the MSN prpl to detect that, but it'd be of limited usefulness,
especially given that under most circumstances (where this might matter), the
switchboard connection will be closed almost immediately.
CVS NOTE:
I'm writing to share a tragic little story.
I have a PC that I use for Gaim development. One day, I was writing a commit
message on it, when all of a suddent it went berserk. The screen started
flashing, and the whole commit message just disappeared. All of it. And it was
a good commit message! I had to cram and rewrite it really quickly. Needless to
say, my rushed commit message wasn't nearly as good, and I blame the PC for that.
Seriously, though, what kind of version control system loses your commit
message on a broken connection to the server? Stupid!
committer: Richard Laager <rlaager@pidgin.im>
#ifndef __CC_INTERFACE_H__ #define __CC_INTERFACE_H__ #include <gtk/gtk.h> #include "crazychat.h" /* XXX feature encapsulation: still in flux, not stable XXX */ //charlie typedef enum {REMOTE, LOCAL} OUTPUT; gboolean configure(GtkWidget *widget, GdkEventConfigure *event, void *data); #ifdef DISABLE_MODELS #define draw(a, b, c) 1 #define setupDrawlists(a) #else gboolean draw(GtkWidget *widget, GdkEventExpose *event, void *data); void setupDrawlists(OUTPUT output); #endif void init (GtkWidget *widget, void *data); void setupLighting(GtkWidget *widget); struct cc_features { guint8 head_size; guint8 left_eye_open, right_eye_open; /*booleans*/ guint8 mouth_open; /*percentage*/ guint8 head_x_rot, head_y_rot, head_z_rot; /* head rotation */ guint8 x, y; /*center of head*/ guint8 head_color, appendage_color, lid_color, right_iris_color, left_iris_color; //colors guint8 mode, kind; }; struct output_instance { struct cc_features *features; struct cc_session *session; float past_y; OUTPUT my_output; GtkWidget *widget; GtkWidget *box; }; struct input_instance { int timer_id; struct cc_features face; GtkWidget *widget; GtkWidget *box; GtkWidget *button; GtkWidget *label; GtkWidget *model; GtkWidget *head, *appendage, *lid, *right_iris, *left_iris; struct output_instance output; }; struct output_handlers { int (*configure)(GtkWidget *widget, GdkEventConfigure *event, void *data); void (*init) (GtkWidget *widget, void *data); gboolean (*draw) (GtkWidget *widget, GdkEventExpose *event, void *data); }; struct cc_session { struct crazychat *cc; /**< crazychat global data */ char *name; /**< session peer */ guint32 peer_ip; /**< peer's ip addr, nbo */ guint16 peer_port; /**< peer's port hbo */ struct sockaddr_in peer; /**< peer udp sock addr */ CC_STATE state; /**< connection state */ int timer_id; /**< glib timer callback id */ int tcp_sock; /**< tcp socket connection */ int udp_sock; /**< udp socket connection */ struct cc_features features; /**< network peer features */ struct output_instance *output; /**< output instance data */ filter_bank *filter; /**< filter instance */ }; struct crazychat { guint16 tcp_port; /**< tcp port to bind on */ guint16 udp_port; /**< udp session data port */ struct cc_session_node *sessions; /**< list of sessions */ struct input_instance *input_data; /**< input instance data */ gboolean features_state; /**< features state on/off */ }; /* --- input feature interface --- */ #ifdef _DISABLE_QT_ #define init_input(a) NULL #define destroy_input(a) #else /** * Initializes the input subsystem. * @param cc global crazychat data structure * @return pointer to an input instance */ struct input_instance *init_input(struct crazychat *cc); /** * Destroys the input subsystem. * @param instance input instance */ void destroy_input(struct input_instance *instance); #endif /* _DISABLE_QT_ */ /* --- output feature interface --- */ /** * Initializes an output instance. * @param features pointer to features * @param session pointer to the crazychat session * @return pointer to the output instance */ struct output_instance *init_output(struct cc_features *features, struct cc_session *session); /** * Destroys an output instance. * @param instance output instance */ void destroy_output(struct output_instance *instance); #endif