Thu, 21 Nov 2024 21:41:35 -0600
Port account manager to AdwNavigationView
This handles all the forward/back stuff for us (with the `GtkButton`, Escape key, `Alt`-`←`, or mouse back button.)
The editor is currently a page that's re-used. I'm not sure if it's better to use a page per account, but this works just fine.
The overview/placeholder page remains about the same, except the Add button is in an action bar.
The account editor is also about the same, except for the movement of the Back button to the header, and the Save button to the action bar. I also added a Remove button on the opposite end. I'm not sure, but debating whether we should remove the Remove buttons from the overview page since they take up space for something you probably won't do that often.
Testing Done:
Opened empty config, added a Bonjour/IRCv3 account, toggled a few options, went back and forth to overview, and removed the account from both pages.
Reviewed at https://reviews.imfreedom.org/r/3663/
/* * Pidgin - Internet Messenger * Copyright (C) Pidgin Developers <devel@pidgin.im> * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, see <https://www.gnu.org/licenses/>. */ #if !defined(PIDGIN_GLOBAL_HEADER_INSIDE) && !defined(PIDGIN_COMPILATION) # error "only <pidgin.h> may be included directly" #endif #ifndef PIDGIN_ACCOUNT_MANAGER_H #define PIDGIN_ACCOUNT_MANAGER_H #include <gtk/gtk.h> #include <adwaita.h> #include "pidginversion.h" G_BEGIN_DECLS /** * PidginAccountManager: * * A singleton dialog for managing accounts. * * Since: 3.0 */ #define PIDGIN_TYPE_ACCOUNT_MANAGER (pidgin_account_manager_get_type()) PIDGIN_AVAILABLE_IN_3_0 G_DECLARE_FINAL_TYPE(PidginAccountManager, pidgin_account_manager, PIDGIN, ACCOUNT_MANAGER, AdwWindow) /** * pidgin_account_manager_new: * * Creates a new account manager dialog. * * Returns: (transfer full): The dialog. * * Since: 3.0 */ PIDGIN_AVAILABLE_IN_3_0 GtkWidget *pidgin_account_manager_new(void); /** * pidgin_account_manager_show_overview: * @manager: The instance. * * Switches @manager to the overview page. This is useful as @manager might * already be visible but editing an account. * * Since: 3.0 */ PIDGIN_AVAILABLE_IN_3_0 void pidgin_account_manager_show_overview(PidginAccountManager *manager); /** * pidgin_account_manager_edit_account: * @manager: The instance. * @account: The account to edit. * * Opens the account editor in @manager for the given account. * * Since: 3.0 */ PIDGIN_AVAILABLE_IN_3_0 void pidgin_account_manager_edit_account(PidginAccountManager *manager, PurpleAccount *account); G_END_DECLS #endif /* PIDGIN_ACCOUNT_MANAGER_H */