Thu, 07 Apr 2005 14:55:02 +0000
[gaim-migrate @ 12431]
" The following log snippets should explain it: " --rlaager
(20:24:00) rlaager: Regarding the signal handling
conversation the other day... I've written a patch to stop
calling signal handlers and return as soon as we find one
signal handler that returns TRUE to indicate that it's
handled the signal. Is this the right approach?
(20:24:22) Ethan Blanton (Paco-Paco): the trouble is that it's
documented to behave exactly the way it does
(20:24:31) Ethan Blanton (Paco-Paco): so changing it is
notbackwards compatible
(20:24:31) rlaager: I'm talking for HEAD.
(20:24:41) Ethan Blanton (Paco-Paco): oh, I think that's a
good approach, yes
(20:24:53) rlaager: The way I've described is how I
*expected* it to work, having not read the documentation.
(20:25:09) Ethan Blanton (Paco-Paco): I'm convinced
(20:27:04) Stu Tomlinson (nosnilmot): rlaager: this, I
assume, breaks the generic-ness of signals, by assuming
that any that return values return booleans?
(20:27:26) Ethan Blanton (Paco-Paco): please break it
(20:27:33) Ethan Blanton (Paco-Paco): we already have
out-parameters
(20:27:42) rlaager: nosnilmot: from what I can see, the
return type is handled as a (void *)... so I'm checking that
ret_value != NULL
(20:27:57) rlaager: nosnilmot: that's the correct way to do it,
right?
...
(20:29:01) Ethan Blanton (Paco-Paco): allowing a
meaningful return value is an over-engineering
(20:30:07) rlaager: even after this patch, you should be able
to return meaningful return values
(20:30:15) rlaager: it'll just short-circuit on the first handler
that does
committer: Luke Schierer <lschiere@pidgin.im>
/** * @file core.c Gaim Core API * @ingroup core * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "internal.h" #include "cipher.h" #include "connection.h" #include "conversation.h" #include "core.h" #include "debug.h" #include "network.h" #include "plugin.h" #include "pounce.h" #include "prefs.h" #include "privacy.h" #include "proxy.h" #include "savedstatuses.h" #include "signals.h" #include "sslconn.h" #include "status.h" #include "sound.h" struct GaimCore { char *ui; void *reserved; }; static GaimCoreUiOps *_ops = NULL; static GaimCore *_core = NULL; STATIC_PROTO_INIT gboolean gaim_core_init(const char *ui) { GaimCoreUiOps *ops; GaimCore *core; g_return_val_if_fail(ui != NULL, FALSE); g_return_val_if_fail(gaim_get_core() == NULL, FALSE); _core = core = g_new0(GaimCore, 1); core->ui = g_strdup(ui); core->reserved = NULL; ops = gaim_core_get_ui_ops(); /* The signals subsystem is important and should be first. */ gaim_signals_init(); gaim_signal_register(core, "quitting", gaim_marshal_VOID, NULL, 0); /* The prefs subsystem needs to be initialized before static protocols * for protocol prefs to work. */ gaim_prefs_init(); /* Initialize all static protocols. */ static_proto_init(); /* Since plugins get probed so early we should probably initialize their * subsystem right away too. */ gaim_plugins_init(); gaim_plugins_probe(GAIM_PLUGIN_EXT); if (ops != NULL) { if (ops->ui_prefs_init != NULL) ops->ui_prefs_init(); if (ops->debug_ui_init != NULL) ops->debug_ui_init(); } gaim_status_init(); gaim_savedstatuses_init(); gaim_accounts_init(); gaim_ciphers_init(); gaim_connections_init(); gaim_conversations_init(); gaim_debug_init(); gaim_blist_init(); gaim_log_init(); gaim_buddy_icons_init(); gaim_network_init(); gaim_privacy_init(); gaim_pounces_init(); gaim_proxy_init(); gaim_sound_init(); gaim_ssl_init(); if (ops != NULL && ops->ui_init != NULL) ops->ui_init(); return TRUE; } void gaim_core_quit(void) { GaimCoreUiOps *ops; GaimCore *core = gaim_get_core(); g_return_if_fail(core != NULL); /* The self destruct sequence has been initiated */ gaim_signal_emit(gaim_get_core(), "quitting"); /* Transmission ends */ gaim_connections_disconnect_all(); /* Save .xml files, remove signals, etc. */ gaim_ssl_uninit(); gaim_pounces_uninit(); gaim_blist_uninit(); gaim_ciphers_uninit(); gaim_conversations_uninit(); gaim_connections_uninit(); gaim_buddy_icons_uninit(); gaim_accounts_uninit(); gaim_savedstatuses_uninit(); gaim_status_uninit(); gaim_prefs_uninit(); gaim_sound_uninit(); gaim_debug_info("main", "Unloading all plugins\n"); gaim_plugins_destroy_all(); ops = gaim_core_get_ui_ops(); if (ops != NULL && ops->quit != NULL) ops->quit(); gaim_plugins_uninit(); gaim_signals_uninit(); if (core->ui != NULL) { g_free(core->ui); core->ui = NULL; } g_free(core); _core = NULL; } gboolean gaim_core_quit_cb(gpointer unused) { gaim_core_quit(); return FALSE; } const char * gaim_core_get_version(void) { return VERSION; } const char * gaim_core_get_ui(void) { GaimCore *core = gaim_get_core(); g_return_val_if_fail(core != NULL, NULL); return core->ui; } GaimCore * gaim_get_core(void) { return _core; } void gaim_core_set_ui_ops(GaimCoreUiOps *ops) { _ops = ops; } GaimCoreUiOps * gaim_core_get_ui_ops(void) { return _ops; }