Thu, 07 Apr 2005 14:55:02 +0000
[gaim-migrate @ 12431]
" The following log snippets should explain it: " --rlaager
(20:24:00) rlaager: Regarding the signal handling
conversation the other day... I've written a patch to stop
calling signal handlers and return as soon as we find one
signal handler that returns TRUE to indicate that it's
handled the signal. Is this the right approach?
(20:24:22) Ethan Blanton (Paco-Paco): the trouble is that it's
documented to behave exactly the way it does
(20:24:31) Ethan Blanton (Paco-Paco): so changing it is
notbackwards compatible
(20:24:31) rlaager: I'm talking for HEAD.
(20:24:41) Ethan Blanton (Paco-Paco): oh, I think that's a
good approach, yes
(20:24:53) rlaager: The way I've described is how I
*expected* it to work, having not read the documentation.
(20:25:09) Ethan Blanton (Paco-Paco): I'm convinced
(20:27:04) Stu Tomlinson (nosnilmot): rlaager: this, I
assume, breaks the generic-ness of signals, by assuming
that any that return values return booleans?
(20:27:26) Ethan Blanton (Paco-Paco): please break it
(20:27:33) Ethan Blanton (Paco-Paco): we already have
out-parameters
(20:27:42) rlaager: nosnilmot: from what I can see, the
return type is handled as a (void *)... so I'm checking that
ret_value != NULL
(20:27:57) rlaager: nosnilmot: that's the correct way to do it,
right?
...
(20:29:01) Ethan Blanton (Paco-Paco): allowing a
meaningful return value is an over-engineering
(20:30:07) rlaager: even after this patch, you should be able
to return meaningful return values
(20:30:15) rlaager: it'll just short-circuit on the first handler
that does
committer: Luke Schierer <lschiere@pidgin.im>
/** * @file debug.h Debug API * @ingroup core * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #ifndef _GAIM_DEBUG_H_ #define _GAIM_DEBUG_H_ #include <glib.h> #include <stdarg.h> /** * Debug levels. */ typedef enum { GAIM_DEBUG_ALL = 0, /**< All debug levels. */ GAIM_DEBUG_MISC, /**< General chatter. */ GAIM_DEBUG_INFO, /**< General operation Information. */ GAIM_DEBUG_WARNING, /**< Warnings. */ GAIM_DEBUG_ERROR, /**< Errors. */ GAIM_DEBUG_FATAL /**< Fatal errors. */ } GaimDebugLevel; /** * Debug UI operations. */ typedef struct { void (*print)(GaimDebugLevel level, const char *category, const char *format, va_list args); } GaimDebugUiOps; #ifdef __cplusplus extern "C" { #endif /**************************************************************************/ /** @name Debug API */ /**************************************************************************/ /** * Outputs debug information. * * This differs from gaim_debug() in that it takes a va_list. * * @param level The debug level. * @param category The category (or @c NULL). * @param format The format string. * @param args The format parameters. * * @see gaim_debug() */ void gaim_debug_vargs(GaimDebugLevel level, const char *category, const char *format, va_list args); /** * Outputs debug information. * * @param level The debug level. * @param category The category (or @c NULL). * @param format The format string. */ void gaim_debug(GaimDebugLevel level, const char *category, const char *format, ...); /** * Outputs misc. level debug information. * * This is a wrapper for gaim_debug(), and uses GAIM_DEBUG_MISC as * the level. * * @param category The category (or @c NULL). * @param format The format string. * * @see gaim_debug() */ void gaim_debug_misc(const char *category, const char *format, ...); /** * Outputs info level debug information. * * This is a wrapper for gaim_debug(), and uses GAIM_DEBUG_INFO as * the level. * * @param category The category (or @c NULL). * @param format The format string. * * @see gaim_debug() */ void gaim_debug_info(const char *category, const char *format, ...); /** * Outputs warning level debug information. * * This is a wrapper for gaim_debug(), and uses GAIM_DEBUG_WARNING as * the level. * * @param category The category (or @c NULL). * @param format The format string. * * @see gaim_debug() */ void gaim_debug_warning(const char *category, const char *format, ...); /** * Outputs error level debug information. * * This is a wrapper for gaim_debug(), and uses GAIM_DEBUG_ERROR as * the level. * * @param category The category (or @c NULL). * @param format The format string. * * @see gaim_debug() */ void gaim_debug_error(const char *category, const char *format, ...); /** * Outputs fatal error level debug information. * * This is a wrapper for gaim_debug(), and uses GAIM_DEBUG_ERROR as * the level. * * @param category The category (or @c NULL). * @param format The format string. * * @see gaim_debug() */ void gaim_debug_fatal(const char *category, const char *format, ...); /** * Enable or disable printing debug output to the console. * * @param enabled TRUE to enable debug output or FALSE to disable it. */ void gaim_debug_set_enabled(gboolean enabled); /** * Check if console debug output is enabled. * * @return TRUE if debuggin is enabled, FALSE if it is not. */ gboolean gaim_debug_is_enabled(); /*@}*/ /**************************************************************************/ /** @name UI Registration Functions */ /**************************************************************************/ /*@{*/ /** * Sets the UI operations structure to be used when outputting debug * information. * * @param ops The UI operations structure. */ void gaim_debug_set_ui_ops(GaimDebugUiOps *ops); /** * Returns the UI operations structure used when outputting debug * information. * * @return The UI operations structure in use. */ GaimDebugUiOps *gaim_debug_get_ui_ops(void); /*@}*/ /**************************************************************************/ /** @name Debug Subsystem */ /**************************************************************************/ /*@{*/ /** * Initializes the debug subsystem. */ void gaim_debug_init(void); /*@}*/ #ifdef __cplusplus } #endif #endif /* _GAIM_DEBUG_H_ */