Thu, 07 Apr 2005 14:55:02 +0000
[gaim-migrate @ 12431]
" The following log snippets should explain it: " --rlaager
(20:24:00) rlaager: Regarding the signal handling
conversation the other day... I've written a patch to stop
calling signal handlers and return as soon as we find one
signal handler that returns TRUE to indicate that it's
handled the signal. Is this the right approach?
(20:24:22) Ethan Blanton (Paco-Paco): the trouble is that it's
documented to behave exactly the way it does
(20:24:31) Ethan Blanton (Paco-Paco): so changing it is
notbackwards compatible
(20:24:31) rlaager: I'm talking for HEAD.
(20:24:41) Ethan Blanton (Paco-Paco): oh, I think that's a
good approach, yes
(20:24:53) rlaager: The way I've described is how I
*expected* it to work, having not read the documentation.
(20:25:09) Ethan Blanton (Paco-Paco): I'm convinced
(20:27:04) Stu Tomlinson (nosnilmot): rlaager: this, I
assume, breaks the generic-ness of signals, by assuming
that any that return values return booleans?
(20:27:26) Ethan Blanton (Paco-Paco): please break it
(20:27:33) Ethan Blanton (Paco-Paco): we already have
out-parameters
(20:27:42) rlaager: nosnilmot: from what I can see, the
return type is handled as a (void *)... so I'm checking that
ret_value != NULL
(20:27:57) rlaager: nosnilmot: that's the correct way to do it,
right?
...
(20:29:01) Ethan Blanton (Paco-Paco): allowing a
meaningful return value is an over-engineering
(20:30:07) rlaager: even after this patch, you should be able
to return meaningful return values
(20:30:15) rlaager: it'll just short-circuit on the first handler
that does
committer: Luke Schierer <lschiere@pidgin.im>
/* gtkcelllayout.c * Copyright (C) 2003 Kristian Rietveld <kris@gtk.org> * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Library General Public * License as published by the Free Software Foundation; either * version 2 of the License, or (at your option) any later version. * * This library is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Library General Public License for more details. * * You should have received a copy of the GNU Library General Public * License along with this library; if not, write to the * Free Software Foundation, Inc., 59 Temple Place - Suite 330, * Boston, MA 02111-1307, USA. */ /* #include <config.h> */ #include <gtk/gtkversion.h> #if !GTK_CHECK_VERSION(2,4,0) #include "gtkcelllayout.h" GType gtk_cell_layout_get_type (void) { static GType cell_layout_type = 0; if (! cell_layout_type) { static const GTypeInfo cell_layout_info = { sizeof (GtkCellLayoutIface), NULL, NULL, NULL, NULL, NULL, 0, 0, NULL }; cell_layout_type = g_type_register_static (G_TYPE_INTERFACE, "GaimGtkCellLayout", &cell_layout_info, 0); g_type_interface_add_prerequisite (cell_layout_type, G_TYPE_OBJECT); } return cell_layout_type; } /** * gtk_cell_layout_pack_start: * @cell_layout: A #GtkCellLayout. * @cell: A #GtkCellRenderer. * @expand: %TRUE if @cell is to be given extra space allocated to @cell_layout. * * Packs the @cell into the beginning of @cell_layout. If @expand is %FALSE, * then the @cell is allocated no more space than it needs. Any unused space * is divided evenly between cells for which @expand is %TRUE. * * Since: 2.4 */ void gtk_cell_layout_pack_start (GtkCellLayout *cell_layout, GtkCellRenderer *cell, gboolean expand) { g_return_if_fail (GTK_IS_CELL_LAYOUT (cell_layout)); g_return_if_fail (GTK_IS_CELL_RENDERER (cell)); (* GTK_CELL_LAYOUT_GET_IFACE (cell_layout)->pack_start) (cell_layout, cell, expand); } /** * gtk_cell_layout_pack_end: * @cell_layout: A #GtkCellLayout. * @cell: A #GtkCellRenderer. * @expand: %TRUE if @cell is to be given extra space allocated to @cell_layout. * * Adds the @cell to the end of @cell_layout. If @expand is %FALSE, then the * @cell is allocated no more space than it needs. Any unused space is * divided evenly between cells for which @expand is %TRUE. * * Since: 2.4 */ void gtk_cell_layout_pack_end (GtkCellLayout *cell_layout, GtkCellRenderer *cell, gboolean expand) { g_return_if_fail (GTK_IS_CELL_LAYOUT (cell_layout)); g_return_if_fail (GTK_IS_CELL_RENDERER (cell)); (* GTK_CELL_LAYOUT_GET_IFACE (cell_layout)->pack_end) (cell_layout, cell, expand); } /** * gtk_cell_layout_clear: * @cell_layout: A #GtkCellLayout. * * Unsets all the mappings on all renderers on @cell_layout and * removes all renderers from @cell_layout. * * Since: 2.4 */ void gtk_cell_layout_clear (GtkCellLayout *cell_layout) { g_return_if_fail (GTK_IS_CELL_LAYOUT (cell_layout)); (* GTK_CELL_LAYOUT_GET_IFACE (cell_layout)->clear) (cell_layout); } static void gtk_cell_layout_set_attributesv (GtkCellLayout *cell_layout, GtkCellRenderer *cell, va_list args) { gchar *attribute; gint column; GtkCellLayoutIface *iface; attribute = va_arg (args, gchar *); iface = GTK_CELL_LAYOUT_GET_IFACE (cell_layout); (* iface->clear_attributes) (cell_layout, cell); while (attribute != NULL) { column = va_arg (args, gint); (* iface->add_attribute) (cell_layout, cell, attribute, column); attribute = va_arg (args, gchar *); } } /** * gtk_cell_layout_set_attributes: * @cell_layout: A #GtkCellLayout. * @cell: A #GtkCellRenderer. * @Varargs: A %NULL-terminated list of attributes. * * Sets the attributes in list as the attributes of @cell_layout. The * attributes should be in attribute/column order, as in * gtk_cell_layout_add_attribute(). All existing attributes are removed, and * replaced with the new attributes. * * Since: 2.4 */ void gtk_cell_layout_set_attributes (GtkCellLayout *cell_layout, GtkCellRenderer *cell, ...) { va_list args; g_return_if_fail (GTK_IS_CELL_LAYOUT (cell_layout)); g_return_if_fail (GTK_IS_CELL_RENDERER (cell)); va_start (args, cell); gtk_cell_layout_set_attributesv (cell_layout, cell, args); va_end (args); } /** * gtk_cell_layout_add_attribute: * @cell_layout: A #GtkCellLayout. * @cell: A #GtkCellRenderer. * @attribute: An attribute on the renderer. * @column: The column position on the model to get the attribute from. * * Adds an attribute mapping to the list in @cell_layout. The @column is the * column of the model to get a value from, and the @attribute is the * parameter on @cell to be set from the value. So for example if column 2 * of the model contains strings, you could have the "text" attribute of a * #GtkCellRendererText get its values from column 2. * * Since: 2.4 */ void gtk_cell_layout_add_attribute (GtkCellLayout *cell_layout, GtkCellRenderer *cell, const gchar *attribute, gint column) { g_return_if_fail (GTK_IS_CELL_LAYOUT (cell_layout)); g_return_if_fail (GTK_IS_CELL_RENDERER (cell)); g_return_if_fail (attribute != NULL); g_return_if_fail (column >= 0); (* GTK_CELL_LAYOUT_GET_IFACE (cell_layout)->add_attribute) (cell_layout, cell, attribute, column); } /** * gtk_cell_layout_set_cell_data_func: * @cell_layout: A #GtkCellLayout. * @cell: A #GtkCellRenderer. * @func: The #GtkCellLayoutDataFunc to use. * @func_data: The user data for @func. * @destroy: The destroy notification for @func_data. * * Sets the #GtkCellLayoutDataFunc to use for @cell_layout. This function * is used instead of the standard attributes mapping for setting the * column value, and should set the value of @cell_layout's cell renderer(s) * as appropriate. @func may be %NULL to remove and older one. * * Since: 2.4 */ void gtk_cell_layout_set_cell_data_func (GtkCellLayout *cell_layout, GtkCellRenderer *cell, GtkCellLayoutDataFunc func, gpointer func_data, GDestroyNotify destroy) { g_return_if_fail (GTK_IS_CELL_LAYOUT (cell_layout)); g_return_if_fail (GTK_IS_CELL_RENDERER (cell)); (* GTK_CELL_LAYOUT_GET_IFACE (cell_layout)->set_cell_data_func) (cell_layout, cell, func, func_data, destroy); } /** * gtk_cell_layout_clear_attributes: * @cell_layout: A #GtkCellLayout. * @cell: A #GtkCellRenderer to clear the attribute mapping on. * * Clears all existing attributes previously set with * gtk_cell_layout_set_attributes(). * * Since: 2.4 */ void gtk_cell_layout_clear_attributes (GtkCellLayout *cell_layout, GtkCellRenderer *cell) { g_return_if_fail (GTK_IS_CELL_LAYOUT (cell_layout)); g_return_if_fail (GTK_IS_CELL_RENDERER (cell)); (* GTK_CELL_LAYOUT_GET_IFACE (cell_layout)->clear_attributes) (cell_layout, cell); } /** * gtk_cell_layout_reorder: * @cell_layout: A #GtkCellLayout. * @cell: A #GtkCellRenderer to reorder. * @position: New position to insert @cell at. * * Re-inserts @cell at @position. Note that @cell has already to be packed * into @cell_layout for this to function properly. * * Since: 2.4 */ void gtk_cell_layout_reorder (GtkCellLayout *cell_layout, GtkCellRenderer *cell, gint position) { g_return_if_fail (GTK_IS_CELL_LAYOUT (cell_layout)); g_return_if_fail (GTK_IS_CELL_RENDERER (cell)); (* GTK_CELL_LAYOUT_GET_IFACE (cell_layout)->reorder) (cell_layout, cell, position); } #endif /* Gtk 2.4 */