Thu, 07 Apr 2005 14:55:02 +0000
[gaim-migrate @ 12431]
" The following log snippets should explain it: " --rlaager
(20:24:00) rlaager: Regarding the signal handling
conversation the other day... I've written a patch to stop
calling signal handlers and return as soon as we find one
signal handler that returns TRUE to indicate that it's
handled the signal. Is this the right approach?
(20:24:22) Ethan Blanton (Paco-Paco): the trouble is that it's
documented to behave exactly the way it does
(20:24:31) Ethan Blanton (Paco-Paco): so changing it is
notbackwards compatible
(20:24:31) rlaager: I'm talking for HEAD.
(20:24:41) Ethan Blanton (Paco-Paco): oh, I think that's a
good approach, yes
(20:24:53) rlaager: The way I've described is how I
*expected* it to work, having not read the documentation.
(20:25:09) Ethan Blanton (Paco-Paco): I'm convinced
(20:27:04) Stu Tomlinson (nosnilmot): rlaager: this, I
assume, breaks the generic-ness of signals, by assuming
that any that return values return booleans?
(20:27:26) Ethan Blanton (Paco-Paco): please break it
(20:27:33) Ethan Blanton (Paco-Paco): we already have
out-parameters
(20:27:42) rlaager: nosnilmot: from what I can see, the
return type is handled as a (void *)... so I'm checking that
ret_value != NULL
(20:27:57) rlaager: nosnilmot: that's the correct way to do it,
right?
...
(20:29:01) Ethan Blanton (Paco-Paco): allowing a
meaningful return value is an over-engineering
(20:30:07) rlaager: even after this patch, you should be able
to return meaningful return values
(20:30:15) rlaager: it'll just short-circuit on the first handler
that does
committer: Luke Schierer <lschiere@pidgin.im>
/** * @file gtkprivacy.h GTK+ Privacy UI * @ingroup gtkui * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #ifndef _GAIM_GTKPRIVACY_H_ #define _GAIM_GTKPRIVACY_H_ #include "privacy.h" /** * Initializes the GTK+ privacy subsystem. */ void gaim_gtk_privacy_init(void); /** * Determine if showing the privacy dialog is a valid action. * * @return TRUE if there are accounts online that support privacy. * Otherwise return FALSE. */ gboolean gaim_gtk_privacy_is_showable(void); /** * Shows the privacy dialog. */ void gaim_gtk_privacy_dialog_show(void); /** * Hides the privacy dialog. */ void gaim_gtk_privacy_dialog_hide(void); /** * Requests confirmation to add a user to the allow list for an account, * and then adds it. * * If @a name is not specified, an input dialog will be presented. * * @param account The account. * @param name The name of the user to add. */ void gaim_gtk_request_add_permit(GaimAccount *account, const char *name); /** * Requests confirmation to add a user to the block list for an account, * and then adds it. * * If @a name is not specified, an input dialog will be presented. * * @param account The account. * @param name The name of the user to add. */ void gaim_gtk_request_add_block(GaimAccount *account, const char *name); /** * Returns the UI operations structure for the GTK+ privacy subsystem. * * @return The GTK+ UI privacy operations structure. */ GaimPrivacyUiOps *gaim_gtk_privacy_get_ui_ops(void); #endif /* _GAIM_GTKPRIVACY_H_ */