Thu, 07 Apr 2005 14:55:02 +0000
[gaim-migrate @ 12431]
" The following log snippets should explain it: " --rlaager
(20:24:00) rlaager: Regarding the signal handling
conversation the other day... I've written a patch to stop
calling signal handlers and return as soon as we find one
signal handler that returns TRUE to indicate that it's
handled the signal. Is this the right approach?
(20:24:22) Ethan Blanton (Paco-Paco): the trouble is that it's
documented to behave exactly the way it does
(20:24:31) Ethan Blanton (Paco-Paco): so changing it is
notbackwards compatible
(20:24:31) rlaager: I'm talking for HEAD.
(20:24:41) Ethan Blanton (Paco-Paco): oh, I think that's a
good approach, yes
(20:24:53) rlaager: The way I've described is how I
*expected* it to work, having not read the documentation.
(20:25:09) Ethan Blanton (Paco-Paco): I'm convinced
(20:27:04) Stu Tomlinson (nosnilmot): rlaager: this, I
assume, breaks the generic-ness of signals, by assuming
that any that return values return booleans?
(20:27:26) Ethan Blanton (Paco-Paco): please break it
(20:27:33) Ethan Blanton (Paco-Paco): we already have
out-parameters
(20:27:42) rlaager: nosnilmot: from what I can see, the
return type is handled as a (void *)... so I'm checking that
ret_value != NULL
(20:27:57) rlaager: nosnilmot: that's the correct way to do it,
right?
...
(20:29:01) Ethan Blanton (Paco-Paco): allowing a
meaningful return value is an over-engineering
(20:30:07) rlaager: even after this patch, you should be able
to return meaningful return values
(20:30:15) rlaager: it'll just short-circuit on the first handler
that does
committer: Luke Schierer <lschiere@pidgin.im>
/* * @file gtkstatusbox.c GTK+ Status Selection Widget * @ingroup gtkui * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #ifndef __GTK_GAIM_STATUS_BOX_H__ #define __GTK_GAIM_STATUS_BOX_H__ #include <gtk/gtk.h> #include "gtkimhtml.h" #include <gtk/gtktreemodel.h> #include <gtk/gtktreeview.h> #if !GTK_CHECK_VERSION(2,6,0) # include "gtkcellview.h" # include "gtkcellviewmenuitem.h" # if !GTK_CHECK_VERSION(2,4,0) # include "gtkcelllayout.h" # include "gtkcombobox.h" # endif /* Gtk 2.4 */ #endif /* Gtk 2.6 */ G_BEGIN_DECLS #define GTK_GAIM_TYPE_STATUS_BOX (gtk_gaim_status_box_get_type ()) #define GTK_GAIM_STATUS_BOX(obj) (G_TYPE_CHECK_INSTANCE_CAST ((obj), GTK_GAIM_TYPE_STATUS_BOX, GtkGaimStatusBox)) #define GTK_GAIM_STATUS_BOX_CLASS(vtable) (G_TYPE_CHECK_CLASS_CAST ((vtable), GTK_GAIM_TYPE_STATUS_BOX, GtkGaimStatusBoxClass)) #define GTK_GAIM_IS_STATUS_BOX(obj) (G_TYPE_CHECK_INSTANCE_TYPE ((obj), GTK_GAIM_TYPE_STATUS_BOX)) #define GTK_GAIM_IS_STATUS_BOX_CLASS(vtable) (G_TYPE_CHECK_CLASS_TYPE ((vtable), GTK_GAIM_TYPE_STATUS_BOX)) #define GTK_GAIM_STATUS_BOX_GET_CLASS(inst) (G_TYPE_INSTANCE_GET_CLASS ((inst), GTK_GAIM_TYPE_STATUS_BOX, GtkGaimStatusBoxClass)) typedef struct _GtkGaimStatusBox GtkGaimStatusBox; typedef struct _GtkGaimStatusBoxClass GtkGaimStatusBoxClass; struct _GtkGaimStatusBox { GtkComboBox parent_instance; GtkListStore *store; GtkListStore *dropdown_store; GtkWidget *vbox, *sw; GtkWidget *imhtml; gboolean imhtml_visible; GtkWidget *cell_view; GtkCellRenderer *icon_rend; GtkCellRenderer *text_rend; GdkPixbuf *error_pixbuf; int connecting_index; GdkPixbuf *connecting_pixbufs[4]; int typing_index; GdkPixbuf *typing_pixbufs[4]; gboolean connecting; gboolean typing; GtkTreeIter iter; GdkPixbuf *pixbuf; char *title; char *desc; char *error; }; struct _GtkGaimStatusBoxClass { GtkComboBoxClass parent_class; /* signals */ void (* changed) (GtkComboBox *combo_box); /* Padding for future expansion */ void (*_gtk_reserved0) (void); void (*_gtk_reserved1) (void); void (*_gtk_reserved2) (void); void (*_gtk_reserved3) (void); }; GType gtk_gaim_status_box_get_type (void) G_GNUC_CONST; GtkWidget *gtk_gaim_status_box_new (void); void gtk_gaim_status_box_add(GtkGaimStatusBox *status_box, GdkPixbuf *pixbuf, const char *text, const char *sec_text, char *edit); void gtk_gaim_status_box_set_error(GtkGaimStatusBox *status_box, const gchar *error); void gtk_gaim_status_box_set_connecting(GtkGaimStatusBox *status_box, gboolean connecting); void gtk_gaim_status_box_pulse_connecting(GtkGaimStatusBox *status_box); const char *gtk_gaim_status_box_get_active_type(GtkGaimStatusBox *status_box); const char *gtk_gaim_status_box_get_message(GtkGaimStatusBox *status_box); G_END_DECLS #endif /* __GTK_GAIM_GTK_STATUS_COMBO_BOX_H__ */